> I was under the impression that Bodhi would consider the
scenario key
> only if present, otherwise consider all testcase+item-based results
> unique. So it should work both for future and past results (with the
> slight exception of disregarding arch-specific results). Am I missing
> something? Or are you hinting at the arch-specific results
> (depcheck)?
Sorry, yeah, that's exactly the case in point (and older openQA results
that don't include a 'scenario' key, I was planning to teach Bodhi how
to 'synthesize' it for that case). If we remove its existing ability to
'synthesize' the scenario for depcheck results, it'll display older
depcheck results with no scenario key improperly, right?
Theoretically it would display only one depcheck result (based on the last arch tested)
instead of several per-arch results. However, we re-run depcheck almost constantly, so
once we include the scenario key, it will re-test and re-report all results for all
pending RPMs in a few hours (every new package pushed to -pending triggers it). So this
should be a non-issue, hopefully.
So the only problem would be the older OpenQA results, but... is that such a big deal?
It's few days old :) I'd personally avoid having extra code just for this.
I was planning to clearly mark the 'synthesis' code as something that's
needed only so long as we care about older results without the scenario
key, so it can be removed in future.
Of course, an alternative would be to go into ResultsDB and amend all
existing older depcheck and openQA results to include a 'scenario' key.
I don't know if that's frowned-upon, though? I don't think it would be
very technically difficult to *do*, all the necessary information
should still be available (though for openQA results I think we may
have to query some of the values from openQA, I don't believe we
forward all the relevant 'scenario' key values to RDB at this
time...probably we should).
Not worth the energy, I think. Modifying the production database is... worrying. Assuming
depcheck is not a problem, and that you insist on even having the older OpenQA results
showing up properly, maybe it would be easier to re-trigger the older OpenQA jobs?
Provided it's not very hard to do.