[rhq-project/rhq] 310ecc: [1075211] Cannot set custom value for Baseline - H...
by Jay Shaughnessy
Branch: refs/heads/release/jon3.3.x
Home: https://github.com/rhq-project/rhq
Commit: 310eccc41fc23247e6fd2f458fb888c88e84d20a
https://github.com/rhq-project/rhq/commit/310eccc41fc23247e6fd2f458fb888c...
Author: Jay Shaughnessy <jshaughn(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/dashboard/portlets/resource/MetricsChartWindow.java
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/server/gwt/MeasurementDataGWTServiceImpl.java
Log Message:
-----------
[1075211] Cannot set custom value for Baseline - High property
This really only is a problem when there is not yet a baseline. Which is
rare and typically just between import and the next run of the DataCalcJob.
It's not really easy to generate a manually set baseline from scratch, so
I'm just taking the approach of better messaging and error handling:
- Fix error handling such that the root cause of the issue is displayed
when the save fails.
- provide better error handling and provide more specific messaging
- remove the confusing refresh icon (which was sort of acting like a save
option. So, just hitting return is the way to save.
- Hide the edit box when saving.
- protect against GeneralUnhandledException when saving without setting a
value.
Cherry-Pick master 351ab615a83988fda4780df4461d621372eb135a
9 years, 10 months
[rhq-project/rhq] 0283ae: [1075211] Cannot set custom value for Baseline - H...
by Jay Shaughnessy
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: 0283ae950adb75367834266378b18006ce47bb51
https://github.com/rhq-project/rhq/commit/0283ae950adb75367834266378b1800...
Author: Jay Shaughnessy <jshaughn(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/dashboard/portlets/resource/MetricsChartWindow.java
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/server/gwt/MeasurementDataGWTServiceImpl.java
Log Message:
-----------
[1075211] Cannot set custom value for Baseline - High property
This really only is a problem when there is not yet a baseline. Which is
rare and typically just between import and the next run of the DataCalcJob.
It's not really easy to generate a manually set baseline from scratch, so
I'm just taking the approach of better messaging and error handling:
- Fix error handling such that the root cause of the issue is displayed
when the save fails.
- provide better error handling and provide more specific messaging
- remove the confusing refresh icon (which was sort of acting like a save
option. So, just hitting return is the way to save.
- Hide the edit box when saving.
- protect against GeneralUnhandledException when saving without setting a
value.
9 years, 10 months
[rhq-project/rhq] db294f: [BZ 1120418] Inception of the change address job. ...
by Stefan Negrea
Branch: refs/heads/storage_workflow
Home: https://github.com/rhq-project/rhq
Commit: db294fb562bc959c68541a470bacea150b9b11f6
https://github.com/rhq-project/rhq/commit/db294fb562bc959c68541a470bacea1...
Author: Stefan Negrea <snegrea(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/ChangeAddressJob.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/ShutdownStorageClient.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/StartStorageClient.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateStorageNodeEndpoints.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateStorageNodeEntity.java
Log Message:
-----------
[BZ 1120418] Inception of the change address job. Also cleaned some of the step runners.
Commit: 7a8dac35e99d23594033fe427a559383a549b013
https://github.com/rhq-project/rhq/commit/7a8dac35e99d23594033fe427a55938...
Author: Stefan Negrea <snegrea(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/ChangeAddressJob.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/ResourceOperationStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/ShutdownStorageClient.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/StartStorageClient.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateStorageNodeStatus.java
Log Message:
-----------
[BZ 1120418] Fix failures after rebase.
Commit: 302461344733214533da505cd2dbb3a3ae06a080
https://github.com/rhq-project/rhq/commit/302461344733214533da505cd2dbb3a...
Author: Stefan Negrea <snegrea(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/CalculatorLookup.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/DefaultCalculatorLookup.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerBean.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/ChangeAddressJob.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/DeployCalculator.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/FailedRepairCalculator.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/MaintenanceJobFactory.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/MaintenanceJobRunner.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/StepCalculator.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/StorageMaintenanceJobFactory.java
Log Message:
-----------
[BZ 1120418] Rename the interface for job factories and also cleanup the job factory package of old and unused codde.
Commit: 774064690e816cde5be73e8c67ba515d9920b7d1
https://github.com/rhq-project/rhq/commit/774064690e816cde5be73e8c67ba515...
Author: Stefan Negrea <snegrea(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/FailedStepRunner.java
M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/FakeStepRunner.java
M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerBeanTest.java
M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/TestStepRunnerFactory.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/CalculatorLookup.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/DefaultCalculatorLookup.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerBean.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerLocal.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/DefaultStepRunnerFactory.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/JobProperties.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/MaintenanceJobFactory.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/MaintenanceStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/MaintenanceStepRunnerFactory.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/StepFailureException.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/StepFailureStrategy.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/ChangeAddressJob.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/DeployCalculator.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/FailedRepairCalculator.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/MaintenanceJobFactory.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/AddMaintenance.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/AnnounceStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/BaseStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/BootstrapNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/DecommissionStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/DeleteStorageNode.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/MaintenanceStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/RemoveMaintenance.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/ResourceOperationStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/RunRepair.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/ShutdownStorageClient.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/StartStorageClient.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/StepFailureException.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/StepFailureStrategy.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UnannounceStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UninstallStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateSchema.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateStorageNodeEndpoints.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateStorageNodeEntity.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateStorageNodeStatus.java
Log Message:
-----------
[BZ 1120418] Pull interfaces for steps runner and job factory in the main to allow only implementations in subpackages.
Commit: aec0bd55fcf12c29754650f6679165b156481e25
https://github.com/rhq-project/rhq/commit/aec0bd55fcf12c29754650f6679165b...
Author: Stefan Negrea <snegrea(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/DefaultCalculatorLookup.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/ChangeAddress.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/ChangeAddressJob.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/DeployCalculator.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/DeployNode.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/FailedRepair.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/FailedRepairCalculator.java
R modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/UndeployCalculator.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/UndeployNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateSchema.java
Log Message:
-----------
[BZ 1120418] One more name refactoring for the job factories to follow the step runner pattern.
Commit: 31ac6d594ab2cad6fc00d3d880ab8c7890a4d71b
https://github.com/rhq-project/rhq/commit/31ac6d594ab2cad6fc00d3d880ab8c7...
Author: Stefan Negrea <snegrea(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/ShutdownStorageClient.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/StartStorageClient.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateSchema.java
Log Message:
-----------
[BZ 1120418] Cleanup of step runners.
Commit: 23a64249fcc2b9725bb2234382b9de7ab22c986d
https://github.com/rhq-project/rhq/commit/23a64249fcc2b9725bb2234382b9de7...
Author: Stefan Negrea <snegrea(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/DefaultStepRunnerFactory.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/JobProperties.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/MaintenanceJobFactory.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/MaintenanceStepRunnerFactory.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/StepFailureException.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/StepFailureStrategy.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/StorageMaintenanceJob.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/DeployNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/FailedRepair.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/UndeployNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/AddMaintenance.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/AnnounceStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/BaseStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/BootstrapNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/DecommissionStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/DeleteStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/RemoveMaintenance.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/ResourceOperationStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/RunRepair.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UnannounceStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UninstallStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateSchema.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/UpdateStorageNodeStatus.java
Log Message:
-----------
[BZ 1120418] Add licenses to all the newly created classes.
Compare: https://github.com/rhq-project/rhq/compare/18cbe1fafd4b...23a64249fcc2
9 years, 10 months
[rhq-project/rhq] 18cbe1: [BZ 1120418] move creation of new job for failed s...
by John Sanda
Branch: refs/heads/storage_workflow
Home: https://github.com/rhq-project/rhq
Commit: 18cbe1fafd4b9e19ea4c1c1e82ada56fd9c66098
https://github.com/rhq-project/rhq/commit/18cbe1fafd4b9e19ea4c1c1e82ada56...
Author: John Sanda <jsanda(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/core/domain/src/main/java/org/rhq/core/domain/storage/MaintenanceStep.java
M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/FailedStepRunner.java
M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerBeanTest.java
M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/TestStepCalculator.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/DefaultCalculatorLookup.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerBean.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerLocal.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/DeployCalculator.java
A modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/FailedRepairCalculator.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/StepCalculator.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/UndeployCalculator.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/AnnounceStorageNode.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/BaseStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/MaintenanceStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/ResourceOperationStepRunner.java
M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/step/RunRepair.java
Log Message:
-----------
[BZ 1120418] move creation of new job for failed step into the step runner
Prior to this commit when a step whose failure strategy is CONTINUE fails, we
called the StepCalculator to produce a new job for the failed step. The
StepRunner now produces the new job. There are a couple of reasons for the
change. First, it eliminates branching logic that would be necessary in the
StepCalculator. Secondly, the step runner may have info from the failed
execution that needs to be included as input to the new job. This is the case
with repair. When a repair operation fails, we want to get the failed ranges
from the operation history results, and pass those as params to a new job to
rerun repair on said ranges. That operation history is already available to
the step runner. It would have been difficult to make it availble to the
StepCalculator.
9 years, 10 months
[rhq-project/rhq] b5e8b3: Bug 1128614 - RHQ 4.12 high CPU usage in hibernate...
by Thomas Segismont
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: b5e8b3b09d5f05506ecd723feeeb1be5be1af6e5
https://github.com/rhq-project/rhq/commit/b5e8b3b09d5f05506ecd723feeeb1be...
Author: Thomas Segismont <tsegismo(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/BaseComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/HibernatePersistenceUnitComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/json/ReadResource.java
Log Message:
-----------
Bug 1128614 - RHQ 4.12 high CPU usage in hibernate thread (java.util.regex.Pattern$Start.match)
EAP up to 6.3 included has an issue with the JIPI implementation which cause high CPU usage when reading the Hibernate Persistence Unit with :read-resource.
High CPU usage was detected when checking for availability and loading configuration. So the fix consists in:
* BaseComponent#getAvailability change
Read only minimum information as we just want to make sure we can read the resource. There's no need to read the children names, evaluate defaults, and retrieve runtime attributes.
* HibernatePersistenceUnitComponent#loadConfiguration addition
Reading the "enabled" attribute is the only thing needed.
These changes not only fix the issue but generally improve performance in the AS7 plugin (less data sent over the AS7 management connection).
9 years, 10 months
[rhq-project/rhq] 038e60: [790101] - as5 plugin: warnings should not be logg...
by Jay Shaughnessy
Branch: refs/heads/release/jon3.3.x
Home: https://github.com/rhq-project/rhq
Commit: 038e60bf5b05101680a5693a18d2f492c287230e
https://github.com/rhq-project/rhq/commit/038e60bf5b05101680a5693a18d2f49...
Author: Jay Shaughnessy <jshaughn(a)redhat.com>
Date: 2014-08-20 (Wed, 20 Aug 2014)
Changed paths:
M modules/plugins/jboss-as-5/src/main/java/org/rhq/plugins/jbossas5/ApplicationServerDiscoveryComponent.java
Log Message:
-----------
[790101] - as5 plugin: warnings should not be logged for AS/EAP versions that do not require the corresponding jar
I changed the offensive WARN-level message to DEBUG level. It's not really
possible to distinguish between non-existent and non-readable, or to know
which versions require which JAR. If there is a failure then we can turn
on debug to see the message.
Cherry-Pick master bed4b9a72f3f6ec19939e82a9fd27e392dc85a9c
9 years, 10 months
