modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/bundle/list/BundleView.java | 66 +++------- 1 file changed, 24 insertions(+), 42 deletions(-)
New commits: commit 22bafe51d32a5f7ccacb0d5523c30b7b5ac2516c Author: John Mazzitelli mazz@redhat.com Date: Thu Mar 25 17:05:43 2010 -0400
fix summary tab view
diff --git a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/bundle/list/BundleView.java b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/bundle/list/BundleView.java index 7a483e6..4d7575e 100644 --- a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/bundle/list/BundleView.java +++ b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/bundle/list/BundleView.java @@ -23,8 +23,8 @@ import com.smartgwt.client.types.Alignment; import com.smartgwt.client.types.Overflow; import com.smartgwt.client.widgets.Canvas; import com.smartgwt.client.widgets.Label; -import com.smartgwt.client.widgets.layout.HLayout; -import com.smartgwt.client.widgets.layout.LayoutSpacer; +import com.smartgwt.client.widgets.form.DynamicForm; +import com.smartgwt.client.widgets.form.fields.StaticTextItem; import com.smartgwt.client.widgets.layout.VLayout; import com.smartgwt.client.widgets.tab.Tab; import com.smartgwt.client.widgets.tab.TabSet; @@ -39,8 +39,8 @@ public class BundleView extends VLayout { private Label message = new Label("Select a bundle..."); private VLayout canvas; private HeaderLabel headerLabel; - private Label descriptionValue; - private Label latestVersionValue; + private StaticTextItem descriptionItem; + private StaticTextItem latestVersionItem;
public BundleView() { super(); @@ -87,42 +87,24 @@ public class BundleView extends VLayout { private Tab createSummaryTab() { Tab summaryTab = new Tab("Summary");
- VLayout top = new VLayout(); - top.setAutoHeight(); - top.setPadding(20); - top.setWidth100(); - - HLayout descriptionBox = new HLayout(); - descriptionBox.setWidth100(); - descriptionBox.setExtraSpace(10); - Label descriptionLabel = new Label("Description:"); - descriptionLabel.setWidth("10%"); - descriptionLabel.setAlign(Alignment.LEFT); - descriptionLabel.setWrap(false); - descriptionValue = new Label(""); - descriptionValue.setWidth("90%"); - descriptionValue.setAlign(Alignment.LEFT); - descriptionBox.addMember(descriptionLabel); - descriptionBox.addMember(descriptionValue); - top.addMember(descriptionBox); - top.addMember(new LayoutSpacer()); - - HLayout versionBox = new HLayout(); - versionBox.setWidth100(); - versionBox.setExtraSpace(10); - Label versionLabel = new Label("Latest Version:"); - versionLabel.setWidth("10%"); - versionLabel.setAlign(Alignment.LEFT); - versionLabel.setWrap(false); - latestVersionValue = new Label(""); - latestVersionValue.setWidth("90%"); - latestVersionValue.setAlign(Alignment.LEFT); - versionBox.addMember(versionLabel); - versionBox.addMember(latestVersionValue); - top.addMember(versionBox); - top.addMember(new LayoutSpacer()); - - summaryTab.setPane(top); + DynamicForm form = new DynamicForm(); + form.setPadding(10); + + descriptionItem = new StaticTextItem("description", "Description"); + descriptionItem.setTitleAlign(Alignment.LEFT); + descriptionItem.setAlign(Alignment.LEFT); + descriptionItem.setWrap(false); + descriptionItem.setValue(""); + + latestVersionItem = new StaticTextItem("latestVersion", "Latest Version"); + latestVersionItem.setTitleAlign(Alignment.LEFT); + latestVersionItem.setAlign(Alignment.LEFT); + latestVersionItem.setWrap(false); + latestVersionItem.setValue(""); + + form.setFields(descriptionItem, latestVersionItem); + summaryTab.setPane(form); + return summaryTab; }
@@ -132,8 +114,8 @@ public class BundleView extends VLayout {
if (bundleBeingViewed != object.getBundleId()) { headerLabel.setContents(object.getBundleName()); - latestVersionValue.setContents(object.getLatestVersion()); - descriptionValue.setContents(object.getBundleDescription()); + latestVersionItem.setValue(object.getLatestVersion()); + descriptionItem.setValue(object.getBundleDescription()); }
try {
rhq-commits@lists.fedorahosted.org