Branch: refs/heads/storage_workflow Home: https://github.com/rhq-project/rhq Commit: e32eaef942c25b687c7cbef4243737173e027a62 https://github.com/rhq-project/rhq/commit/e32eaef942c25b687c7cbef4243737173e... Author: John Sanda jsanda@redhat.com Date: 2014-08-14 (Thu, 14 Aug 2014)
Changed paths: R modules/core/domain/src/main/java/org/rhq/core/domain/storage/MaintenanceJob.java M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerBeanTest.java M modules/enterprise/server/itests-2/src/test/java/org/rhq/enterprise/server/storage/TestStepCalculator.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/StorageClusterMaintenanceManagerBean.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/StorageMaintenanceJob.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/DeployCalculator.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/MaintenanceJobRunner.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/StepCalculator.java M modules/enterprise/server/jar/src/main/java/org/rhq/enterprise/server/storage/maintenance/job/StorageMaintenanceJobFactory.java
Log Message: ----------- [BZ 1120418] big refactoring for step calculator(s)
The only StepCalculator thus far is DeployCalculator. It had a lot of redundant code for persisting steps. I never really liked having EntityManager and SLSB calls in the step calculator. For one thine, it makes writing unit tests more difficult. Persisting steps has been pushed up to StorageClusterMaintenenanceManagerBean, which also now handles determining whether or not steps need to be recalculated.
rhq-commits@lists.fedorahosted.org