modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RoleEditView.java | 8 +++++--- modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RolesView.java | 10 ++++++++-- 2 files changed, 13 insertions(+), 5 deletions(-)
New commits: commit 2ab62ba6ae4b0d533bc47e46155c80a4af34804d Author: Ian Springer ian.springer@redhat.com Date: Wed Mar 9 11:40:46 2011 -0500
fix so role details view can again be reached by selecting a role from the roles list view (https://bugzilla.redhat.com/show_bug.cgi?id=683429)
diff --git a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RoleEditView.java b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RoleEditView.java index 0264d3b..58cde04 100644 --- a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RoleEditView.java +++ b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RoleEditView.java @@ -291,7 +291,7 @@ public class RoleEditView extends AbstractRecordEditor<RolesDataSource> implemen .view_adminConfig_systemSettings())); label.setWidth100(); label.setHeight(20); - label.setPadding(5); + label.setPadding(10); updateTab(this.ldapGroupsTab, label); } } @@ -303,10 +303,12 @@ public class RoleEditView extends AbstractRecordEditor<RolesDataSource> implemen protected List<FormItem> createFormItems(EnhancedDynamicForm form) { List<FormItem> items = new ArrayList<FormItem>();
- TextItem nameItem = new TextItem(RolesDataSource.Field.NAME, MSG.common_title_name()); + TextItem nameItem = new TextItem(RolesDataSource.Field.NAME); + nameItem.setShowTitle(true); items.add(nameItem);
- TextItem descriptionItem = new TextItem(RolesDataSource.Field.DESCRIPTION, MSG.common_title_description()); + TextItem descriptionItem = new TextItem(RolesDataSource.Field.DESCRIPTION); + descriptionItem.setShowTitle(true); descriptionItem.setColSpan(form.getNumCols()); items.add(descriptionItem);
diff --git a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RolesView.java b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RolesView.java index 7dac43e..46fa148 100644 --- a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RolesView.java +++ b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/admin/roles/RolesView.java @@ -59,14 +59,17 @@ public class RolesView extends TableSection<RolesDataSource> implements Bookmark public RolesView(String locatorId) { super(locatorId, MSG.view_adminSecurity_roles());
- fetchManageSecurityPermissionAsync(); - final RolesDataSource datasource = RolesDataSource.getInstance(); setDataSource(datasource); setHeaderIcon(HEADER_ICON); }
@Override + protected void onDraw() { + fetchManageSecurityPermissionAsync(); + } + + @Override protected void configureTable() { updateSelectionStyle(); getListGrid().addCellClickHandler(new CellClickHandler() { @@ -159,6 +162,9 @@ public class RolesView extends TableSection<RolesDataSource> implements Bookmark } else { hasManageSecurity = false; } + if (!initialized) { + RolesView.super.onDraw(); + } initialized = true; } });
rhq-commits@lists.fedorahosted.org