modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/dashboard/DashboardView.java | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
New commits: commit c5911757c793d85971b5fadad6ce14a978214949 Author: Jay Shaughnessy jshaughn@redhat.com Date: Mon Jan 10 16:02:52 2011 -0500
- Fix a classcast problem for removeColumn - remove a couple of useless lines of code
diff --git a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/dashboard/DashboardView.java b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/dashboard/DashboardView.java index 17a6158..3460e3e 100644 --- a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/dashboard/DashboardView.java +++ b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/dashboard/DashboardView.java @@ -187,8 +187,8 @@ public class DashboardView extends LocatableVLayout { int numColumns = columns.length; if (numColumns > 0) { PortalColumn lastColumn = (PortalColumn) columns[numColumns - 1]; - for (PortletWindow portletWindow : (PortletWindow[]) lastColumn.getMembers()) { - storedDashboard.removePortlet(portletWindow.getStoredPortlet()); + for (Canvas portletWindow : lastColumn.getMembers()) { + storedDashboard.removePortlet(((PortletWindow) portletWindow).getStoredPortlet()); } portalLayout.removeMember(lastColumn); numColItem.setValue(numColumns - 1); @@ -317,9 +317,7 @@ public class DashboardView extends LocatableVLayout {
private void loadPortletWindows() {
- int col = 0; for (int i = 0; i < storedDashboard.getColumns(); i++) { - for (DashboardPortlet storedPortlet : storedDashboard.getPortlets(i)) { final PortletWindow portletWindow = new PortletWindow(portalLayout .extendLocatorId(getPortletLocatorId(storedPortlet)), this, storedPortlet); @@ -329,10 +327,8 @@ public class DashboardView extends LocatableVLayout { portletWindow.setHeight(storedPortlet.getHeight()); portletWindow.setVisible(true);
- portalLayout.addPortletWindow(portletWindow, col); + portalLayout.addPortletWindow(portletWindow, i); } - - col++; } }
rhq-commits@lists.fedorahosted.org