On Mon, Mar 25, 2013 at 11:27 PM, Ankur Sinha sanjay.ankur@gmail.com wrote:
On Mon, 2013-03-25 at 23:03 -0400, Rich Mattes wrote:
Hi all,
Hi Rich,
I've started the process of cleaning up my ROS Fuerte packages and submitting them for review. Currently, the following are posted (in rough build order:)
rospack: https://bugzilla.redhat.com/show_bug.cgi?id=927458 ros: https://bugzilla.redhat.com/show_bug.cgi?id=927461 roscpp_core: https://bugzilla.redhat.com/show_bug.cgi?id=927462 python-genmsg: https://bugzilla.redhat.com/show_bug.cgi?id=927470 python-gencpp: https://bugzilla.redhat.com/show_bug.cgi?id=927473 python-genlisp: https://bugzilla.redhat.com/show_bug.cgi?id=927475 python-genpy: https://bugzilla.redhat.com/show_bug.cgi?id=927478
Yep. My mail is littered with ros packages review mails from bugzilla ;)
Yeah all of the reviews require catkin to continue, so I blocked them against the catkin review bug. Sorry about the spam!
Please have a look and let me know if you have any comments or suggestions (especially on package naming.) I'm still not sure if these names are too generic or not. Where applicable, each package Provides: ros-%{packagename} as well, and those are the names I'm using when another package Requires: them.
The next package I'm working (std_msgs) has a really generic name, I think I'm going to call it ros-std_msgs before I put it up. I know the packaging guidelines discourage using underscores in package names, but I think since that's what upstream is using that it's ok (if I'm reading that guideline right)
I'll work on getting the rest of the packages up in the coming days.
I'll review as many as possible. I haven't anything else fedora related in my cycles at the moment. Thanks for putting up the packages. If you do need me to package anything (and then we can swap reviews, which might make it quicker), do let me know. I'll wait for you to tell me what to package since you have a much better understanding of the ros dep tree etc. :)
There's like 4 packages left for the fuerte underlay. I already have them made, so I think I'll just trudge through them this week and then we can start figuring out how to package stacks (tf, geometry, perception_pcl, nodelet, etc.)
Rich