This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/63/ |
On August 20th, 2014, 5:16 p.m. UTC, Thomas Woerner wrote:
config/roles/domaincontroller/role.py (Diff revision 2) 137 props = copy.deepcopy(self._DEFAULTS)Please use self._settings and not self._DEFAULTS here.
If the deploy method will be called later on again (maybe in redeploy) then the former settings will not be used.
- Thomas
On August 20th, 2014, 2:09 a.m. UTC, Stephen Gallagher wrote:
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
By Stephen Gallagher.
Updated Aug. 20, 2014, 2:09 a.m.
Repository:
rolekit
Description
Testing
Diffs
|