On August 26th, 2015, 2:09 p.m. UTC, Stephen Gallagher wrote:

src/rolekit/server/io/rolesettings.py (Diff revision 1)
		68	if "changed" in self._callbacks and self._callbacks["changed"]:
		69	cb = self._callbacks["changed"]

Similarly, isn't it more pythonic for this to be:
try:
    cb = self._callbacks["changed"]
except KeyError:
    # Log the lack of a changed callback
    return
cb_args = [ key, value ]
...

This will never fail, because self._callbacks = { "changed": None } is set in init. cb will be None if no handler is set.

- Thomas

On August 26th, 2015, 1:21 p.m. UTC, Thomas Woerner wrote:

Only the changed signal is supported right now. As soon as a settings is
modified, the connected handler will be called for this setting.