|
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Nils Philippsen.
Updated Sept. 23, 2015, 5:17 nachm.
Repository:
rolekit
Description
Use an internal implementation instead of calling sed to tweak
configuration files. This has the neat side effect of overwriting the
target file as the last step, side-stepping the need to copy over the
backup file on errors.
This change requires python3-slip >= 0.6.4 because in previous versions
slip.util.files.overwrite_safely() doesn't preserve file ownership, and
the postgresql configuration files need to be owned by the postgres user.
https://github.com/libre-server/rolekit/issues/21
|
Testing
Deployed databaseserver role, compared contents of postgresql.conf, pg_hba.conf with what the original sed commands produced.
|
Diffs (updated)
- config/roles/databaseserver/role.py (7443979ba7ff87ff6a018ac8a7a0a89e2b8ad6e7)
- rolekit.spec (f3cf9f4b799909bc293f4e56eea78c71e7112e9c)
View Diff
|