This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/124/ 

What do you thing about an additional parameter for deploy to enable/disable start right after deploying?

- Thomas Woerner


On November 21st, 2014, 5:02 p.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
By Stephen Gallagher.

Updated Nov. 21, 2014, 5:02 p.m.

Bugs: 35
Repository: rolekit

Description 

Many server installers will automatically start their services as
soon as installation is complete (such as FreeIPA). This means that
the real state of the system will disagree with rolekit's view of
it. To be sure that we are aligned, it makes the most sense to just
ensure that all roles are deployed into the RUNNING state.

Testing 

Deployed a domain controller and verified that after deployment, 'rolectl status domaincontroller/teeceetwo.sgallagh.rht' reported "running" and 'systemctl status role-domaincontroller-teeceetwo.sgallagh.rht.target' reported "active".

Diffs

  • src/rolekit/server/rolebase.py (7f960bf41206c2552996936839a100325382e3be)

View Diff