| This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/111/ |
| doc/xml/rolekit.xml (Diff revision 1) | |||
|---|---|---|---|
| 65 | Roles are loaded from the <filename><config.rolekit_roles/></filename> directory. Each role has his own sub directory and is named as the directory. The directory contains role.py, that is deriving from RoleBase and implementing the role. |
||
| 66 | </para> |
||
| 67 | <para> |
||
| 68 | Role instance settings are loaded from the <filename><config.etc_rolekit_roles/></filename> directory. Each role instance has his own sub directory in there using the name of the role as the directory name. The directory contains JSON settings files using the name of the instances as the filename with the JSON extension. |
||
"Each role has his own sub directory and is named as the directory." sounds a bit twisted and potentially unclear. Maybe something like: "Each role owns a directory named after the role itself."
Also do we really need to add details about role.py / RoleBase here ? BEcause if so then we need to be clearer as a file cannot derive from a class (and we should probably say 'inherit' ?) :-)
| doc/xml/rolekit.xml (Diff revision 1) | |||
|---|---|---|---|
| 68 | Role instance settings are loaded from the <filename><config.etc_rolekit_roles/></filename> directory. Each role instance has his own sub directory in there using the name of the role as the directory name. The directory contains JSON settings files using the name of the instances as the filename with the JSON extension. |
||
Convoluted, possible alternative: "Each role instance owns a sub directory in <filename><config.etc_rolekit_roles/></filename>, named after the role. The directory contains..."
- Simo Sorce
On October 31st, 2014, 3:47 p.m. UTC, Thomas Woerner wrote:
|
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Thomas Woerner.
Updated Oct. 31, 2014, 3:47 p.m.
Repository:
rolekit
Description
Diffs
|