This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/162/

On July 21st, 2015, 2:45 p.m. UTC, Thomas Woerner wrote:

src/rolekit/server/rolebase.py (Diff revision 1) 
def redeploy(self, values, sender=None):
 
def redeploy(self, values, reply_handler, error_handler, sender=None):
 

    1048
    

  


 




  
As redeploy can be used for failed deplyments (package install or firewall configuration or systemd configuration failed)


These need to be added here to make it work in these cases.

 









This is optional for now, but should be addressed for 0.4.0








- Thomas






On July 15th, 2015, 4:10 p.m. UTC, Stephen Gallagher wrote:











 

  


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.


By Stephen Gallagher.




Updated July 15, 2015, 4:10 p.m.












 Repository: 
rolekit





Description 

 

 

  
   
Make redeploy routine asynchronous

  		
 






Testing 



 

  
   
Tested with review #161

  		
 






Diffs 


    

 
  • config/roles/databaseserver/role.py (f0ec96d4bb0555baf961f3e973e01742fc3f8ac0)
    • 

 
  • config/roles/domaincontroller/role.py (29f6be8f68d8f9f29d9531f27363ea46e7ef8e52)
    • 

 
  • config/roles/testrole/role.py (8d8d145e4d81c730aeb47f38cf2a98ca8550840e)
    • 

 
  • src/rolekit/server/rolebase.py (fec2de57f2bce114de28c3bfcd4ed75e29e2dd58)
    • 





View Diff