This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/163/

On July 21st, 2015, 3:35 p.m. UTC, Thomas Woerner wrote:

config/roles/memcache/role.py (Diff revision 1) 

    24
    
import docker

  


 




  
There is no requirement for docker in the rolekit spec file.

 




 
On July 21st, 2015, 3:37 p.m. UTC, Thomas Woerner wrote:

 

  
This should be python-docker-py or python3-docker-py depending on fedora version

 











No, it shouldn't. Rolekit is presently python3-only. It will still run on older systems with the python 3 interpreter.








- Stephen






On July 16th, 2015, 6:53 p.m. UTC, Stephen Gallagher wrote:











 

  


Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.


By Stephen Gallagher.




Updated July 16, 2015, 6:53 p.m.












 Repository: 
rolekit





Description 

 

 

  
   
Just add
"contained": True

to the settings JSON to try it out.

  		
 






Testing 



 

  
   
Repeatedly created, decommissioned and redeployed the role

  		
 






Diffs 


    

 
  • config/roles/memcache/role.py (PRE-CREATION)
    • 

 
  • src/rolekit/server/io/systemd.py (ad28004e874db123f51ecad8ff39d1e863b8b604)
    • 





View Diff