| This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/196/ |
| src/rolekit/server/io/rolesettings.py (Diff revision 1) | |||
|---|---|---|---|
| 43 | The signal to conenct to, right now only "changed" is supported. |
||
Typo: "conenct" -> "connect"
| src/rolekit/server/io/rolesettings.py (Diff revision 1) | |||
|---|---|---|---|
| 52 | if name in self._callbacks: |
||
| 53 | self._callbacks[signal] = (handler, args) |
||
| 54 | else: |
||
| 55 | raise ValueError("Unknown signal name '%s'" % name) |
||
Wouldn't it be more "pythonic" to do:
try: self._callbacks[signal] = (handler, args) except KeyError: raise ValueError("Unknown signal name '%s'" % name)
| src/rolekit/server/io/rolesettings.py (Diff revision 1) | |||
|---|---|---|---|
| 68 | if "changed" in self._callbacks and self._callbacks["changed"]: |
||
| 69 | cb = self._callbacks["changed"] |
||
Similarly, isn't it more pythonic for this to be:
try: cb = self._callbacks["changed"] except KeyError: # Log the lack of a changed callback return cb_args = [ key, value ] ...
| src/rolekit/server/io/rolesettings.py (Diff revision 1) | |||
|---|---|---|---|
| 72 | if cb[1]: |
||
| 73 | # add call data |
||
| 74 | cb_args.extend(cb[1]) |
||
try: cb_args.extend(cb[1]) except TypeError: # Got None here pass
- Stephen Gallagher
On August 26th, 2015, 1:21 p.m. UTC, Thomas Woerner wrote:
|
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Thomas Woerner.
Updated Aug. 26, 2015, 1:21 p.m.
Repository:
rolekit
Description
Diffs
|