This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/ |
On September 1st, 2015, 9:36 a.m. UTC, Thomas Woerner wrote:
src/rolekit/server/io/rolesettings.py (Diff revisions 6 - 7) 63 elif name in self.get_instances(self._type):This is resulting in a ValueError for already deployed roles (instances) while roled starts.
The ValueError should only happen if there is another instance or pendingrole with the same name. It should not complain on a conflict the instance iteself.
2015-09-01 11:08:39 DEBUG1: Loading 'foo' instance '1' 2015-09-01 11:08:39 Traceback (most recent call last): File "rolekit/server/decorators.py", line 40, in handle_exceptions return func(args, *kwargs) File "rolekit/server/dbusrole.py", line 80, in init settings = RoleSettings(self._name, instance) File "rolekit/server/io/rolesettings.py", line 64, in init raise ValueError("Instance name already in use") ValueError: Instance name already in use
- Thomas
On August 31st, 2015, 3:37 p.m. UTC, Stephen Gallagher wrote:
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.
Updated Aug. 31, 2015, 3:37 p.m.
Bugs:
1
Repository:
rolekit
Description
Testing
Diffs
|