This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/111/

doc/xml/rolekit.xml (Diff revision 1)
55
      A plugin interface is used for simple role creation. Each role is a plugin to rolekit and can therefore be easily created. A D-Bus interface and also a command line client is avilable for role management. 

"avilable" -> "available"

Also, there's a trailing space.


doc/xml/rolekit.xml (Diff revision 1)
65
       Roles are loaded from the <filename><config.rolekit_roles/></filename> directory. Each role has his own sub directory and is named as the directory. The directory contains role.py, that is deriving from RoleBase and implementing the role.
66
    </para>
67
    <para>
68
       Role instance settings are loaded from the <filename><config.etc_rolekit_roles/></filename> directory. Each role instance has his own sub directory in there using the name of the role as the directory name. The directory contains JSON settings files using the name of the instances as the filename with the JSON extension.

config.rolekit_roles and the etc variant do not get substituted in the HTML documentation.


doc/xml/rolekit.xml (Diff revision 1)
81
		  Checks that the name is valid and that there is no conflict with another instances of that role.

"instances->instance"


doc/xml/rolekit.xml (Diff revision 1)
119
        <listitem>
120
	  <para>
121
	    Installs firewall settings.
122
	  </para>
123
	</listitem>
124
125
        <listitem>
126
	  <para>
127
	    Calls <replaceable>Role.do_deploy_async</replaceable> method.
128
	  </para>
129
	</listitem>

These two items are reversed. We do the installation and only set up the firewall rules when it's completed successfully.


- Stephen Gallagher


On October 31st, 2014, 3:47 p.m. UTC, Thomas Woerner wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Thomas Woerner.

Updated Oct. 31, 2014, 3:47 p.m.

Repository: rolekit

Description

docs: Updated global rolekit man page.

Diffs

  • doc/xml/rolekit.xml (ce3a709c84446534bac19d9ec2fce6a1133de241)
  • doc/xml/transform-man.xsl.in (066644b61861a39e22eb7807e26417392eac2c8c)

View Diff