This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/176/

src/rolectl (Diff revision 1)
208
    if a.list == "roles":
208
    if not hasattr(a, "list"):
209
        grp_list.print_usage()
210
        sys.exit(0)
211
    elif a.list == "roles":

Please check for an AttributeError exception instead of using hasattr().


- Stephen Gallagher


On August 3rd, 2015, 3:52 p.m. UTC, Nils Philippsen wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Nils Philippsen.

Updated Aug. 3, 2015, 3:52 p.m.

Repository: rolekit

Description

rolectl: handle "rolectl list" without command

Testing

Simply called rolectl list without roles or instances.

Diffs

  • src/rolectl (73ff76e6c0dda59690410934dbfb366f63252fc1)

View Diff