This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/158/

config/roles/databaseserver/tools/rk_db_setpwd.py (Diff revision 3) 
def main():
78 
    user_pass = raw_input(False)
 78 
    user_pass = input(False)
 
Should be noted that input is a different function on Python2 which equals to running eval on raw_input.

src/rolekit/async.py (Diff revision 3) 
def start_with_callbacks(generator, result_handler, error_handler):
132 
                if exception is not None:
 133 
                if exception:
 
Check if exception is not None and simple if exception is not the same thing.


In if exception is not None will go to else branch only if exception is None.


In if exception will got else branch if exception is None, or 0, or '', or whatever what evaluates to False

- Robert Kuska


On jún 24th, 2015, 12:11 popoludní UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated jún 24, 2015, 12:11 popoludní

Repository: rolekit

Description 

Switch to Python 3


So far, only the Database Server Role and the main role infrastructure has been converted.


There is a lot of tracing added in this patch which aided in debugging the port. I decided not to separate it into a separate patch primarily because it would be too much effort.

Testing 

Deployed both Domain Controller roles and Database Server Roles to a fresh VM using Vagrant.

Diffs

  • config/Makefile.am (8d6df0e54809cfa1858d9ecc955205a6d68478b5)
  • config/roles/databaseserver/role.py (b363d29cc1430ebd19924c6029386f059ad5183b)
  • config/roles/databaseserver/tools/rk_db_setpwd.py (c7fecaaa78a392b2d0ea2525d3a563169d852c29)
  • configure.ac (dd4b473e5983ced7f3ecf08e457d4578d1eaa9f0)
  • fix_python_shebang.sh (8a0430ce35605e0067f03fa2219c902a8bcbc85c)
  • rolekit.spec (8d798da1c386997061c19e393ea95a3940ff6db1)
  • src/rolectl (7d978c2365bbb8e67b19df2d95bf6ac04b8cfe90)
  • src/roled (954071f1d9ee3bedff3525728ba8d5a0c0ec49ed)
  • src/rolekit/async.py (b2ba8f8f048757efcf57cb7eaf19fc071c28e5a6)
  • src/rolekit/server/rolebase.py (5deceba3fa7f63f25ff9021c57a63b5470abc1f0)

View Diff