This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/179/ |
On August 27th, 2015, 1:16 p.m. UTC, Thomas Woerner wrote:
The patch does not apply cleanly right now.
A solution for the following issues might be delayed for F-23 final: - The service of a delayed deploy should be removed at the next boot if deployment was successful. Right now the service is inactive and not deactivated. Which might make a later delayed deploy of the role with the same name not working. - Additionally there is no way to remove the pendingrole services altogether with the settings file. - There is an additional check needed if a user defined name for the instance is already used by another role instance. Otherwise there will be an error at the next boot while deploying the role. This could happen if delayed deploy is used in a already running system (which is not forbidden).
The service of a delayed deploy is removed at the end of a successful deploy process. See line 993-1015 of rolebase.py. If it's not actually removed, then it's possible there's an SELinux permission bug. But the
ConditionPathExists
bit of the unit file prevents it from trying to continue deploying.Yes, we should open a bug to allow cancelling a pending deployment (before it starts, of course).
That last one should be an issue with this patch. I'll fix it.
- Stephen
On August 26th, 2015, 6:23 p.m. UTC, Stephen Gallagher wrote:
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.
Updated Aug. 26, 2015, 6:23 p.m.
Bugs:
1
Repository:
rolekit
Description
Testing
Diffs
|