On July 30th, 2015, 11:55 a.m. UTC, Stephen Gallagher wrote:

config/roles/domaincontroller/role.py (Diff revision 1)
def do_decommission_async(self, force=False, sender=None):
278	def do_update(self, sender=None):	278	def do_update_async(self, sender=None):
279	# Do the magic	279	# Do the magic
280	#	280	#
281	# In case of error raise an exception	281	# In case of error raise an exception
282	pass	282	yield None

I think we may want to raise a NotImplementedError() here, rather than yielding None, actually. If we return success, users may think we really updated, when in fact we have done nothing at all.

On July 30th, 2015, 12:51 p.m. UTC, Nils Philippsen wrote:

That's a case of "monkey sees, monkey learns". When other routines where made async, a simple pass became yield None. Perhaps we should check other occurrances of yield None as well?

Yes, those would have been wrong, but they were short-term issues because the conversions were usually a step towards replacing it with a real implementation. I agree we should review the existing code for any such mistakes, though.

- Stephen

On July 30th, 2015, 7:52 a.m. UTC, Nils Philippsen wrote:

https://github.com/libre-server/rolekit/issues/5