This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/194/

On August 20th, 2015, 10:03 a.m. UTC, Nils Philippsen wrote:

Why not network.target? Or don't we (as in Fedora) care about any other targets than multi-user and graphical?

Because we only want rolekit to run when the machine is in at least one of the "usable" states. network.target is enabled in a variety of other places (possibly including the system-update.target or similar).

multi-user.target is a subset of graphical.target and is always present if we are booting to either one. network.target is better used for ordering rather than WantedBy (if we absolutely needed NICs to be available before rolekit started, I'd still do WantedBy=multi-user.target and add in After=network.target, but we don't; rolekit only uses UNIX sockets (and eventually kdbus), which will be fully covered by basic.target which does not need to be explicitly ordered after.


- Stephen


On August 19th, 2015, 5:59 p.m. UTC, Stephen Gallagher wrote:

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
By Stephen Gallagher.

Updated Aug. 19, 2015, 5:59 p.m.

Repository: rolekit

Description

This should have been multi-user.target all along.

Diffs

  • config/rolekit.service.in (cf78e1fef3a9a4315128d84d9bb5a2d7ba1e33a3)

View Diff