This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/111/ |
On October 31st, 2014, 7:50 p.m. UTC, Stephen Gallagher wrote:
doc/xml/rolekit.xml (Diff revision 1) 119 <listitem>
120 <para>121 Installs firewall settings.
122 </para>123 </listitem>124 125 <listitem>
126 <para>127 Calls <replaceable>Role.do_deploy_async</replaceable> method.128 </para>129 </listitem>These two items are reversed. We do the installation and only set up the firewall rules when it's completed successfully.
The ports might already be needed for deploying, therefore dropping this request.
- Thomas
On October 31st, 2014, 3:47 p.m. UTC, Thomas Woerner wrote:
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
By Thomas Woerner.
Updated Oct. 31, 2014, 3:47 p.m.
Repository:
rolekit
Description
Diffs
|