Dne 29. 09. 21 v 20:26 Otto Urpelainen napsal(a):
Otto Urpelainen kirjoitti 29.9.2021 klo 20.39:
> Vít Ondruch kirjoitti 29.9.2021 klo 13.56:
>>
>> Dne 27. 09. 21 v 19:38 Otto Urpelainen napsal(a):
>>> I have determined the reason for those changes is that the files
>>> inside jekyll 4.2.1 gem have CRLF line endings.
>>
>> This seems strange. Was there really some change like this in
>> upstream? Then it should be possible to understand the reason for
>> such change from Git log, but I can't find such change in Git
>> neither I can see CRLF in e.g.
>>
https://raw.githubusercontent.com/jekyll/jekyll/master/lib/jekyll.rb.
>> Therefore I suspect that this might be release engineering issue.
>> Somebody released the gem from Windows where it previously was
>> released from Linux. This is something upstream should address.
>
> The reason why I did not contact upstream yet was that I was not able
> to find any specification or best practices saying that gems should
> be released in one form or another. I guess I can write to upstream
> and notify them that this change has caused trouble, maybe it was
> just an accident and they want to revert to avoid any further trouble:
>
>
https://github.com/jekyll/jekyll/issues/8826
Upstream confirmed that this was a mistake. A new release should be
available in a few days, I will wait for this.
I wonder if this should be considered as a single incident that is
unlikely to repeat, or as something that can happen to any Ruby
package at any time, and should be protected against somehow? Maybe in
different conditions the build would have succeeded, but the unusual
line endings would cause other problems at user installations.
I think I have already met similar issue earlier for some other package
and I my guess is that the release was done by the person for the first
time. The main issue IMO is that the release process should be ideally
automated and done always by the same infrastructure. This would limit
this kind of issues. But of course, that is not easy for smallish
projects ...
Not sure if there is something more we should do on our side. Calling
dos2unix for every file would be probably suboptimal.
I just wonder, if you called something like `ruby exe/jekyll - --help`,
would Ruby by more tolerant to line endings? And could be (Ba)sh be more
tolerant to the line endings?
Vít
Otto
_______________________________________________
ruby-sig mailing list -- ruby-sig(a)lists.fedoraproject.org
To unsubscribe send an email to ruby-sig-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraprojec...
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure