On 06/24/2010 12:28 AM, Mamoru Tasaka wrote:
Mohammed Morsi wrote, at 06/24/2010 09:24 AM +9:00:
On 06/23/2010 04:49 PM, Jim Meyering wrote:
Mohammed Morsi wrote:
Just uploaded a new Ruby 1.8.7 SRPM which reverts the search path to what it was in Ruby 1.8.6.
You beat me to it. Thanks.
There is one major change, as noted before even though the Ruby 1.8.6 rpm included /usr/lib64/site_ruby in the search path, this directory does not exist and is not created / provided by the rpm, so I omitted it. If there is a valid reason for its inclusion, it can be readded,
I confirm that the paths containing /usr/lib64/site_ruby are removed but the rest are in order:
$ LD_LIBRARY_PATH=. ./ruby -e 'puts $:'|sdiff -w78 orig-path - /usr/lib/ruby/site_ruby/1.8 /usr/lib/ruby/site_ruby/1.8 /usr/lib64/ruby/site_ruby/1.8 /usr/lib64/ruby/site_ruby/1.8 /usr/lib64/ruby/site_ruby/1.8/x86_64- /usr/lib64/ruby/site_ruby/1.8/x86_64- /usr/lib/ruby/site_ruby /usr/lib/ruby/site_ruby /usr/lib64/ruby/site_ruby /usr/lib64/ruby/site_ruby /usr/lib64/site_ruby/1.8< /usr/lib64/site_ruby/1.8/x86_64-linux< /usr/lib64/site_ruby< /usr/lib/ruby/1.8 /usr/lib/ruby/1.8 /usr/lib64/ruby/1.8 /usr/lib64/ruby/1.8 /usr/lib64/ruby/1.8/x86_64-linux /usr/lib64/ruby/1.8/x86_64-linux . .
I think it would be prudent to include all three. That they are listed in ruby's default path is reason enough. That may have encouraged some people to create and use one or more of the directories. Whether the 1.8.6 rpm actually created/owned them isn't the issue. People may be relying on those being in ruby's default search path.
Readded, though honestly I'm not a fan of this reasoning. If its not in the Fedora / Ruby guidelines, it's not supported and thus we shouldn't add the additional complexity. Furthermore this approach would result in none of the paths ever changing, which obviously we don't want. Going forward we should identify only the paths that are supported and only include those.
We need not change these (i.e. paths) with the upgrade of 1.8.6.x -> 1.8.7.x. We just ensure that everything just go well with only ruby rpm (and its subpackages) upgraded from 1.8.6.x to 1.8.7.x without trouble.
And, anyway with ruby 1.9 (which currently kanarip is trying to package), there is a big big change.
Once again, I respectfully disagree with this, though with the goal of getting to 1.8.7 in as quickly as possible, I'll leave them in the package.
I disagree because I believe these directories being on the path is a pretty obvious mistake (eg the directory doesn't exist in the filesystem) and thus anyone using this directory is not conforming to Fedora/Ruby guidelines. I think its prudent that we fix the mistake ASAP so that additional software doesn't depend on this directory which will ultimately have to be removed from the path.
New SRPM uploaded:
Anyway I appreciate your contribution.
Regards, Mamoru
Not a problem, I'm working towards the next release taking your and Jim's feedback into account (also the newly released Ruby version), which should be out momentarily.
-Mo