On 06/24/2010 01:48 PM, Jim Meyering wrote:
Mamoru Tasaka wrote:
Mohammed Morsi wrote, at 06/24/2010 09:24 AM +9:00:
New SRPM uploaded: http://mo.morsi.org/files/ruby-1.8.7.249-5.fc13.src.rpm
By the way it seems 1.8.7p299 was released yesterday so please consider to upgrade.
Thanks for the heads-up. Good timing. It appears that removing two patches is sufficient to adapt:
- remove patch30, aka ruby-1.8.7-openssl-1.0.patch; subsumed
Are we absolutely sure we don't need this? Looking at the patch, yes it seems the changes to ossl.c and ossl_pkcs7.c made it into the upstream codebase, but the changes to ossl_ssl.c are still missing.
Ruby compiles fine, but I just don't want to omit something that fixes a critical bug or what not.
- remove patch101, aka ruby-1.8.7-rb_gc_guard_ptr-optimization.patch; subsumed
Agree on this one though, all these changes made it in upstream and thus this patch was removed (the patchset is looking nice and concise now).
The only things that I think are missing is readding the bits to pull in the tcltk branch for the ruby-tcltk package (if we still need this) and possibly an issue w/ Config::CONFIG['archdir'] being different than it is with 1.8.6. I verified that this is the only config value that is different (good test to add to the Ruby test suite), but am having some trouble compiling the rpm when I change it to match the value in 1.8.6, will this be an issue?
(BTW completely unrelated, but I'm out tommorow and most likely won't be available via email/irc, back on Monday)
-Mo