Vít Ondruch wrote on 2019/01/29 20:58:

Dne 29. 01. 19 v 12:29 Mamoru TASAKA napsal(a):

Zdenek Dohnal wrote on 2019/01/29 18:07:

Hi,

I'm just adding my 'cent' to ruby 2.6 mass rebuild - Vim started to
fail after ruby-2.6 was introduced to rawhide, but it fails only on
i686 and armv7hl:

i686:
task: https://koji.fedoraproject.org/koji/taskinfo?taskID=32309685
log:
https://kojipkgs.fedoraproject.org//work/tasks/9685/32309685/build.log

armv7hl:
task: https://koji.fedoraproject.org/koji/taskinfo?taskID=32309687
log:
https://kojipkgs.fedoraproject.org//work/tasks/9687/32309687/build.log

The error looks like mistake in C programming, but I already tried to
build current Vim with old ruby in copr and the build passes, but it
fails with new ruby. Did anyone encounter such errors with new ruby?

Actually this is due to API change on rb_int2big in ruby 2.6:

https://github.com/ruby/ruby/commit/d77e8a7da596fc23acd76c785548f6314114f97a

https://bugs.ruby-lang.org/issues/14036

Right. Please see the attached patch for naive fix of this issue (it
builds on i686 with the patch, that is all I tested). However, there
should be probably some Ruby version checks, because I suspect the patch
won't work on Ruby 2.5 and older.

I'll probably open Ruby upstream ticket pointing out the issue. But not
sure what anwer to expect ¯\_(ツ)_/¯

https://bugs.ruby-lang.org/issues/15570

Vít

Or the attached patch may be preferable (ruby version check added).

Looks better. Thx.

Vít

Regards,
Mamoru

_______________________________________________
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org
To unsubscribe send an email to ruby-sig-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/ruby-sig@lists.fedoraproject.org