Hey Ruby packagers: can you help with asciibinder and its dependencies?

[Matthew Miller]

We're using a new system for http://docs.fedoraproject.org. It's in Ruby, and as per tradition requires a number of ruby gems not packaged in Fedora.

The upstream is at https://github.com/redhataccess/ascii_binder, and it looks like we're missing diff_dirs, asciibinder-diagram, guard, guard-shell, guard-livereload, pandoc-ruby, sitemap_generator, and yajl-ruby. Plus something called "trollop" which needs to be a version in f27/rawhide but not yet in f26.

Can you help? Running asciibinder locally is very convenient while writing or converting docs, and having it a `dnf install` away would be really nice.

[Vít Ondruch]

I might try to take a look but ...

Dne 5.9.2017 v 22:41 Matthew Miller napsal(a):
> We're using a new system for http://docs.fedoraproject.org. It's in Ruby, and as per tradition requires a number of ruby gems not packaged in Fedora.
>
> The upstream is at https://github.com/redhataccess/ascii_binder, and it looks like we're missing diff_dirs, asciibinder-diagram, guard, guard-shell, guard-livereload, pandoc-ruby, sitemap_generator, and
> yajl-ruby

this one ^^ is cursed:

https://bugzilla.redhat.com/show_bug.cgi?id=823351
https://bugzilla.redhat.com/show_bug.cgi?id=1114146

Vít
> . Plus something called "trollop" which needs to be a version in f27/rawhide but not yet in f26.
>
> Can you help? Running asciibinder locally is very convenient while writing or converting docs, and having it a `dnf install` away would be really nice.
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Vít Ondruch]

I setup Copr repository here:

https://copr.fedorainfracloud.org/coprs/vondruch/ascii_binder

Will see how far I can get ... Will try to cut the dependencies as much
as possible from the beginning ...

Vít

Dne 6.9.2017 v 12:01 Vít Ondruch napsal(a):
> I might try to take a look but ...
>
> Dne 5.9.2017 v 22:41 Matthew Miller napsal(a):
> > We're using a new system for http://docs.fedoraproject.org. It's in Ruby, and as per tradition requires a number of ruby gems not packaged in Fedora.
> >
> > The upstream is at https://github.com/redhataccess/ascii_binder, and it looks like we're missing diff_dirs, asciibinder-diagram, guard, guard-shell, guard-livereload, pandoc-ruby, sitemap_generator, and 
> > yajl-ruby
>
> this one ^^ is cursed:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=823351
> https://bugzilla.redhat.com/show_bug.cgi?id=1114146
>
> Vít
> > . Plus something called "trollop" which needs to be a version in f27/rawhide but not yet in f26.
> >
> > Can you help? Running asciibinder locally is very convenient while writing or converting docs, and having it a `dnf install` away would be really nice.
> > _______________________________________________
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Matthew Miller]

> I setup Copr repository here:
> https://copr.fedorainfracloud.org/coprs/vondruch/ascii_binder
>
> Will see how far I can get ... Will try to cut the dependencies as much
> as possible from the beginning ...

Awesome -- thanks!

[Vít Ondruch]

Actually I've finished 1st version. I am not sure how much is it broken,
since I dropped almost all dependencies [1]. I know for sure, that
"asciibinder watch" does not work. Please give it a try and let me know
what should be improved.

Vít

[1]
http://copr-dist-git.fedorainfracloud.org/cgit/vondruch/ascii_binder/rubygem...

Dne 12.9.2017 v 17:17 Matthew Miller napsal(a):
> > I setup Copr repository here:
> > https://copr.fedorainfracloud.org/coprs/vondruch/ascii_binder
> >
> > Will see how far I can get ... Will try to cut the dependencies as much
> > as possible from the beginning ...
>
> Awesome -- thanks!
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Brian (bex) Exelbierd]

Hi Vit,

Could you push a build against F26 so I can test it against the Fedora Docs repos?

Thanks,

bex

[Vít Ondruch]

Hi Bex,

Unfortunately, the packages requires F27+ for build, but they should
work on F26 just fine I hope. Could you try the F28 packages please?

V.

Dne 26.10.2017 v 00:08 Brian (bex) Exelbierd napsal(a):
> Hi Vit,
>
> Could you push a build against F26 so I can test it against the Fedora Docs repos?
>
> Thanks,
>
> bex
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Jason Brooks]

> Actually I've finished 1st version. I am not sure how much is it broken,
> since I dropped almost all dependencies [1]. I know for sure, that
> "asciibinder watch" does not work. Please give it a try and let me know
> what should be improved.

I got this error:

Error: 
 Problem: conflicting requests
  - nothing provides rubygem(sitemap_generator) < 5.2 needed by rubygem-ascii_binder-0.1.10.1-1.fc28.noarch
> Vít
>
> [1]
> http://copr-dist-git.fedorainfracloud.org/cgit/vondruch/ascii_binder/ruby...
>
> Dne 12.9.2017 v 17:17 Matthew Miller napsal(a):

[Vít Ondruch]

Dne 8.11.2017 v 20:31 Jason Brooks napsal(a):
> > Actually I've finished 1st version. I am not sure how much is it broken,
> > since I dropped almost all dependencies [1]. I know for sure, that
> > "asciibinder watch" does not work. Please give it a try and let me know
> > what should be improved.
>
> I got this error:
>
> Error: 
>  Problem: conflicting requests
> nothing provides rubygem(sitemap_generator) < 5.2 needed by rubygem-ascii_binder-0.1.10.1-1.fc28.noarch

Thanks for the testing.

This is interesting. I can definitely reproduce. However the change
fixing this is in Copr dist-git [1]. Not sure what went wrong. I'll try
to rebuild and will see.

Vít

[1]
http://copr-dist-git.fedorainfracloud.org/cgit/vondruch/ascii_binder/rubygem...
> > Vít
> >
> > [1]
> > http://copr-dist-git.fedorainfracloud.org/cgit/vondruch/ascii_binder/ruby...
> >
> > Dne 12.9.2017 v 17:17 Matthew Miller napsal(a):
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Vít Ondruch]

Dne 9.11.2017 v 08:35 Vít Ondruch napsal(a):
> Dne 8.11.2017 v 20:31 Jason Brooks napsal(a):
> > > Actually I've finished 1st version. I am not sure how much is it broken,
> > > since I dropped almost all dependencies [1]. I know for sure, that
> > > "asciibinder watch" does not work. Please give it a try and let me know
> > > what should be improved.
> >
> > I got this error:
> >
> > Error: 
> >  Problem: conflicting requests
> > nothing provides rubygem(sitemap_generator) < 5.2 needed by rubygem-ascii_binder-0.1.10.1-1.fc28.noarch
>
> Thanks for the testing.
>
> This is interesting. I can definitely reproduce. However the change
> fixing this is in Copr dist-git [1]. Not sure what went wrong. I'll try
> to rebuild and will see.

New build is ready and the dependencies looks better now:

~~~
$ rpm -qRp
https://copr-be.cloud.fedoraproject.org/results/vondruch/ascii_binder/fedora...
| grep site
rubygem(sitemap_generator) >= 5.1.0
~~~

Could you please give it another try? Thx.

Vít

[Jason Brooks]

> Could you please give it another try? Thx.

Ok, this is working. I know you said that "watch" won't work, I don't know how critical it is, but this functionality is referenced in our contributor guide: https://github.com/projectatomic/atomic-host-docs/blob/master/contribution/c...

I think maybe that's just a convenience though?
> Vít

[Vít Ondruch]

Dne 16.11.2017 v 01:09 Jason Brooks napsal(a):
> > Could you please give it another try? Thx.
>
> Ok, this is working.

Thx for testing.
> I know you said that "watch" won't work, I don't know how critical it is, but this functionality is referenced in our contributor guide: https://github.com/projectatomic/atomic-host-docs/blob/master/contribution/c...

Thx for pointing this out.
> I think maybe that's just a convenience though?

Yes, I think so. The good news is that there is ongoing effort to have
packaged more of these dependencies, but hard to predict ETA.

The question for me is if the asciibinder in the current "crippled"
state is acceptable and helpful for Fedora documentation team or if we
should wait (until the "watch" is ready for example).

Vít

[Matthew Miller]

On Thu, Nov 16, 2017 at 09:29:50AM +0100, Vít Ondruch wrote:
> The question for me is if the asciibinder in the current "crippled"
> state is acceptable and helpful for Fedora documentation team or if we
> should wait (until the "watch" is ready for example).

I think it's good. I've just been running 'asciibinder package' since
that's what bex told me to do. Apparently there are other options which
I should look into. :)

[Vít Ondruch]

Dne 16.11.2017 v 15:53 Matthew Miller napsal(a):
> On Thu, Nov 16, 2017 at 09:29:50AM +0100, Vít Ondruch wrote:
> > The question for me is if the asciibinder in the current "crippled"
> > state is acceptable and helpful for Fedora documentation team or if we
> > should wait (until the "watch" is ready for example).
>
> I think it's good. I've just been running 'asciibinder package' since
> that's what bex told me to do. Apparently there are other options which
> I should look into. :)

So here are two reviews for the beginning:

rubygem-diff_dirs - https://bugzilla.redhat.com/show_bug.cgi?id=1518181
rubygem-sitemap_generator -
https://bugzilla.redhat.com/show_bug.cgi?id=1518169

I'll look into rubygem-ascii_binder later again, since the
sitemap_generator had new major release in the mean time. But from the
brief look, the API should be backward compatible. They just dropped
support for older rubies (actually I made the patch and shipped in the
package anyway, they just did that officially :) ) and some AWS stuff is
not pre-loaded anymore.

V.

[Matthew Miller]

On Tue, Nov 28, 2017 at 12:40:42PM +0100, Vít Ondruch wrote:
> rubygem-diff_dirs - https://bugzilla.redhat.com/show_bug.cgi?id=1518181
> rubygem-sitemap_generator -
> https://bugzilla.redhat.com/show_bug.cgi?id=1518169

I can *technically* review these, but it would probably be better if
someone who knows the specifics of Ruby packaging did. Any volunteers?

[Brian (bex) Exelbierd]

> Dne 16.11.2017 v 01:09 Jason Brooks napsal(a):
>
> Thx for testing.
>
> Thx for pointing this out.
>
> Yes, I think so. The good news is that there is ongoing effort to have
> packaged more of these dependencies, but hard to predict ETA.
>
> The question for me is if the asciibinder in the current "crippled"
> state is acceptable and helpful for Fedora documentation team or if we
> should wait (until the "watch" is ready for example).

I'll try to test this soon against Fedora Docs.

Also, can we get a patch to have the crippled commands return messages about the crippling and not just fail.

Lastly, pandoc-ruby looks like an unneeded dependency upstream.  I'll work on a patch.

thanks,

bex
> Vít

[Brian (bex) Exelbierd]

> I'll try to test this soon against Fedora Docs.

I pulled the rpms for ascii_binder, sitemap_generator and git from your COPR.  diff_dirs didn't look like it was building, so I gem installed it.

Installing leads me to need a newer trollop, however that is, as you've pointed out, only packaged for F27 and Rawhide, so I also dnf installed it from rawhide.

Other than not having the latest release which has commits Fedora Docs relies on, it seemed to work.
> Also, can we get a patch to have the crippled commands return messages about the crippling
> and not just fail.
>
> Lastly, pandoc-ruby looks like an unneeded dependency upstream.  I'll work on a
> patch.

Upstream as: https://github.com/redhataccess/ascii_binder/pull/123

regards,

bex
> thanks,
>
> bex
> > Vít

[Vít Ondruch]

https://bugzilla.redhat.com/show_bug.cgi?id=1526056

I submitted review for rubygem-ascii_doctor. The guard is on its way:

https://gitlab.com/jackorp/rubygem-guard

although there will be necessary to resolve funny issues such as:

https://bugzilla.redhat.com/show_bug.cgi?id=960064#c9

Vít

Dne 16.11.2017 v 09:29 Vít Ondruch napsal(a):
> Dne 16.11.2017 v 01:09 Jason Brooks napsal(a):
> > > Could you please give it another try? Thx.
> >
> > Ok, this is working.
>
> Thx for testing.
> > I know you said that "watch" won't work, I don't know how critical it is, but this functionality is referenced in our contributor guide: https://github.com/projectatomic/atomic-host-docs/blob/master/contribution/c...
>
> Thx for pointing this out.
> > I think maybe that's just a convenience though?
>
> Yes, I think so. The good news is that there is ongoing effort to have
> packaged more of these dependencies, but hard to predict ETA.
>
> The question for me is if the asciibinder in the current "crippled"
> state is acceptable and helpful for Fedora documentation team or if we
> should wait (until the "watch" is ready for example).
>
> Vít
> _______________________________________________
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Brian Exelbierd]

Top Posting: I am not qualified to review ruby packages, but I would like to see these get reviewed.  Barring huge changes, AsciiBinder is part of our infrastructure for the next while. a/k/a post 4th quarter holidays *bump*

Thanks,

bex

On Thu, Dec 14, 2017, at 6:17 PM, Vít Ondruch wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1526056
>
> I submitted review for rubygem-ascii_doctor. The guard is on its way:
>
> https://gitlab.com/jackorp/rubygem-guard
>
> although there will be necessary to resolve funny issues such as:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=960064#c9
>
> Vít
>
> Dne 16.11.2017 v 09:29 Vít Ondruch napsal(a):
> > Dne 16.11.2017 v 01:09 Jason Brooks napsal(a):
> > > > Could you please give it another try? Thx.
> > >
> > > Ok, this is working.
> >
> > Thx for testing.
> > > I know you said that "watch" won't work, I don't know how critical it is, but this functionality is referenced in our contributor guide: https://github.com/projectatomic/atomic-host-docs/blob/master/contribution/c...
> >
> > Thx for pointing this out.
> > > I think maybe that's just a convenience though?
> >
> > Yes, I think so. The good news is that there is ongoing effort to have
> > packaged more of these dependencies, but hard to predict ETA.
> >
> > The question for me is if the asciibinder in the current "crippled"
> > state is acceptable and helpful for Fedora documentation team or if we
> > should wait (until the "watch" is ready for example).
> >
> > Vít
> > _______________________________________________
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Vít Ondruch]

AsciiBinder is now available in Fedora Rawhide. There is still missing
the livereload support, but not sure how important it is.

Vít

Dne 4.1.2018 v 10:14 Brian Exelbierd napsal(a):
> Top Posting: I am not qualified to review ruby packages, but I would like to see these get reviewed.  Barring huge changes, AsciiBinder is part of our infrastructure for the next while. a/k/a post 4th quarter holidays *bump*
>
> Thanks,
>
> bex
>
> On Thu, Dec 14, 2017, at 6:17 PM, Vít Ondruch wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1526056
> >
> > I submitted review for rubygem-ascii_doctor. The guard is on its way:
> >
> > https://gitlab.com/jackorp/rubygem-guard
> >
> > although there will be necessary to resolve funny issues such as:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=960064#c9
> >
> > Vít
> >
> > Dne 16.11.2017 v 09:29 Vít Ondruch napsal(a):
> > > Dne 16.11.2017 v 01:09 Jason Brooks napsal(a):
> > > > > Could you please give it another try? Thx.
> > > >
> > > > Ok, this is working.
> > >
> > > Thx for testing.
> > > > I know you said that "watch" won't work, I don't know how critical it is, but this functionality is referenced in our contributor guide: https://github.com/projectatomic/atomic-host-docs/blob/master/contribution/c...
> > >
> > > Thx for pointing this out.
> > > > I think maybe that's just a convenience though?
> > >
> > > Yes, I think so. The good news is that there is ongoing effort to have
> > > packaged more of these dependencies, but hard to predict ETA.
> > >
> > > The question for me is if the asciibinder in the current "crippled"
> > > state is acceptable and helpful for Fedora documentation team or if we
> > > should wait (until the "watch" is ready for example).
> > >
> > > Vít
> > > _______________________________________________
> > > ruby-sig mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> >
> > ruby-sig mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> ruby-sig mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Matthew Miller]

On Wed, Feb 07, 2018 at 02:26:54PM +0100, Vít Ondruch wrote:
> AsciiBinder is now available in Fedora Rawhide. There is still missing
> the livereload support, but not sure how important it is.

Nice -- thank you!

I personally don't care about the livereload support. Brian's
instructions are to just use "asciibinder package" all the time and
ignore all of the tools other workflow functionality, so that's what I
do. :)

[Brian Exelbierd]

On Wed, Feb 7, 2018, at 5:28 PM, Matthew Miller wrote:
> On Wed, Feb 07, 2018 at 02:26:54PM +0100, Vít Ondruch wrote:
> > AsciiBinder is now available in Fedora Rawhide. There is still missing
> > the livereload support, but not sure how important it is.

It'd be nice to see the land for the general use case, but as mattdm points out - I don't use it and haven't advised it's use.

Fantastic work!

Now I am going to go commit some more dependencies in the upstream :)

regards,

bex
> Nice -- thank you!
>
> I personally don't care about the livereload support. Brian's
> instructions are to just use "asciibinder package" all the time and
> ignore all of the tools other workflow functionality, so that's what I
> do. :)
>
> -- 
> Matthew Miller
>
> Fedora Project Leader