Hi Mamoru,
I have just noticed this commit and I wonder if you considered modifying the .gemspec instead:
~~~
%gemspec_add_dep -g base64
~~~
I think this will be needed for project using Bundler. I realize that modifying .gemspec has its own side-effects, though.
Vít
-------- Přeposlaná zpráva -------- Předmět: [Git] mtasaka pushed to rpms/rubygem-em-socksify (rawhide). "also add Requires for rubygem(base64)" Datum: Mon, 11 Nov 2024 06:52:17 +0000 (UTC) Od: Fedora Notifications notifications@fedoraproject.org Komu: vondruch@redhat.com
From 0372de0e7687c836b9a5afb06d2f72a2edd6cb36 Mon Sep 17 00:00:00 2001 From: Mamoru TASAKA mtasaka@fedoraproject.org Date: 2024-11-11T15:52:01+09:00 Subject: also add Requires for rubygem(base64)
also add Requires for rubygem(base64)
---
diff --git a/rubygem-em-socksify.spec b/rubygem-em-socksify.spec index 4a16de4..4301ddd 100644 --- a/rubygem-em-socksify.spec +++ b/rubygem-em-socksify.spec @@ -2,7 +2,7 @@ Name: rubygem-%{gem_name} Version: 0.3.0 -Release: 28%{?dist} +Release: 29%{?dist} Summary: Transparent proxy support for any EventMachine protocol License: MIT URL: https://github.com/igrigorik/em-socksify @@ -11,6 +11,7 @@ Source1: MIT-LICENSE BuildRequires: ruby(release) BuildRequires: rubygems-devel BuildRequires: rubygem(base64) +Requires: rubygem(base64) BuildArch: noarch %if 0%{?fc19} || 0%{?fc20} Requires: ruby(release) @@ -72,8 +73,8 @@ cp -p %{SOURCE1} %{buildroot}/%{gem_instdir}/ %{gem_instdir}/em-socksify.gemspec %changelog -* Mon Nov 11 2024 Mamoru TASAKA mtasaka@fedoraproject.org - 0.3.0-28 -- Add BR: rubygem(base64) explicitly for ruby34 +* Mon Nov 11 2024 Mamoru TASAKA mtasaka@fedoraproject.org - 0.3.0-29 +- Add dependency for rubygem(base64) explicitly for ruby34 * Fri Jul 19 2024 Fedora Release Engineering releng@fedoraproject.org - 0.3.0-27 - Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild
https://src.fedoraproject.org/rpms/rubygem-em-socksify/c/0372de0e7687c836b9a...
ruby-sig@lists.fedoraproject.org