rubygem-rack in epel and fedora

[Michael Stahnke]

I'd like to bump rubygem-rack to the latest (1.2.1) in Rawhide and
EPEL.  I was worried about EPEL and even started making a seperate
branch for a rack1 package, but according to my queries, the only
packages requiring rack in EPEL are:



EPEL:

stahnma@tyr /home/stahnma> repoquery -q --whatrequires "rubygem(rack)"
rubygem-sinatra-1:1.0-2.el5.noarch
rubygem-shotgun-0:0.4-1.el5.noarch



F13:

stahnma@olive /home/stahnma> repoquery --whatrequires "rubygem(rack)"
rubygem-actionpack-1:2.3.5-1.fc13.noarch
rubygem-actionpack-1:2.3.5-2.fc13.noarch
rubygem-merb-core-0:1.0.15-1.fc13.noarch
rubygem-shotgun-0:0.4-1.fc13.noarch
rubygem-sinatra-1:0.9.4-2.fc12.noarch
rubygem-sinatra-1:1.0-1.fc13.noarch
rubygem-thin-0:1.2.5-5.fc13.i686


There are some API changes between rack-0.9 and rack-1.2, but mostly
semantics.  For rawhide/fedora, I am pretty sure it will be ok.  What
are the thoughts for this update in EPEL?  It would allow sinatra,
shotgun, and possibly a new (parallel) version of rails.

stahnma

[Michal Fojtik]

On 12/09/10 19:34 -0500, Michael Stahnke wrote:
> I'd like to bump rubygem-rack to the latest (1.2.1) in Rawhide
> and
> EPEL.  I was worried about EPEL and even started making a seperate
> branch for a rack1 package, but according to my queries, the only
> packages requiring rack in EPEL are:
>
>
>
> EPEL:
>
> stahnma@tyr /home/stahnma> repoquery -q --whatrequires "rubygem(rack)"
> rubygem-sinatra-1:1.0-2.el5.noarch
> rubygem-shotgun-0:0.4-1.el5.noarch
>
>
>
> F13:
>
> stahnma@olive /home/stahnma> repoquery --whatrequires "rubygem(rack)"
> rubygem-actionpack-1:2.3.5-1.fc13.noarch
> rubygem-actionpack-1:2.3.5-2.fc13.noarch
> rubygem-merb-core-0:1.0.15-1.fc13.noarch
> rubygem-shotgun-0:0.4-1.fc13.noarch
> rubygem-sinatra-1:0.9.4-2.fc12.noarch
> rubygem-sinatra-1:1.0-1.fc13.noarch
> rubygem-thin-0:1.2.5-5.fc13.i686 
FYI: when I tried to use rack-1.2.1 with new Rack I got:
(same error for Rails 2.3.5)

<snip>
/usr/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/utils.rb:138:in `union': can't
convert Array into String (TypeError)
  from /usr/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/utils.rb:138
</snip>

I'll contact Sinatra upstream to fix it.

  -- Michal

-- 
--------------------------------------------------------
Michal Fojtik, mfojtik(a)redhat.com
Deltacloud API: http://deltacloud.org
--------------------------------------------------------

[Mo Morsi]

  On 09/13/2010 08:31 AM, Michal Fojtik wrote:
>  On 12/09/10 19:34 -0500, Michael Stahnke wrote:
> > I'd like to bump rubygem-rack to the latest (1.2.1) in Rawhide and
> > EPEL.  I was worried about EPEL and even started making a seperate
> > branch for a rack1 package, but according to my queries, the only
> > packages requiring rack in EPEL are:
> >
> >
> >
> > EPEL:
> >
> > stahnma@tyr /home/stahnma>  repoquery -q --whatrequires "rubygem(rack)"
> > rubygem-sinatra-1:1.0-2.el5.noarch
> > rubygem-shotgun-0:0.4-1.el5.noarch
> >
> >
> >
> > F13:
> >
> > stahnma@olive /home/stahnma>  repoquery --whatrequires "rubygem(rack)"
> > rubygem-actionpack-1:2.3.5-1.fc13.noarch
> > rubygem-actionpack-1:2.3.5-2.fc13.noarch
> > rubygem-merb-core-0:1.0.15-1.fc13.noarch
> > rubygem-shotgun-0:0.4-1.fc13.noarch
> > rubygem-sinatra-1:0.9.4-2.fc12.noarch
> > rubygem-sinatra-1:1.0-1.fc13.noarch
> > rubygem-thin-0:1.2.5-5.fc13.i686
>  FYI: when I tried to use rack-1.2.1 with new Rack I got:
>  (same error for Rails 2.3.5)
>
>  <snip>
>  /usr/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/utils.rb:138:in `union': can't
> convert Array into String (TypeError)
>     from /usr/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/utils.rb:138
>  </snip>
>
>  I'll contact Sinatra upstream to fix it.
>
>     -- Michal
>  
I discovered and reported this issue (or at least a very similar one) a 
little while back. Its not a upstream problem, rather a Fedora packaging 
problem as we change actionpack 2.3.5 to be compatible with Rack 1.1.0

https://bugzilla.redhat.com/show_bug.cgi?id=617803

The problem is though we miss one important change which is causing this 
error. My updated patch to actionpack fixes this

http://mo.morsi.org/files/patches/rubygem-actionpack-2.3.5-rack-compat.patch

I'm guessing this is a same or similar problem for sinatra.

We don't need this for actionpack 2.3.8 (shipping in F14+) though as by 
default it works with rack 1.1.0 and the whole patch is moot. I haven't 
backported this patch to Fedora 13 yet though, it is on my list, but 
keeps getting bumped down in priority.

   -Mo

[Michal Fojtik]

On 13/09/10 11:12 -0400, Mohammed Morsi wrote:
>   On 09/13/2010 08:31 AM, Michal Fojtik wrote:
> > On 12/09/10 19:34 -0500, Michael Stahnke wrote:
> >> I'd like to bump rubygem-rack to the latest (1.2.1) in Rawhide and
> >> EPEL.  I was worried about EPEL and even started making a seperate
> >> branch for a rack1 package, but according to my queries, the only
> >> packages requiring rack in EPEL are:
> >>
> >>
> >>
> >> EPEL:
> >>
> >> stahnma@tyr /home/stahnma>  repoquery -q --whatrequires
> "rubygem(rack)"
> >> rubygem-sinatra-1:1.0-2.el5.noarch
> >> rubygem-shotgun-0:0.4-1.el5.noarch
> >>
> >>
> >>
> >> F13:
> >>
> >> stahnma@olive /home/stahnma>  repoquery --whatrequires
> "rubygem(rack)"
> >> rubygem-actionpack-1:2.3.5-1.fc13.noarch
> >> rubygem-actionpack-1:2.3.5-2.fc13.noarch
> >> rubygem-merb-core-0:1.0.15-1.fc13.noarch
> >> rubygem-shotgun-0:0.4-1.fc13.noarch
> >> rubygem-sinatra-1:0.9.4-2.fc12.noarch
> >> rubygem-sinatra-1:1.0-1.fc13.noarch
> >> rubygem-thin-0:1.2.5-5.fc13.i686
> > FYI: when I tried to use rack-1.2.1 with new Rack I got:
> > (same error for Rails 2.3.5)
> >
> > <snip>
> > /usr/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/utils.rb:138:in `union':
> can't convert Array into String (TypeError)
> >    from /usr/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/utils.rb:138
> > </snip>
> >
> > I'll contact Sinatra upstream to fix it.
> >
> >    -- Michal
> >
> I discovered and reported this issue (or at least a very similar one) a 
> little while back. Its not a upstream problem, rather a Fedora packaging 
> problem as we change actionpack 2.3.5 to be compatible with Rack 1.1.0
>
> https://bugzilla.redhat.com/show_bug.cgi?id=617803
>
> The problem is though we miss one important change which is causing this 
> error. My updated patch to actionpack fixes this
>
> http://mo.morsi.org/files/patches/rubygem-actionpack-2.3.5-rack-compat.patch
>
> I'm guessing this is a same or similar problem for sinatra. 
Well, after small investigation and chat with Sinatra folks I can confirm
that this is not Rack/Sinatra relevant bug, but Ruby 1.8.6 bug.

After I tried this gem with Ruby 1.8.7 installed through 'rvm', this
exception dissapears and all stuff is working normally now.

I hope we will have Ruby 1.8.7 soon ;-)

  -- Michal

-- 
--------------------------------------------------------
Michal Fojtik, mfojtik(a)redhat.com
Deltacloud API: http://deltacloud.org
--------------------------------------------------------

[Mo Morsi]

  On 09/13/2010 12:48 PM, Michal Fojtik wrote:
>  On 13/09/10 11:12 -0400, Mohammed Morsi wrote:
> >   On 09/13/2010 08:31 AM, Michal Fojtik wrote:
> >> On 12/09/10 19:34 -0500, Michael Stahnke wrote:
> >>> I'd like to bump rubygem-rack to the latest (1.2.1) in Rawhide and
> >>> EPEL.  I was worried about EPEL and even started making a seperate
> >>> branch for a rack1 package, but according to my queries, the only
> >>> packages requiring rack in EPEL are:
> >>>
> >>>
> >>>
> >>> EPEL:
> >>>
> >>> stahnma@tyr /home/stahnma>   repoquery -q --whatrequires
> "rubygem(rack)"
> >>> rubygem-sinatra-1:1.0-2.el5.noarch
> >>> rubygem-shotgun-0:0.4-1.el5.noarch
> >>>
> >>>
> >>>
> >>> F13:
> >>>
> >>> stahnma@olive /home/stahnma>   repoquery --whatrequires
> "rubygem(rack)"
> >>> rubygem-actionpack-1:2.3.5-1.fc13.noarch
> >>> rubygem-actionpack-1:2.3.5-2.fc13.noarch
> >>> rubygem-merb-core-0:1.0.15-1.fc13.noarch
> >>> rubygem-shotgun-0:0.4-1.fc13.noarch
> >>> rubygem-sinatra-1:0.9.4-2.fc12.noarch
> >>> rubygem-sinatra-1:1.0-1.fc13.noarch
> >>> rubygem-thin-0:1.2.5-5.fc13.i686
> >> FYI: when I tried to use rack-1.2.1 with new Rack I got:
> >> (same error for Rails 2.3.5)
> >>
> >> <snip>
> >> /usr/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/utils.rb:138:in `union':
> can't convert Array into String (TypeError)
> >>     from /usr/lib/ruby/gems/1.8/gems/rack-1.2.1/lib/rack/utils.rb:138
> >> </snip>
> >>
> >> I'll contact Sinatra upstream to fix it.
> >>
> >>     -- Michal
> >>
> > I discovered and reported this issue (or at least a very similar one) a
> > little while back. Its not a upstream problem, rather a Fedora packaging
> > problem as we change actionpack 2.3.5 to be compatible with Rack 1.1.0
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=617803
> >
> > The problem is though we miss one important change which is causing this
> > error. My updated patch to actionpack fixes this
> >
> > http://mo.morsi.org/files/patches/rubygem-actionpack-2.3.5-rack-compat.patch
> >
> > I'm guessing this is a same or similar problem for sinatra.
>  Well, after small investigation and chat with Sinatra folks I can confirm
>  that this is not Rack/Sinatra relevant bug, but Ruby 1.8.6 bug.
>
>  After I tried this gem with Ruby 1.8.7 installed through 'rvm', this
>  exception dissapears and all stuff is working normally now.
>
>  I hope we will have Ruby 1.8.7 soon ;-)
>
>     -- Michal
>  
Ruby 1.8.7 will be shipping with Fedora 14.

https://fedoraproject.org/wiki/Features/Ruby_1.8.7

   -Mo

[Michael Stahnke]

his is not Rack/Sinatra relevant bug, but Ruby 1.8.6 bug.
> >
> > After I tried this gem with Ruby 1.8.7 installed through 'rvm', this
> > exception dissapears and all stuff is working normally now.
> >
> > I hope we will have Ruby 1.8.7 soon ;-)
> > 
That rules out Rack-1.2 for EPEL5 and EPEL6, as ruby is still 1.8.6 in
those.  I really wish Red Hat would have moved up Ruby to 1.8.7 in
RHEL6, but they didn't.


Does rack-1.1 work for Sinatra currently?

[Mo Morsi]

  On 09/13/2010 01:16 PM, Michael Stahnke wrote:
>  his is not Rack/Sinatra relevant bug, but Ruby 1.8.6 bug.
> >> After I tried this gem with Ruby 1.8.7 installed through 'rvm', this
> >> exception dissapears and all stuff is working normally now.
> >>
> >> I hope we will have Ruby 1.8.7 soon ;-)
> >>
>  That rules out Rack-1.2 for EPEL5 and EPEL6, as ruby is still 1.8.6 in
>  those.  I really wish Red Hat would have moved up Ruby to 1.8.7 in
>  RHEL6, but they didn't.
>
>
>  Does rack-1.1 work for Sinatra currently?
>  _______________________________________________
>  ruby-sig mailing list
>  ruby-sig(a)lists.fedoraproject.org
>  https://admin.fedoraproject.org/mailman/listinfo/ruby-sig 
I had thought Ruby 1.8.7
was going to be pushed to RHEL 6, afterall I 
helped do a bunch of work on the RHEL package with Jim Meyering. CC'ing 
him here to address this question further.

Not sure on the rack / Sinatra compatibility bit.

   -Mo

[Jim Meyering]

Mohammed Morsi wrote:
>  I had thought Ruby 1.8.7 was going to be pushed to RHEL 6, afterall
> I
>  helped do a bunch of work on the RHEL package with Jim Meyering. CC'ing
>  him here to address this question further. 
Ruby 1.8.7 will indeed be in RHEL 6.0.
The beta release appears to contain both 1.8.6 and 1.8.7.

  1.8.7.299-3
  1.8.6.399-5.1

[Michael Stahnke]

On Mon, Sep 13, 2010 at 1:14 PM, Jim Meyering <jim(a)meyering.net&gt; wrote:
>  Mohammed Morsi wrote:
> > I had thought Ruby 1.8.7 was going to be pushed to RHEL 6, afterall I
> > helped do a bunch of work on the RHEL package with Jim Meyering. CC'ing
> > him here to address this question further.
>
>  Ruby 1.8.7 will indeed be in RHEL 6.0.
>  The beta release appears to contain both 1.8.6 and 1.8.7.
>
>   1.8.7.299-3
>   1.8.6.399-5.1
>  _______________________________________________
>  ruby-sig mailing list
>  ruby-sig(a)lists.fedoraproject.org
>  https://admin.fedoraproject.org/mailman/listinfo/ruby-sig
>  
That totally made my day.   I love being wrong sometimes!

[Michal Fojtik]

On 13/09/10 12:16 -0500, Michael Stahnke wrote:
> his is not Rack/Sinatra relevant bug, but Ruby 1.8.6 bug.
> >>
> >> After I tried this gem with Ruby 1.8.7 installed through 'rvm', this
> >> exception dissapears and all stuff is working normally now.
> >>
> >> I hope we will have Ruby 1.8.7 soon ;-)
> >>
> That rules out Rack-1.2 for EPEL5 and EPEL6, as ruby is still 1.8.6 in
> those.  I really wish Red Hat would have moved up Ruby to 1.8.7 in
> RHEL6, but they didn't.
>
>
> Does rack-1.1 work for Sinatra currently? 
Positive. Rack 1.1.0 is compatible with Sinatra under Ruby 1.8.6.

   -- Michal

-- 
--------------------------------------------------------
Michal Fojtik, mfojtik(a)redhat.com
Deltacloud API: http://deltacloud.org
--------------------------------------------------------