Ruby rawhide FTBFS

[Jun Aruga (he / him)]

Just a quick note.
Right now the rpms/ruby rawhide is FTBFS.[1]

```
  1) Failure:
TestGemSourceGit#test_checkout_submodules
[/builddir/build/BUILD/ruby-3.1.2/test/rubygems/test_gem_source_git.rb:72]:
fatal: transport 'file' not allowed
fatal: clone of
'/builddir/build/BUILD/ruby-3.1.2/tmp/test_rubygems_20221027-81957-35u31l/git/b'
into submodule path
'/builddir/build/BUILD/ruby-3.1.2/tmp/test_rubygems_20221027-81957-35u31l/git/a/b'
failed
Finished tests in 975.746481s, 21.9330 tests/s, 2819.2661 assertions/s.
21401 tests, 2750889 assertions, 1 failures, 0 errors, 55 skips
```

The reason is the [2]. The git-core 2.38.1-1.fc38 is used as a
dependency on the rawhide now.
This failure happens on Git >= 2.38.1. This failure doesn't happen on
Git 2.28.0.[3]

The patch is [4][5]. I confirmed it passed the tests on the
private-ruby-3.2 branch.

As I will work for Fedora again next Wednesday, feel free to take and
apply the patch to the rawhide branch and backport.

[1] https://koji.fedoraproject.org/koji/taskinfo?taskID=93491139
[2] https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2...
[3] https://twitter.com/hsbt/status/1582565364700893184 (Japanese)
[4] https://github.com/rubygems/rubygems/commit/e29c79d1891a656ec50c8bd4ff6d8b11...
[5] https://github.com/ruby/ruby/commit/dae843f6b7502f921a7e66f39e3714a39d860181

[Vít Ondruch]

Good catch.

Not surprisingly, RubyGems fail as well 🫤

https://koschei.fedoraproject.org/package/rubygems?collection=f38

And looking at git updates, I'd be not surprised if also older Fedoras 
get broken soon:

https://bodhi.fedoraproject.org/updates/?packages=git

Vít

Dne 27. 10. 22 v 20:37 Jun Aruga (he / him) napsal(a):
> Just a quick note.
> Right now the rpms/ruby rawhide is FTBFS.[1]
>    1) Failure:
> TestGemSourceGit#test_checkout_submodules
> [/builddir/build/BUILD/ruby-3.1.2/test/rubygems/test_gem_source_git.rb:72]:
> fatal: transport 'file' not allowed
> fatal: clone of
> '/builddir/build/BUILD/ruby-3.1.2/tmp/test_rubygems_20221027-81957-35u31l/git/b'
> into submodule path
> '/builddir/build/BUILD/ruby-3.1.2/tmp/test_rubygems_20221027-81957-35u31l/git/a/b'
> failed
> Finished tests in 975.746481s, 21.9330 tests/s, 2819.2661 assertions/s.
> 21401 tests, 2750889 assertions, 1 failures, 0 errors, 55 skips
>
> The reason is the [2]. The git-core 2.38.1-1.fc38 is used as a
> dependency on the rawhide now.
> This failure happens on Git >= 2.38.1. This failure doesn't happen on
> Git 2.28.0.[3]
>
> The patch is [4][5]. I confirmed it passed the tests on the
> private-ruby-3.2 branch.
>
> As I will work for Fedora again next Wednesday, feel free to take and
> apply the patch to the rawhide branch and backport.
>
> [1] https://koji.fedoraproject.org/koji/taskinfo?taskID=93491139
> [2] https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2...
> [3] https://twitter.com/hsbt/status/1582565364700893184 (Japanese)
> [4] https://github.com/rubygems/rubygems/commit/e29c79d1891a656ec50c8bd4ff6d8b11...
> [5] https://github.com/ruby/ruby/commit/dae843f6b7502f921a7e66f39e3714a39d860181

[Jun Aruga (he / him)]

On Mon, Oct 31, 2022 at 6:54 PM Vít Ondruch  wrote:
> Good catch.

Here is the PR to the rpms/ruby rawhide.
https://src.fedoraproject.org/rpms/ruby/pull-request/135#
> Not surprisingly, RubyGems fail as well 🫤
>
> https://koschei.fedoraproject.org/package/rubygems?collection=f38

Okay, the rpms/rubygems is next after the rpms/ruby.
> And looking at git updates, I'd be not surprised if also older Fedoras
> get broken soon:
>
> https://bodhi.fedoraproject.org/updates/?packages=git

The git 2.38.1 is on f37, f36 and f35 too.
Maybe it's better to push this PR commit to these fedoras too after
merging the rawhide PR.

[Vít Ondruch]

Dne 02. 11. 22 v 20:38 Jun Aruga (he / him) napsal(a):
> On Mon, Oct 31, 2022 at 6:54 PM Vít Ondruch  wrote:
> > Good catch.
>
> Here is the PR to the rpms/ruby rawhide.
> https://src.fedoraproject.org/rpms/ruby/pull-request/135#
> > Not surprisingly, RubyGems fail as well 🫤
> >
> > https://koschei.fedoraproject.org/package/rubygems?collection=f38
>
> Okay, the rpms/rubygems is next after the rpms/ruby.

Thx
> > And looking at git updates, I'd be not surprised if also older Fedoras
> > get broken soon:
> >
> > https://bodhi.fedoraproject.org/updates/?packages=git
>
> The git 2.38.1 is on f37, f36 and f35 too.
> Maybe it's better to push this PR commit to these fedoras too after
> merging the rawhide PR.

Right, I have mentioned this in the PR but you are apparently on top of 
it. Great!

BTW if you have a spare cycles, please review the Rawhide changes which 
were committed after the F37 was branched. I guess they could be 
included into F37, but I have not checked (particularly the enabled 
package notes, not sure if the changes landed in F37, but my guess is 
that they have landed there). Thx

Vít

[Jun Aruga (he / him)]

> > > https://bodhi.fedoraproject.org/updates/?packages=git
> >
> > The git 2.38.1 is on f37, f36 and f35 too.
> > Maybe it's better to push this PR commit to these fedoras too after
> > merging the rawhide PR.
>
> Right, I have mentioned this in the PR but you are apparently on top of
> it. Great!

OK. I will fix this issue and build on the old Fedoras too.
> BTW if you have a spare cycles, please review the Rawhide changes which
> were committed after the F37 was branched. I guess they could be
> included into F37, but I have not checked (particularly the enabled
> package notes, not sure if the changes landed in F37, but my guess is
> that they have landed there). Thx

It seems that the rawhide specific change below should work on Fedora
37 (and 36) too. I will backport the commit to the f37 too.
https://src.fedoraproject.org/rpms/ruby/c/588a4ae9f02928d7bedbcf46a739d36b0a...

The issue comes from the redhat-rpm-config and it was fixed in
redhat-rpm-config-210-1 fc36, fc37, fc38 (rawhide).
https://bugzilla.redhat.com/show_bug.cgi?id=2043092#c66

So, I will test by building the rubygem-nio4r package on the built
Ruby just in case. This is a step to verify the issue that you
reported on the Bugzilla ticket.

[Jun Aruga (he / him)]

> > Not surprisingly, RubyGems fail as well 🫤
> >
> > https://koschei.fedoraproject.org/package/rubygems?collection=f38
>
> Okay, the rpms/rubygems is next after the rpms/ruby.

Here is the PR. Someone, please review.
https://src.fedoraproject.org/rpms/rubygems/pull-request/4

[Jun Aruga (he / him)]

> Here is the PR. Someone, please review.
> https://src.fedoraproject.org/rpms/rubygems/pull-request/4

Here is the status. Review please. Thanks.

rpms/ruby
* rawhide: done (built)
* f37: https://src.fedoraproject.org/rpms/ruby/pull-request/136
* f36: https://src.fedoraproject.org/rpms/ruby/pull-request/137
* f35: https://src.fedoraproject.org/rpms/ruby/pull-request/138

rpms/rubygems
* rawhide: https://src.fedoraproject.org/rpms/rubygems/pull-request/4
(in review)

rpms/rubygem-bundler
* rawhide: https://src.fedoraproject.org/rpms/rubygem-bundler/pull-request/6
  The rubygem-bundler PR should be merged and built before the
rpms/rubygems because rubygems depends on the latest version of the
rubygem-bundler.

[Jun Aruga (he / him)]

On Thu, Nov 3, 2022 at 8:06 PM Jun Aruga (he / him)  wrote:
> > Here is the PR. Someone, please review.
> > https://src.fedoraproject.org/rpms/rubygems/pull-request/4
>
> Here is the status. Review please. Thanks.

I was able to build the all the rpms/ruby and rubygems and
rubygem-bundler. Thanks for your help.
Just note I didn't submit the rpms/ruby build on f37, f36, f35 to the
Bodhi, as it is just to fix the FTBFS.
> rpms/ruby
> rawhide: done (built)
> f37: https://src.fedoraproject.org/rpms/ruby/pull-request/136
> f36: https://src.fedoraproject.org/rpms/ruby/pull-request/137
> f35: https://src.fedoraproject.org/rpms/ruby/pull-request/138

https://koji.fedoraproject.org/koji/packageinfo?packageID=125
> rpms/rubygems
> rawhide: https://src.fedoraproject.org/rpms/rubygems/pull-request/4
>
> (in review)
>
> rpms/rubygem-bundler
> rawhide: https://src.fedoraproject.org/rpms/rubygem-bundler/pull-request/6
> The rubygem-bundler PR should be merged and built before the
>
> rpms/rubygems because rubygems depends on the latest version of the
> rubygem-bundler.

The Koschei has not worked for ruby rawhide since around 1 month ago,
but after reporting to the Koschei project, it started to work again.
https://github.com/fedora-infra/koschei/issues/349
https://koschei.fedoraproject.org/package/ruby

[Vít Ondruch]

Dne 04. 11. 22 v 18:55 Jun Aruga (he / him) napsal(a):
> On Thu, Nov 3, 2022 at 8:06 PM Jun Aruga (he / him)  wrote:
> > > Here is the PR. Someone, please review.
> > > https://src.fedoraproject.org/rpms/rubygems/pull-request/4
> >
> > Here is the status. Review please. Thanks.
>
> I was able to build the all the rpms/ruby and rubygems and
> rubygem-bundler. Thanks for your help.
> Just note I didn't submit the rpms/ruby build on f37, f36, f35 to the
> Bodhi, as it is just to fix the FTBFS.

I am afraid that Koschei will not pick up the builds without submitting 
updates unfortunately.

Vít
> > rpms/ruby
> > rawhide: done (built)
> > f37: https://src.fedoraproject.org/rpms/ruby/pull-request/136
> > f36: https://src.fedoraproject.org/rpms/ruby/pull-request/137
> > f35: https://src.fedoraproject.org/rpms/ruby/pull-request/138
>
> https://koji.fedoraproject.org/koji/packageinfo?packageID=125
> > rpms/rubygems
> > rawhide: https://src.fedoraproject.org/rpms/rubygems/pull-request/4
> >
> > (in review)
> >
> > rpms/rubygem-bundler
> > rawhide: https://src.fedoraproject.org/rpms/rubygem-bundler/pull-request/6
> >  The rubygem-bundler PR should be merged and built before the
> >
> > rpms/rubygems because rubygems depends on the latest version of the
> > rubygem-bundler.
>
> The Koschei has not worked for ruby rawhide since around 1 month ago,
> but after reporting to the Koschei project, it started to work again.
> https://github.com/fedora-infra/koschei/issues/349
> https://koschei.fedoraproject.org/package/ruby

[Jun Aruga (he / him)]

> I am afraid that Koschei will not pick up the builds without submitting
> updates unfortunately.

Here is a document and an upstream ticket that I am asking. But there
are priorities to be picked up or to be started.
https://fedoraproject.org/wiki/Koschei#Priorities
https://github.com/fedora-infra/koschei/issues/349