Hello, all:
With wonderful work by Vít and friends, again I tried to rebuild all rubygem-foo packages on Fedora against ruby 3.3.0dev.
For the below failure reports, https://github.com/ruby/ruby/commit/83ecdd1dce18246de631eb3b5d8308145bb269f5 is used.
Among ~455 packages, now 16 packages see build failure. Please check what is going, thank you.
Regards, Mamoru
1. rubygem-actionview https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
``` Failure: RipperTrackerTest#test_finds_dependencies_with_extra_spaces [test/template/dependency_tracker_test.rb:191]: --- expected +++ actual @@ -1 +1 @@ -["spaces/header", "spaces/form", "messages/message", "events/event", "comments/comment"] +["spaces/header", "spaces/form", "messages/message", "comments/comment"] ```
Discussed on: https://src.fedoraproject.org/rpms/rubygem-actionview/pull-request/4
2. rubygem-addressable https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Test suite segfaults constantly...
3. rubygem-aruba https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Cucumber testsuite fails. Some test failures are due to removed irb/ext/save-history, some are due to pry behaving badly? on ruby3.3 (not knowing in details), others I don't know. Already reported https://github.com/cucumber/aruba/issues/910 , no response.
4. rubygem-async_sinatra https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... `test/test_async.rb:28:in `<main>': uninitialized constant MiniTest (NameError)` Fixing this will perhaps be easy, leaving this to maintainer for now.
5. rubygem-bootsnap https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... ``` 1) Failure: Bootsnap::KernelRequireTest#test_uses_the_same_duck_type_as_require [/builddir/build/BUILD/bootsnap-1.15.0/usr/share/gems/gems/bootsnap-1.15.0/test/load_path_cache/core_ext/kernel_require_test.rb:26]: Expected #<Process::Status: pid 1413 exit 1> to be success?. ``` I don't know what this means. With ruby 7b8d472100 (around 2023-10-06) test was successful, but with ruby 55c5ebe0a0 (around 2023-10-14) test test fails, not sure what ruby change caused this.
6. rubygem-byebug https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... As discussed before, I don't expect that rubygem-byebug comes to work with ruby3.3. Probably I am going to orphan this.
7. rubygem-childprocess https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... `Failure/Error: require 'rubygems/mock_gem_ui'` This file is removed: https://github.com/ruby/ruby/commit/74772840430fc3fca3f5fb0ad585d9cc48f512fb Need to address in childprocess side.
8. rubygem-clockwork https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... `internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in `require': cannot load such file -- mocha/setup (LoadError)` This mocha issue is already fixed in https://github.com/Rykian/clockwork/pull/64/ . Looks like in addition Minitest issue needs fixing.
9. rubygem-curb https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... ``` Error: test_curlopt_stderr_with_file(TestCurbCurlEasy): Errno::ENOENT: No such file or directory @ rb_sysopen - /tmp/curb_test_curlopt_stderr20231028-3388-1r4xk0 /builddir/build/BUILD/curb-1.0.1/usr/share/gems/gems/curb-1.0.1/tests/tc_curl_easy.rb:30:in `read' /builddir/build/BUILD/curb-1.0.1/usr/share/gems/gems/curb-1.0.1/tests/tc_curl_easy.rb:30:in `test_curlopt_stderr_with_file' ``` Well, successful on x86_64, failing on s390x. But even on s390x this was successful with ruby 7b8d472100 (around 2023-10-06), seeing failure with ruby 55c5ebe0a0 (around 20231014).
10. rubygem-power_assert https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... %check needs BR: rubygem-byebug , which doesn't build. Discussed on: https://github.com/ruby/power_assert/issues/47 , I may try to remove byebug dependency myself.
11. rubygem-puppet-lint https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... ``` No matching package to install: 'rubygem(rspec-collection_matchers) >= 1.0' ``` The above package is already retired.
12. rubygem-railties https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... ``` Failure: ApplicationTests::AssetsTest#test_precompile_shouldn't_use_the_digests_present_in_manifest.json [test/application/assets_test.rb:299]: Expected "application-c56ef81d122dffa8b257b0546ba1b09bd2d8b97e4aef881de8db9f760b903af6.css" to not be equal to "application-c56ef81d122dffa8b257b0546ba1b09bd2d8b97e4aef881de8db9f760b903af6.css". ``` Not sure what this means.
13. rubygem-ronn-ng https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... ``` Failure: test_angle_bracket_syntax_HTML(RonnTest): --- /builddir/build/BUILD/ronn-ng-0.9.1/usr/share/gems/gems/ronn-ng-0.9.1/test/angle_bracket_syntax.html 2023-10-28 15:58:23.177074626 +0000 +++ /builddir/build/BUILD/ronn-ng-0.9.1/usr/share/gems/gems/ronn-ng-0.9.1/test/angle_bracket_syntax.html.wrong 2023-10-28 15:58:25.675101802 +0000 @@ -13,5 +13,5 @@
<p>or when <code><WORD></code> is enclosed in backticks.</p>
-<p>or when <var>WORD</var> has a <dot.> or <colon>.</colon></dot.></p> +<p>or when <var>WORD</var> has a <dot.> or foo:colon.</foo:colon></dot.></p> </div> . ``` libxml2 2.11.5 compatibitily issue, discussed on https://github.com/apjanke/ronn-ng/issues/102 . I think it is enough just to fix test suite as it is.
14. rubygem-shoulda-matchers https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Lots of: ``` An error occurred while loading ./spec/unit/shoulda/matchers/action_controller/callback_matcher_spec.rb. Failure/Error: require 'unit_spec_helper'
NoMethodError: undefined method `tr' for an instance of Pathname ``` Not sure what this means.
15. rubygem-stringex https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Also for this one, test suite segfaults constantly...
16. rubygem-yard https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Many messages like: ``` 1) YARD::Handlers::Ruby::YieldHandler only parses yield blocks in methods Failure/Error: raise ProxyMethodError, "Proxy cannot call method ##{meth} on object '#{path}'" ``` Discussed on https://github.com/lsegal/yard/issues/1514 : Most probably this is caused by https://github.com/ruby/ruby/commit/b5e23d3e3b5ff2f5328aa43a2392ebe7c951a222 ruby 3.3.0 now adds more checks for "yield" usage, not knowing how to fix on yard side myself.
Nice, thx for the summary and a few remarks inline.
Dne 29. 10. 23 v 9:09 Mamoru TASAKA napsal(a):
rubygem-addressable https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Test suite segfaults constantly...
Isn't this some RegExp / GC thing seeint this part of backtrace:
~~~
/lib64/libruby.so.3.3(rb_st_foreach+0x85) [0x7f2fc3b24285] /lib64/libruby.so.3.3(onig_names_free+0x27) [0x7f2fc3b10807] /lib64/libruby.so.3.3(onig_free+0x1a) [0x7f2fc3b035fa] /lib64/libruby.so.3.3(0x7f2fc3a24022) [0x7f2fc3a24022] /lib64/libruby.so.3.3(0x7f2fc3c1e048) [0x7f2fc3c1e048] /lib64/libruby.so.3.3(0x7f2fc3a21f23) [0x7f2fc3a21f23] /lib64/libruby.so.3.3(0x7f2fc3a2a39b) [0x7f2fc3a2a39b] /lib64/libruby.so.3.3(0x7f2fc3a2a7be) [0x7f2fc3a2a7be] /lib64/libruby.so.3.3(rb_wb_protected_newobj_of+0x74) [0x7f2fc3a2b0a4]
~~~
rubygem-bootsnap https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
1) Failure: Bootsnap::KernelRequireTest#test_uses_the_same_duck_type_as_require [/builddir/build/BUILD/bootsnap-1.15.0/usr/share/gems/gems/bootsnap-1.15.0/test/load_path_cache/core_ext/kernel_require_test.rb:26]: Expected #<Process::Status: pid 1413 exit 1> to be success?.
I don't know what this means. With ruby 7b8d472100 (around 2023-10-06) test was successful, but with ruby 55c5ebe0a0 (around 2023-10-14) test test fails, not sure what ruby change caused this.
Looking at the test case, wouldn't it be enough to remove the `fork` [1] to get more information? Of course it would fail the rest of test suite ....
[1] https://github.com/Shopify/bootsnap/blob/c78981903d958ceacdaec843b9832addf87...
rubygem-childprocess https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
`Failure/Error: require 'rubygems/mock_gem_ui'` This file is removed: https://github.com/ruby/ruby/commit/74772840430fc3fca3f5fb0ad585d9cc48f512fb Need to address in childprocess side.
Seems to be just one test case:
https://github.com/enkessler/childprocess/blob/44227922488765ebad0c0bed0fbec...
We could skip the test temporary.
rubygem-clockwork https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
`internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in `require': cannot load such file -- mocha/setup (LoadError)` This mocha issue is already fixed in https://github.com/Rykian/clockwork/pull/64/ . Looks like in addition Minitest issue needs fixing.
And leaf package. I am fine breaking and have it removed afterwards, unless @Pavel Valena cares ...
Vít
Vít Ondruch wrote on 2023/10/30 19:37:
Nice, thx for the summary and a few remarks inline.
Dne 29. 10. 23 v 9:09 Mamoru TASAKA napsal(a):
rubygem-addressable https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Test suite segfaults constantly...
Isn't this some RegExp / GC thing seeint this part of backtrace:
/lib64/libruby.so.3.3(rb_st_foreach+0x85) [0x7f2fc3b24285] /lib64/libruby.so.3.3(onig_names_free+0x27) [0x7f2fc3b10807] /lib64/libruby.so.3.3(onig_free+0x1a) [0x7f2fc3b035fa] /lib64/libruby.so.3.3(0x7f2fc3a24022) [0x7f2fc3a24022] /lib64/libruby.so.3.3(0x7f2fc3c1e048) [0x7f2fc3c1e048] /lib64/libruby.so.3.3(0x7f2fc3a21f23) [0x7f2fc3a21f23] /lib64/libruby.so.3.3(0x7f2fc3a2a39b) [0x7f2fc3a2a39b] /lib64/libruby.so.3.3(0x7f2fc3a2a7be) [0x7f2fc3a2a7be] /lib64/libruby.so.3.3(rb_wb_protected_newobj_of+0x74) [0x7f2fc3a2b0a4]
Actually as you said this turned out to be GC issue on ruby regexp and is fixed with:
https://github.com/ruby/ruby/pull/8813 https://bugs.ruby-lang.org/issues/19992
Now with f694bd158c rubygem-addressable test suite passes and builds successfully.
Mamoru
Dne 08. 11. 23 v 16:13 Mamoru TASAKA napsal(a):
Vít Ondruch wrote on 2023/10/30 19:37:
Nice, thx for the summary and a few remarks inline.
Dne 29. 10. 23 v 9:09 Mamoru TASAKA napsal(a):
rubygem-addressable https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Test suite segfaults constantly...
Isn't this some RegExp / GC thing seeint this part of backtrace:
/lib64/libruby.so.3.3(rb_st_foreach+0x85) [0x7f2fc3b24285] /lib64/libruby.so.3.3(onig_names_free+0x27) [0x7f2fc3b10807] /lib64/libruby.so.3.3(onig_free+0x1a) [0x7f2fc3b035fa] /lib64/libruby.so.3.3(0x7f2fc3a24022) [0x7f2fc3a24022] /lib64/libruby.so.3.3(0x7f2fc3c1e048) [0x7f2fc3c1e048] /lib64/libruby.so.3.3(0x7f2fc3a21f23) [0x7f2fc3a21f23] /lib64/libruby.so.3.3(0x7f2fc3a2a39b) [0x7f2fc3a2a39b] /lib64/libruby.so.3.3(0x7f2fc3a2a7be) [0x7f2fc3a2a7be] /lib64/libruby.so.3.3(rb_wb_protected_newobj_of+0x74) [0x7f2fc3a2b0a4]
Actually as you said this turned out to be GC issue on ruby regexp and is fixed with:
https://github.com/ruby/ruby/pull/8813 https://bugs.ruby-lang.org/issues/19992
Now with f694bd158c rubygem-addressable test suite passes and builds successfully.
Very nice. Thx a lot. I have just pushed out changes for ad3db6711c, so that should also include this fix.
Vít
Dne 29. 10. 23 v 9:09 Mamoru TASAKA napsal(a):
rubygem-shoulda-matchers https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Lots of:
An error occurred while loading ./spec/unit/shoulda/matchers/action_controller/callback_matcher_spec.rb. Failure/Error: require 'unit_spec_helper' NoMethodError: undefined method `tr' for an instance of Pathname
Not sure what this means.
This could be workaround:
~~~
$ git diff diff --git a/spec/support/unit/rails_application.rb b/spec/support/unit/rails_application.rb index b55b12ce..3d5609a1 100644 --- a/spec/support/unit/rails_application.rb +++ b/spec/support/unit/rails_application.rb @@ -184,7 +184,7 @@ end end
def load_environment - require environment_file_path + require environment_file_path.to_s end
def run_migrations ~~~
IOW it seems like there used to be conversion from Pathname to String somewhere, but it is not anymore.
Vít
Vít Ondruch wrote on 2023/10/30 20:43:
Dne 29. 10. 23 v 9:09 Mamoru TASAKA napsal(a):
rubygem-shoulda-matchers https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Lots of:
An error occurred while loading ./spec/unit/shoulda/matchers/action_controller/callback_matcher_spec.rb. Failure/Error: require 'unit_spec_helper' NoMethodError: undefined method `tr' for an instance of Pathname
Not sure what this means.
This could be workaround:
$ git diff diff --git a/spec/support/unit/rails_application.rb b/spec/support/unit/rails_application.rb index b55b12ce..3d5609a1 100644 --- a/spec/support/unit/rails_application.rb +++ b/spec/support/unit/rails_application.rb @@ -184,7 +184,7 @@ end end def load_environment - require environment_file_path + require environment_file_path.to_s end def run_migrations
IOW it seems like there used to be conversion from Pathname to String somewhere, but it is not anymore.
Vít
Thank you. After looking at your comment above, it seems that it is indended that "require" (in bundler) supports Pathname, once it is modified so:
https://github.com/rubygems/rubygems/pull/6837
This says "**Restore** support for Pathname objects in the replaced require" , so it used to support Pathname, but it got broken at some time, then modified again at this time.
But looks like this got broken again by this commit: https://github.com/rubygems/rubygems/pull/7056
So may this this is wanted, but I am not sure.
``` diff --git a/lib/bundler/rubygems_integration.rb b/lib/bundler/rubygems_integration.rb index f420934ceb..59d32e68f3 100644 --- a/lib/bundler/rubygems_integration.rb +++ b/lib/bundler/rubygems_integration.rb @@ -244,6 +244,7 @@ def replace_require(specs) [::Kernel.singleton_class, ::Kernel].each do |kernel_class| kernel_class.send(:alias_method, :no_warning_require, :require) kernel_class.send(:define_method, :require) do |name| + name = File.path(name) if message = ::Gem::BUNDLED_GEMS.warning?(name, specs: specs) # rubocop:disable Style/HashSyntax warn message, :uplevel => 1 end ```
Mamoru TASAKA wrote on 2023/10/29 17:09:
Hello, all:
With wonderful work by Vít and friends, again I tried to rebuild all rubygem-foo packages on Fedora against ruby 3.3.0dev.
For the below failure reports, https://github.com/ruby/ruby/commit/83ecdd1dce18246de631eb3b5d8308145bb269f5 is used.
Among ~455 packages, now 16 packages see build failure. Please check what is going, thank you.
Regards, Mamoru
rubygem-byebug https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... As discussed before, I don't expect that rubygem-byebug comes to work with ruby3.3. Probably I am going to orphan this.
rubygem-childprocess https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... `Failure/Error: require 'rubygems/mock_gem_ui'` This file is removed: https://github.com/ruby/ruby/commit/74772840430fc3fca3f5fb0ad585d9cc48f512fb Need to address in childprocess side.
rubygem-power_assert https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... %check needs BR: rubygem-byebug , which doesn't build. Discussed on: https://github.com/ruby/power_assert/issues/47 , I may try to remove byebug dependency myself.
Looking closely, it turned out that rubygem-power_assert does not strictly need rubygem-byebug: In both runtime and %check, power_assert tries to load byebug and if LoadError happens, it is just rescued and procedure continues.
So I've now orphaned rubygem-byebug. Unless no one takes, it will be retired after 6 weeks or so. The packages which depends on rubygem-byebug (for Requires or BuildRequires) seems rubygem-pry-byebug only (maintainer CCed), which will become FTI and will be retired for Fedora 40 unless someone takes rubygem-byebug.
Regards, Mamoru
Hello again, all:
Now with again I tried to rebuild all rubygem-foo pacakages on Fedora with ruby 3.3.0dev:
The packages failing to build with: https://github.com/ruby/ruby/commit/9cd086ba4b559153864ab924723a665a4ddfb5d8 are listed below. (Commented inline between my previous post.)
8 packages are still failing to build.
Mamoru TASAKA wrote on 2023/10/29 17:09:
Hello, all:
With wonderful work by Vít and friends, again I tried to rebuild all rubygem-foo packages on Fedora against ruby 3.3.0dev.
For the below failure reports, https://github.com/ruby/ruby/commit/83ecdd1dce18246de631eb3b5d8308145bb269f5 is used.
Among ~455 packages, now 16 packages see build failure. Please check what is going, thank you.
Regards, Mamoru
1. rubygem-actionview https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Same as before.
rubygem-actionview https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Failure: RipperTrackerTest#test_finds_dependencies_with_extra_spaces [test/template/dependency_tracker_test.rb:191]: --- expected +++ actual @@ -1 +1 @@ -["spaces/header", "spaces/form", "messages/message", "events/event", "comments/comment"] +["spaces/header", "spaces/form", "messages/message", "comments/comment"]
Discussed on: https://src.fedoraproject.org/rpms/rubygem-actionview/pull-request/4
rubygem-addressable is FIXED: as reported before, this is fixed with https://github.com/ruby/ruby/pull/8813 https://bugs.ruby-lang.org/issues/19992
rubygem-addressable https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Test suite segfaults constantly...
2. rubygem-aruba https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Same as before.
rubygem-aruba https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Cucumber testsuite fails. Some test failures are due to removed irb/ext/save-history, some are due to pry behaving badly? on ruby3.3 (not knowing in details), others I don't know. Already reported https://github.com/cucumber/aruba/issues/910 , no response.
3. rubygem-async_sinatra https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Same as before.
rubygem-async_sinatra https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... `test/test_async.rb:28:in `<main>': uninitialized constant MiniTest (NameError)` Fixing this will perhaps be easy, leaving this to maintainer for now.
rubygem-bootsnap is FIXED: https://github.com/Shopify/bootsnap/pull/460
rubygem-bootsnap https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
1) Failure: Bootsnap::KernelRequireTest#test_uses_the_same_duck_type_as_require [/builddir/build/BUILD/bootsnap-1.15.0/usr/share/gems/gems/bootsnap-1.15.0/test/load_path_cache/core_ext/kernel_require_test.rb:26]: Expected #<Process::Status: pid 1413 exit 1> to be success?.
I don't know what this means. With ruby 7b8d472100 (around 2023-10-06) test was successful, but with ruby 55c5ebe0a0 (around 2023-10-14) test test fails, not sure what ruby change caused this.
4. rubygem-byebug https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Same as before.
Note that as I posted before, I've already orphaned rubygem-byebug. It seems rubygem-pry-byebug only depends on rubygem-byebug.
rubygem-byebug https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... As discussed before, I don't expect that rubygem-byebug comes to work with ruby3.3. Probably I am going to orphan this.
5. rubygem-childprocess https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Same as before.
rubygem-childprocess https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... `Failure/Error: require 'rubygems/mock_gem_ui'` This file is removed: https://github.com/ruby/ruby/commit/74772840430fc3fca3f5fb0ad585d9cc48f512fb Need to address in childprocess side.
6. NEW: rubygem-liquid https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... ``` 1) Failure: StandardFiltersTest#test_sort_when_property_is_sometimes_missing_puts_nils_last [/builddir/build/BUILD/liquid-4.0.3/usr/share/gems/gems/liquid-4.0.3/test/integration/standard_filter_test.rb:220]: --- expected +++ actual @@ -1 +1 @@ -[{"price"=>1, "handle"=>"gamma"}, {"price"=>2, "handle"=>"epsilon"}, {"price"=>4, "handle"=>"alpha"}, {"handle"=>"delta"}, {"handle"=>"beta"}] +[{"price"=>1, "handle"=>"gamma"}, {"price"=>2, "handle"=>"epsilon"}, {"price"=>4, "handle"=>"alpha"}, {"handle"=>"beta"}, {"handle"=>"delta"}]
2) Failure: StandardFiltersTest#test_sort_natural_when_property_is_sometimes_missing_puts_nils_last [/builddir/build/BUILD/liquid-4.0.3/usr/share/gems/gems/liquid-4.0.3/test/integration/standard_filter_test.rb:248]: --- expected +++ actual @@ -1 +1 @@ -[{"price"=>"1", "handle"=>"gamma"}, {"price"=>2, "handle"=>"epsilon"}, {"price"=>"4", "handle"=>"alpha"}, {"handle"=>"delta"}, {"handle"=>"beta"}] +[{"price"=>"1", "handle"=>"gamma"}, {"price"=>2, "handle"=>"epsilon"}, {"price"=>"4", "handle"=>"alpha"}, {"handle"=>"beta"}, {"handle"=>"delta"}] ```
Actually rawhide also began to fail: https://koschei.fedoraproject.org/package/rubygem-liquid
This is glibc-2.38.9000-20.fc40 qsort behavior change: I posted the issue and proposal on: https://github.com/Shopify/liquid/issues/1759 https://github.com/Shopify/liquid/pull/1760
rubygem-clockwork is FIXED: with backporting upstream PR for mocha and Minitest issue.
rubygem-clockwork https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... `internal:/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in `require': cannot load such file -- mocha/setup (LoadError)` This mocha issue is already fixed in https://github.com/Rykian/clockwork/pull/64/ . Looks like in addition Minitest issue needs fixing.
rubygem-curb SEEMS FIXED, actually I am not sure what packages' changes fixed this...
rubygem-curb https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Error: test_curlopt_stderr_with_file(TestCurbCurlEasy): Errno::ENOENT: No such file or directory @ rb_sysopen - /tmp/curb_test_curlopt_stderr20231028-3388-1r4xk0 /builddir/build/BUILD/curb-1.0.1/usr/share/gems/gems/curb-1.0.1/tests/tc_curl_easy.rb:30:in `read' /builddir/build/BUILD/curb-1.0.1/usr/share/gems/gems/curb-1.0.1/tests/tc_curl_easy.rb:30:in `test_curlopt_stderr_with_file'
Well, successful on x86_64, failing on s390x. But even on s390x this was successful with ruby 7b8d472100 (around 2023-10-06), seeing failure with ruby 55c5ebe0a0 (around 20231014).
rubygem-power_assert is FIXED: As I posted before, rubygem-byebug BR was actually unneeded, so I've removed that dependency.
rubygem-power_assert https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... %check needs BR: rubygem-byebug , which doesn't build. Discussed on: https://github.com/ruby/power_assert/issues/47 , I may try to remove byebug dependency myself.
rubygem-puppet-lint is FIXED: puppet-lint is upgraded to 4.2.1, and rubygem(rspec-collection_matchers) BR is removed.
rubygem-puppet-lint https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
No matching package to install: 'rubygem(rspec-collection_matchers) >= 1.0'
The above package is already retired.
7. rubygem-railties https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Testsuite is failing, but due to some different reason:
``` Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got:
Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
rails test test/application/console_test.rb:139
F
Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got:
Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". ```
rubygem-railties https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Failure: ApplicationTests::AssetsTest#test_precompile_shouldn't_use_the_digests_present_in_manifest.json [test/application/assets_test.rb:299]: Expected "application-c56ef81d122dffa8b257b0546ba1b09bd2d8b97e4aef881de8db9f760b903af6.css" to not be equal to "application-c56ef81d122dffa8b257b0546ba1b09bd2d8b97e4aef881de8db9f760b903af6.css".
Not sure what this means.
8. rubygem-ronn-ng https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/pac... Same as before.
rubygem-ronn-ng https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Failure: test_angle_bracket_syntax_HTML(RonnTest): --- /builddir/build/BUILD/ronn-ng-0.9.1/usr/share/gems/gems/ronn-ng-0.9.1/test/angle_bracket_syntax.html 2023-10-28 15:58:23.177074626 +0000 +++ /builddir/build/BUILD/ronn-ng-0.9.1/usr/share/gems/gems/ronn-ng-0.9.1/test/angle_bracket_syntax.html.wrong 2023-10-28 15:58:25.675101802 +0000 @@ -13,5 +13,5 @@ <p>or when <code><WORD></code> is enclosed in backticks.</p> -<p>or when <var>WORD</var> has a <dot.> or <colon>.</colon></dot.></p> +<p>or when <var>WORD</var> has a <dot.> or <foo:colon>.</foo:colon></dot.></p> </div> .
libxml2 2.11.5 compatibitily issue, discussed on https://github.com/apjanke/ronn-ng/issues/102 . I think it is enough just to fix test suite as it is.
rubygem-shoulda-matchers is FIXED: With some discussion, this is fixed on ruby side: https://github.com/ruby/ruby/commit/e34e8b93f8fac3ef40ab5ed8672fa003f3b4d9c0 ref: https://github.com/rubygems/rubygems/pull/7128
rubygem-shoulda-matchers https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Lots of:
An error occurred while loading ./spec/unit/shoulda/matchers/action_controller/callback_matcher_spec.rb. Failure/Error: require 'unit_spec_helper' NoMethodError: undefined method `tr' for an instance of Pathname
Not sure what this means.
rubygem-stringex is FIXED: Actually the segfault on the testsuite was identified as ruby side bug, and was fixed in:
https://github.com/ruby/ruby/pull/8899 https://bugs.ruby-lang.org/issues/19994
rubygem-stringex https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Also for this one, test suite segfaults constantly...
rubygem-yard is FIXED SO FAR. This is discussed on https://github.com/lsegal/yard/issues/1514 . Although the upstream is still seeking for some different solution, for now I've just removed invalid `yield` usage from the file used in testsuite.
rubygem-yard https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Many messages like:
1) YARD::Handlers::Ruby::YieldHandler only parses yield blocks in methods Failure/Error: raise ProxyMethodError, "Proxy cannot call method ##{meth} on object '#{path}'"
Discussed on https://github.com/lsegal/yard/issues/1514 : Most probably this is caused by https://github.com/ruby/ruby/commit/b5e23d3e3b5ff2f5328aa43a2392ebe7c951a222 ruby 3.3.0 now adds more checks for "yield" usage, not knowing how to fix on yard side myself.
Regards, Mamoru
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-childprocess
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Same as before.
rubygem-childprocess https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
`Failure/Error: require 'rubygems/mock_gem_ui'` This file is removed: https://github.com/ruby/ruby/commit/74772840430fc3fca3f5fb0ad585d9cc48f512fb Need to address in childprocess side.
Just FTR, this affects one test case which is already half disabled:
https://src.fedoraproject.org/rpms/rubygem-childprocess/blob/19e16da4314f067...
I have reported the issue upstream:
https://github.com/enkessler/childprocess/issues/190
Vít
Dne 28. 11. 23 v 17:04 Vít Ondruch napsal(a):
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-childprocess
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Same as before.
rubygem-childprocess https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
`Failure/Error: require 'rubygems/mock_gem_ui'` This file is removed: https://github.com/ruby/ruby/commit/74772840430fc3fca3f5fb0ad585d9cc48f512fb Need to address in childprocess side.
Just FTR, this affects one test case which is already half disabled:
https://src.fedoraproject.org/rpms/rubygem-childprocess/blob/19e16da4314f067...
Actually it is completely disabled, not just half disabled. It does not anything meaningful with the line commented out.
Vít
I have reported the issue upstream:
https://github.com/enkessler/childprocess/issues/190
Vít
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
rubygem-shoulda-matchers is FIXED: With some discussion, this is fixed on ruby side: https://github.com/ruby/ruby/commit/e34e8b93f8fac3ef40ab5ed8672fa003f3b4d9c0
ref: https://github.com/rubygems/rubygems/pull/7128
rubygem-shoulda-matchers https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Lots of:
An error occurred while loading ./spec/unit/shoulda/matchers/action_controller/callback_matcher_spec.rb. Failure/Error: require 'unit_spec_helper' NoMethodError: undefined method `tr' for an instance of Pathname
Not sure what this means.
There is unfortunately another issue with shoulda-matchers:
~~~
1) shoulda-matchers integrates with Rails in a project that uses Spring Failure/Error: run_rake_tasks!('db:drop', 'db:create', 'db:migrate')
RuntimeError: Command "BUNDLE_GEMFILE="/tmp/shoulda-matchers-acceptance/test-project/Gemfile" bundle _2.5.0.dev_ exec rake db:drop db:create db:migrate --trace" exited with status 1. Output: ---START---------------------------------------------------------------- bundler: failed to load command: rake (/usr/bin/rake) /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/definition.rb:451:in `validate_ruby!': Your Ruby version is 3.3.0.dev, but your Gemfile specified 3.3.0 (Bundler::RubyVersionMismatch) from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/definition.rb:426:in `validate_runtime!' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler.rb:157:in `setup' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/setup.rb:23:in `block in <top (required)>' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/ui/shell.rb:159:in `with_level' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/ui/shell.rb:111:in `silence' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/setup.rb:23:in `<top (required)>' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/cli/exec.rb:56:in `require_relative' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/cli/exec.rb:56:in `kernel_load' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/cli/exec.rb:23:in `run' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/cli.rb:491:in `exec' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/cli.rb:34:in `dispatch' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/cli.rb:28:in `start' from /usr/share/gems/gems/bundler-2.5.0.dev/libexec/bundle:28:in `block in <top (required)>' from /usr/share/gems/gems/bundler-2.5.0.dev/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors' from /usr/share/gems/gems/bundler-2.5.0.dev/libexec/bundle:20:in `<top (required)>' from /usr/bin/bundle:25:in `load' from /usr/bin/bundle:25:in `<main>' ---END------------------------------------------------------------------ # /builddir/build/BUILD/spec/support/tests/command_runner.rb:111:in `fail!' # /builddir/build/BUILD/spec/support/tests/command_runner.rb:69:in `block (2 levels) in call' # /builddir/build/BUILD/spec/support/tests/command_runner.rb:196:in `possibly_running_quickly' # /builddir/build/BUILD/spec/support/tests/command_runner.rb:65:in `block in call' # /builddir/build/BUILD/spec/support/tests/command_runner.rb:202:in `possibly_retrying' # /builddir/build/BUILD/spec/support/tests/command_runner.rb:64:in `call' # /builddir/build/BUILD/spec/support/tests/command_runner.rb:11:in `block in run' # /builddir/build/BUILD/spec/support/tests/command_runner.rb:9:in `run' # /builddir/build/BUILD/spec/support/acceptance/helpers/command_helpers.rb:10:in `run_command' # /builddir/build/BUILD/spec/support/acceptance/helpers/command_helpers.rb:24:in `run_command_isolated_from_bundle' # /builddir/build/BUILD/spec/support/acceptance/helpers/command_helpers.rb:41:in `run_command_within_bundle' # /builddir/build/BUILD/spec/support/acceptance/helpers/command_helpers.rb:50:in `run_command_within_bundle!' # /builddir/build/BUILD/spec/support/acceptance/helpers/command_helpers.rb:65:in `run_rake_tasks!' # ./spec/acceptance/rails_integration_spec.rb:17:in `block (2 levels) in <top (required)>' # /usr/share/gems/gems/bundler-2.5.0.dev/libexec/bundle:28:in `block in <top (required)>' # /usr/share/gems/gems/bundler-2.5.0.dev/libexec/bundle:20:in `<top (required)>'
~~~
Reported here:
https://github.com/rubygems/rubygems/issues/7277
Luckily, this should disappear with official Ruby version.
Vít
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Testsuite is failing, but due to some different reason:
Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got: Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". rails test test/application/console_test.rb:139 F Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got: Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
rubygem-railties https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Failure: ApplicationTests::AssetsTest#test_precompile_shouldn't_use_the_digests_present_in_manifest.json [test/application/assets_test.rb:299]: Expected "application-c56ef81d122dffa8b257b0546ba1b09bd2d8b97e4aef881de8db9f760b903af6.css" to not be equal to "application-c56ef81d122dffa8b257b0546ba1b09bd2d8b97e4aef881de8db9f760b903af6.css".
Not sure what this means.
This seems to be flaky test suite, while it might be also due to Ruby 3.3. So far, I have 14 builds in my Copr and all failed, with one of the failures above. Trying to reproduce locally, the first build passed right away, while the second failed on the AssetsTest.
I'll try to look around if there are by a chance some changes in the upstream repo.
Vít
Dne 15. 12. 23 v 11:10 Vít Ondruch napsal(a):
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Testsuite is failing, but due to some different reason:
Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got: Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". rails test test/application/console_test.rb:139 F Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got: Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
rubygem-railties https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Failure: ApplicationTests::AssetsTest#test_precompile_shouldn't_use_the_digests_present_in_manifest.json [test/application/assets_test.rb:299]: Expected "application-c56ef81d122dffa8b257b0546ba1b09bd2d8b97e4aef881de8db9f760b903af6.css" to not be equal to "application-c56ef81d122dffa8b257b0546ba1b09bd2d8b97e4aef881de8db9f760b903af6.css".
Not sure what this means.
This one ^^ is reproducible even with Ruby 3.2. I have reported it here:
https://github.com/rails/rails/issues/50364
Vít
This seems to be flaky test suite, while it might be also due to Ruby 3.3. So far, I have 14 builds in my Copr and all failed, with one of the failures above. Trying to reproduce locally, the first build passed right away, while the second failed on the AssetsTest.
I'll try to look around if there are by a chance some changes in the upstream repo.
Vít
Dne 15. 12. 23 v 11:10 Vít Ondruch napsal(a):
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Testsuite is failing, but due to some different reason:
Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got: Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". rails test test/application/console_test.rb:139 F Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got: Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
Isn't this related to the Aruba + Reline issue?
https://bugs.ruby-lang.org/issues/20052
https://github.com/ruby/reline/issues/616
Vít
Dne 15. 12. 23 v 17:03 Vít Ondruch napsal(a):
Dne 15. 12. 23 v 11:10 Vít Ondruch napsal(a):
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Testsuite is failing, but due to some different reason:
Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got: Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". rails test test/application/console_test.rb:139 F Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got: Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
Isn't this related to the Aruba + Reline issue?
Luckily, there seems to be fix:
https://github.com/rails/rails/pull/48369/commits/cf45394d104b00679c900e9d2d...
There is one remaining issue:
~~~
* Test file: test/version_test.rb /usr/share/gems/gems/zeitwerk-2.6.6/lib/zeitwerk/kernel.rb:38: warning: drb/unix is found in drb, which will no longer be part of the default gems since Ruby 3.4.0. Add drb to your Gemfile or gemspec. Also contact author of zeitwerk-2.6.6 to add drb into its gemspec. Run options: --seed 46867
# Running:
..
Finished in 0.000818s, 2444.6226 runs/s, 3666.9340 assertions/s. 2 runs, 3 assertions, 0 failures, 0 errors, 0 skips
~~~
Yes, the warning. I am testing with modified rubygem-activesupport [1], which is adding the dependency :
~~~
$ rpm -qR rubygem-activesupport (rubygem(concurrent-ruby) >= 1.0 with rubygem(concurrent-ruby) < 2 with rubygem(concurrent-ruby) >= 1.0.2) (rubygem(i18n) >= 1.6 with rubygem(i18n) < 2) (rubygem(tzinfo) >= 2.0 with rubygem(tzinfo) < 3) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 rpmlib(RichDependencies) <= 4.12.0-1 ruby(rubygems) rubygem(base64) rubygem(bigdecimal) rubygem(bigdecimal) rubygem(drb) rubygem(json) rubygem(minitest) >= 5.1 rubygem(mutex_m) tzdata
$ cat /usr/share/gems/specifications/activesupport-7.0.8.gemspec | grep drb s.add_runtime_dependency(%q<drb>.freeze, [">= 0".freeze])
~~~
And that should be enough. But it is not. Strange ...
Vít
[1] https://src.fedoraproject.org/rpms/rubygem-activesupport/pull-request/4
Dne 15. 12. 23 v 17:57 Vít Ondruch napsal(a):
Dne 15. 12. 23 v 17:03 Vít Ondruch napsal(a):
Dne 15. 12. 23 v 11:10 Vít Ondruch napsal(a):
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Testsuite is failing, but due to some different reason:
Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got: Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". rails test test/application/console_test.rb:139 F Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got: Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
Isn't this related to the Aruba + Reline issue?
Luckily, there seems to be fix:
https://github.com/rails/rails/pull/48369/commits/cf45394d104b00679c900e9d2d...
The fix is in Rawhide:
https://src.fedoraproject.org/rpms/rubygem-railties/c/3c1796f9c84c0b0c9eb062...
https://koji.fedoraproject.org/koji/taskinfo?taskID=110386448
But unfortunately, to pass the test suite with Ruby 3.3, the modified rubygem-activesupport is needed (as discussed elsewhere).
Vít
There is one remaining issue:
* Test file: test/version_test.rb /usr/share/gems/gems/zeitwerk-2.6.6/lib/zeitwerk/kernel.rb:38: warning: drb/unix is found in drb, which will no longer be part of the default gems since Ruby 3.4.0. Add drb to your Gemfile or gemspec. Also contact author of zeitwerk-2.6.6 to add drb into its gemspec. Run options: --seed 46867 # Running: .. Finished in 0.000818s, 2444.6226 runs/s, 3666.9340 assertions/s. 2 runs, 3 assertions, 0 failures, 0 errors, 0 skips
Yes, the warning. I am testing with modified rubygem-activesupport [1], which is adding the dependency :
$ rpm -qR rubygem-activesupport (rubygem(concurrent-ruby) >= 1.0 with rubygem(concurrent-ruby) < 2 with rubygem(concurrent-ruby) >= 1.0.2) (rubygem(i18n) >= 1.6 with rubygem(i18n) < 2) (rubygem(tzinfo) >= 2.0 with rubygem(tzinfo) < 3) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 rpmlib(RichDependencies) <= 4.12.0-1 ruby(rubygems) rubygem(base64) rubygem(bigdecimal) rubygem(bigdecimal) rubygem(drb) rubygem(json) rubygem(minitest) >= 5.1 rubygem(mutex_m) tzdata $ cat /usr/share/gems/specifications/activesupport-7.0.8.gemspec | grep drb s.add_runtime_dependency(%q<drb>.freeze, [">= 0".freeze])
And that should be enough. But it is not. Strange ...
Vít
[1] https://src.fedoraproject.org/rpms/rubygem-activesupport/pull-request/4
Dne 15. 12. 23 v 17:57 Vít Ondruch napsal(a):
There is one remaining issue:
* Test file: test/version_test.rb /usr/share/gems/gems/zeitwerk-2.6.6/lib/zeitwerk/kernel.rb:38: warning: drb/unix is found in drb, which will no longer be part of the default gems since Ruby 3.4.0. Add drb to your Gemfile or gemspec. Also contact author of zeitwerk-2.6.6 to add drb into its gemspec. Run options: --seed 46867 # Running: .. Finished in 0.000818s, 2444.6226 runs/s, 3666.9340 assertions/s. 2 runs, 3 assertions, 0 failures, 0 errors, 0 skips
Yes, the warning. I am testing with modified rubygem-activesupport [1], which is adding the dependency :
$ rpm -qR rubygem-activesupport (rubygem(concurrent-ruby) >= 1.0 with rubygem(concurrent-ruby) < 2 with rubygem(concurrent-ruby) >= 1.0.2) (rubygem(i18n) >= 1.6 with rubygem(i18n) < 2) (rubygem(tzinfo) >= 2.0 with rubygem(tzinfo) < 3) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 rpmlib(RichDependencies) <= 4.12.0-1 ruby(rubygems) rubygem(base64) rubygem(bigdecimal) rubygem(bigdecimal) rubygem(drb) rubygem(json) rubygem(minitest) >= 5.1 rubygem(mutex_m) tzdata $ cat /usr/share/gems/specifications/activesupport-7.0.8.gemspec | grep drb s.add_runtime_dependency(%q<drb>.freeze, [">= 0".freeze])
And that should be enough. But it is not. Strange ...
Vít
This seems to be fixed now. Likely by PRs referred here:
https://bugs.ruby-lang.org/issues/20065#change-105723
V.
Dne 15. 12. 23 v 17:03 Vít Ondruch napsal(a):
Dne 15. 12. 23 v 11:10 Vít Ondruch napsal(a):
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Testsuite is failing, but due to some different reason:
Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got: Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". rails test test/application/console_test.rb:139 F Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got: Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
Isn't this related to the Aruba + Reline issue?
https://bugs.ruby-lang.org/issues/20052
https://github.com/ruby/reline/issues/616
Vít
I have tried to reproduce this with the latest version of Ruby, I have execute the console_test.rb more then 100x and I have not hit the issue. Was it fixed somehow? Not sure.
Vít
Vít Ondruch wrote on 2023/12/20 18:56:
Dne 15. 12. 23 v 17:03 Vít Ondruch napsal(a):
Dne 15. 12. 23 v 11:10 Vít Ondruch napsal(a):
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui... Testsuite is failing, but due to some different reason:
Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got: Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". rails test test/application/console_test.rb:139 F Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got: Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
Isn't this related to the Aruba + Reline issue?
https://bugs.ruby-lang.org/issues/20052
https://github.com/ruby/reline/issues/616
Vít
I have tried to reproduce this with the latest version of Ruby, I have execute the console_test.rb more then 100x and I have not hit the issue. Was it fixed somehow? Not sure.
Vít
Well, actually with rubygem-railties-7.0.8-2 , FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133] is passing, but with rubygem-railties-7.0.8-1, I still see the same error (with ruby git 7c2d819862)
================================================ Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got:
/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/message_verifier.rb:4: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add base64 into its gemspec. /usr/share/gems/gems/activesupport-7.0.8/lib/active_support/core_ext/object/json.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add bigdecimal into its gemspec. /usr/share/gems/gems/activesupport-7.0.8/lib/active_support/notifications/fanout.rb:3: warning: mutex_m was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add mutex_m to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add mutex_m into its gemspec. Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit ▽. Expected # encoding: ASCII-8BIT # valid: true "/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/message_verifier.rb:4: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add base64 into its gemspec.\r\n/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/core_ext/object/json.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add bigdecimal into its gemspec.\r\n/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/notifications/fanout.rb:3: warning: mutex_m was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add mutex_m to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add mutex_m into its gemspec.\r\nLoading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". ================================================
So comparing with 1 and 2, there is Patch4: rubygem-railties-7.1.0-Run-Rails-console-test-against-IRB-with-Reline-instead-of.patch This patch actually seems to have fixed the above issue.
(You are trying to reproduce the above issue with -2?)
Regards, Mamoru
Dne 20. 12. 23 v 14:22 Mamoru TASAKA napsal(a):
Vít Ondruch wrote on 2023/12/20 18:56:
Dne 15. 12. 23 v 17:03 Vít Ondruch napsal(a):
Dne 15. 12. 23 v 11:10 Vít Ondruch napsal(a):
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-railties
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Testsuite is failing, but due to some different reason:
Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got: Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". rails test test/application/console_test.rb:139 F Failure: FullStackConsoleTest#test_environment_option_and_irb_option [test/application/console_test.rb:133]: "> " expected, but got: Loading test environment (Rails 7.0.8) Switch to inspect mode. â–½. Expected # encoding: ASCII-8BIT # valid: true "Loading test environment (Rails 7.0.8)\r\nSwitch to inspect mode.\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ".
Isn't this related to the Aruba + Reline issue?
https://bugs.ruby-lang.org/issues/20052
https://github.com/ruby/reline/issues/616
Vít
I have tried to reproduce this with the latest version of Ruby, I have execute the console_test.rb more then 100x and I have not hit the issue. Was it fixed somehow? Not sure.
Vít
Well, actually with rubygem-railties-7.0.8-2 , FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133] is passing, but with rubygem-railties-7.0.8-1, I still see the same error (with ruby git 7c2d819862)
================================================ Failure: FullStackConsoleTest#test_sandbox [test/application/console_test.rb:133]: "> " expected, but got:
/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/message_verifier.rb:4: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add base64 into its gemspec. /usr/share/gems/gems/activesupport-7.0.8/lib/active_support/core_ext/object/json.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add bigdecimal into its gemspec. /usr/share/gems/gems/activesupport-7.0.8/lib/active_support/notifications/fanout.rb:3: warning: mutex_m was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add mutex_m to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add mutex_m into its gemspec. Loading development environment in sandbox (Rails 7.0.8) Any modifications you make will be rolled back on exit ▽. Expected # encoding: ASCII-8BIT # valid: true "/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/message_verifier.rb:4: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add base64 into its gemspec.\r\n/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/core_ext/object/json.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add bigdecimal into its gemspec.\r\n/usr/share/gems/gems/activesupport-7.0.8/lib/active_support/notifications/fanout.rb:3: warning: mutex_m was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add mutex_m to your Gemfile or gemspec. Also contact author of activesupport-7.0.8 to add mutex_m into its gemspec.\r\nLoading development environment in sandbox (Rails 7.0.8)\r\nAny modifications you make will be rolled back on exit\r\n\e[1G\xE2\x96\xBD\e[6n" to include "> ". ================================================
So comparing with 1 and 2, there is Patch4: rubygem-railties-7.1.0-Run-Rails-console-test-against-IRB-with-Reline-instead-of.patch
This patch actually seems to have fixed the above issue.
(You are trying to reproduce the above issue with -2?)
Oh my. I have fixed it myself. Too much context switching. Sorry and thank you for reminding me.
Vít
Dne 26. 11. 23 v 15:13 Mamoru TASAKA napsal(a):
- rubygem-childprocess
https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
Same as before.
rubygem-childprocess https://copr.fedorainfracloud.org/coprs/mtasaka/rubygem-newruby-test-3-2/bui...
`Failure/Error: require 'rubygems/mock_gem_ui'` This file is removed: https://github.com/ruby/ruby/commit/74772840430fc3fca3f5fb0ad585d9cc48f512fb Need to address in childprocess side.
In case I'll be asking later, I have (hopefully) fixed this one 🤣
https://src.fedoraproject.org/rpms/rubygem-childprocess/c/6822cf78f6253ee136...
Vít
ruby-sig@lists.fedoraproject.org