On Wed, Apr 2, 2025 at 6:58 PM Michel Lind salimma@fedoraproject.org wrote:
On Wed, 2025-04-02 at 11:21 -0500, Michel Lind wrote:
On Wed, 2025-04-02 at 10:47 -0500, Michel Lind via Rust wrote:
Dear maintainers,
Fabio just flagged that below is now broken in Rawhide because netlink- packet-route is updated to an incompatible version without providing a compatibility crate
https://koschei.fedoraproject.org//package/rust-below
Looks like this is only pushed to Rawhide for now
https://bodhi.fedoraproject.org/updates/?search=0.22.0&packages=rust-net...
But is also built in a side tag for F42
https://koji.fedoraproject.org/koji/buildinfo?buildID=2690351
As a reminder, Rawhide updates are not supposed to break - breaking changes must be communicated in advance to affected maintainers, just like for stable branches
https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#_rawhide
For Rust -devel packages, you can typically package the compatibility crate and avoid breaking dependents entirely
I'm packaging rust-netlink-packet-route0.19 now to unbreak
https://bugzilla.redhat.com/show_bug.cgi?id=2356938
(technically this could be approved without a package review, but it's easier to get someone to review it rather than have to burden releng esp since something is already broken)
I'll also build it in f42-build-side-109230 so when the rust-netlink- packet-route update gets submitted for F42 it won't break below-tc and below https://koji.fedoraproject.org/koji/builds?inherited=0&tagID=109230&...
Done: https://koji.fedoraproject.org/koji/buildinfo?buildID=2690446
This update has since also been built and pushed to Fedora 41, but the additional compat package for netlink-packet-route wasn't included in it. I have now submitted the missing build to Fedora 41 too, and made a buildroot override for it too to fix FTBFS / FTI issues caused by the incomplete F41 update.
In the future, please check dependent packages when pushing "breaking" updates for Rust crates like this one, and coordinate with maintainers of dependent packages. The fact that this was pushed to Fedora 41 as-is even though this was already pointed out to have been a problem on Rawhide and Fedora 42 isn't great, either.
Fabio