Re: Handling crate updates

[the Mulhern]

Hi!

I always regenerate using rust2rpm; I think it saves trouble.

Among other things, upstream may have added a new feature (or removed one).
If so then rust2rpm will properly generate the appropriate
sub-packages corresponding to the possible feature combinations.

Also, rust2rpm itself undergoes updates which incorporate changes
which reflect the current Fedora packaging guidelines.

- mulhern

On Sun, Feb 26, 2023 at 4:23 PM  wrote:
> Hello everyone
>
> I was wondering how the rust-sig / rust folks handle crate updates.
> Let's say you generate a spec file with `rust2rpm` and manually patch
> it. The reason is not important here. Then a week later the upstream
> releases a new version. How do you handle this? Do you regenerate the
> spec file with `rust2rpm` and reapply your patches or do you update the
> spec file yourself? Should this be documented in the "Rust Packaging
> Guidelines"?
>
> Hussein
> _______________________________________________
> Rust mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]
> Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

Handling crate updates

[Fabio Valentini]

On Mon, Feb 27, 2023 at 1:11 AM the Mulhern  wrote:
> Hi!
>
> I always regenerate using rust2rpm; I think it saves trouble.
>
> Among other things, upstream may have added a new feature (or removed one).
> If so then rust2rpm will properly generate the appropriate
> sub-packages corresponding to the possible feature combinations.
>
> Also, rust2rpm itself undergoes updates which incorporate changes
> which reflect the current Fedora packaging guidelines.
> mulhern

Seconded.
It's important to regenerate the spec file for every new version (or
even if you patch Cargo.toml, because those patches can affect spec
file contents).

Errors like "there is a feature subpackage for a feature that is no
longer present in the project" were silently ignored by earlier
versions of Rust RPM macros, but with rust-packaging >= 24, this is
now a hard error and will fail the build, since failure to generate
dependencies for a subpackage is exclusively caused by packager error.

Fabio