netlink-packet-route semver breaking update affecting rust-below

[Michel Lind]

Dear maintainers,

Fabio just flagged that below is now broken in Rawhide because netlink-
packet-route is updated to an incompatible version without providing a
compatibility crate

https://koschei.fedoraproject.org//package/rust-below

Looks like this is only pushed to Rawhide for now

https://bodhi.fedoraproject.org/updates/?search=0.22.0&packages=rust-net...

But is also built in a side tag for F42

https://koji.fedoraproject.org/koji/buildinfo?buildID=2690351

As a reminder, Rawhide updates are not supposed to break - breaking
changes must be communicated in advance to affected maintainers, just
like for stable branches

https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#_rawhide

For Rust -devel packages, you can typically package the compatibility
crate and avoid breaking dependents entirely

$ fedrq-cratedeps-verbose.sh netlink-packet-route -b f42
+ fedrq whatrequires rust-netlink-packet-route-devel -F
multiline:source,requiresmatch:rust-netlink-packet-route-devel: -b f42
+ grep -v 'rust-netlink-packet-route :'
+ sort
+ uniq
+ fedrq whatrequires 'rust-netlink-packet-route+*-devel' -F
'multiline:source,requiresmatch:rust-netlink-packet-route+*-devel:' -b
f42
++ fedrq subpkgs rust-netlink-packet-route -F name
++ grep -v rust-netlink-packet-route
nispor : (crate(netlink-packet-route/default) >= 0.19.0 with
crate(netlink-packet-route/default) < 0.20)
nispor : (crate(netlink-packet-route/default) >= 0.19.0 with
crate(netlink-packet-route/default) < 0.20.0~)
rust-below-tc : (crate(netlink-packet-route/default) >= 0.19.0 with
crate(netlink-packet-route/default) < 0.20.0~)
rust-rtnetlink : (crate(netlink-packet-route/default) >= 0.19.0 with
crate(netlink-packet-route/default) < 0.20.0~)

Best regards,

[Michel Lind]

On Wed, 2025-04-02 at 10:47 -0500, Michel Lind via Rust wrote:
> Dear maintainers,
>
> Fabio just flagged that below is now broken in Rawhide because
> netlink-
> packet-route is updated to an incompatible version without providing
> a
> compatibility crate
>
> https://koschei.fedoraproject.org//package/rust-below
>
> Looks like this is only pushed to Rawhide for now
>
> https://bodhi.fedoraproject.org/updates/?search=0.22.0&packages=rust-net...
>
> But is also built in a side tag for F42
>
> https://koji.fedoraproject.org/koji/buildinfo?buildID=2690351
>
> As a reminder, Rawhide updates are not supposed to break - breaking
> changes must be communicated in advance to affected maintainers, just
> like for stable branches
>
> https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#_rawhide
>
> For Rust -devel packages, you can typically package the compatibility
> crate and avoid breaking dependents entirely

I'm packaging rust-netlink-packet-route0.19 now to unbreak

https://bugzilla.redhat.com/show_bug.cgi?id=2356938

(technically this could be approved without a package review, but it's
easier to get someone to review it rather than have to burden releng
esp since something is already broken)

I'll also build it in f42-build-side-109230 so when the rust-netlink-
packet-route update gets submitted for F42 it won't break below-tc and
below
https://koji.fedoraproject.org/koji/builds?inherited=0&tagID=109230&...

[Michel Lind]

On Wed, 2025-04-02 at 11:21 -0500, Michel Lind wrote:
> On Wed, 2025-04-02 at 10:47 -0500, Michel Lind via Rust wrote:
> > Dear maintainers,
> >
> > Fabio just flagged that below is now broken in Rawhide because
> > netlink-
> > packet-route is updated to an incompatible version without
> > providing
> > a
> > compatibility crate
> >
> > https://koschei.fedoraproject.org//package/rust-below
> >
> > Looks like this is only pushed to Rawhide for now
> >
> > https://bodhi.fedoraproject.org/updates/?search=0.22.0&packages=rust-net...
> >
> > But is also built in a side tag for F42
> >
> > https://koji.fedoraproject.org/koji/buildinfo?buildID=2690351
> >
> > As a reminder, Rawhide updates are not supposed to break - breaking
> > changes must be communicated in advance to affected maintainers,
> > just
> > like for stable branches
> >
> > https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#_rawhide
> >
> > For Rust -devel packages, you can typically package the
> > compatibility
> > crate and avoid breaking dependents entirely
>
> I'm packaging rust-netlink-packet-route0.19 now to unbreak
>
> https://bugzilla.redhat.com/show_bug.cgi?id=2356938
>
> (technically this could be approved without a package review, but
> it's
> easier to get someone to review it rather than have to burden releng
> esp since something is already broken)
>
> I'll also build it in f42-build-side-109230 so when the rust-netlink-
> packet-route update gets submitted for F42 it won't break below-tc
> and
> below
> https://koji.fedoraproject.org/koji/builds?inherited=0&tagID=109230&...

Done: https://koji.fedoraproject.org/koji/buildinfo?buildID=2690446

[Fabio Valentini]

On Wed, Apr 2, 2025 at 6:58 PM Michel Lind  wrote:
> On Wed, 2025-04-02 at 11:21 -0500, Michel Lind wrote:
> > On Wed, 2025-04-02 at 10:47 -0500, Michel Lind via Rust wrote:
> > > Dear maintainers,
> > >
> > > Fabio just flagged that below is now broken in Rawhide because
> > > netlink-
> > > packet-route is updated to an incompatible version without
> > > providing
> > > a
> > > compatibility crate
> > >
> > > https://koschei.fedoraproject.org//package/rust-below
> > >
> > > Looks like this is only pushed to Rawhide for now
> > >
> > > https://bodhi.fedoraproject.org/updates/?search=0.22.0&packages=rust-net...
> > >
> > > But is also built in a side tag for F42
> > >
> > > https://koji.fedoraproject.org/koji/buildinfo?buildID=2690351
> > >
> > > As a reminder, Rawhide updates are not supposed to break - breaking
> > > changes must be communicated in advance to affected maintainers,
> > > just
> > > like for stable branches
> > >
> > > https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#_rawhide
> > >
> > > For Rust -devel packages, you can typically package the
> > > compatibility
> > > crate and avoid breaking dependents entirely
> >
> > I'm packaging rust-netlink-packet-route0.19 now to unbreak
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=2356938
> >
> > (technically this could be approved without a package review, but
> > it's
> > easier to get someone to review it rather than have to burden releng
> > esp since something is already broken)
> >
> > I'll also build it in f42-build-side-109230 so when the rust-netlink-
> > packet-route update gets submitted for F42 it won't break below-tc
> > and
> > below
> > https://koji.fedoraproject.org/koji/builds?inherited=0&tagID=109230&...
>
> Done: https://koji.fedoraproject.org/koji/buildinfo?buildID=2690446

This update has since also been built and pushed to Fedora 41, but the
additional compat package for netlink-packet-route wasn't included in
it. I have now submitted the missing build to Fedora 41 too, and made
a buildroot override for it too to fix FTBFS / FTI issues caused by
the incomplete F41 update.

In the future, please check dependent packages when pushing "breaking"
updates for Rust crates like this one, and coordinate with maintainers
of dependent packages. The fact that this was pushed to Fedora 41
as-is even though this was already pointed out to have been a problem
on Rawhide and Fedora 42 isn't great, either.

Fabio

[Gris Ge]

On Sun, Apr 13, 2025 at 03:27:16PM +0200, Fabio Valentini wrote:
> This update has since also been built and pushed to Fedora 41, but the
> additional compat package for netlink-packet-route wasn't included in
> it. I have now submitted the missing build to Fedora 41 too, and made
> a buildroot override for it too to fix FTBFS / FTI issues caused by
> the incomplete F41 update.
>
> In the future, please check dependent packages when pushing "breaking"
> updates for Rust crates like this one, and coordinate with maintainers
> of dependent packages. The fact that this was pushed to Fedora 41
> as-is even though this was already pointed out to have been a problem
> on Rawhide and Fedora 42 isn't great, either.
>
> Fabio

Hi Fabio,

Thanks for fix!

I was expecting nisport and nmstate the only user of
`rust-netlink-packet-route`.
Will work with dependent package maintainer(s) for breaking changes in the
future.

[the Mulhern]

I ran into much the same problem for much the same reason recently,
i.e., I didn't believe that there were any other dependents on a
package.

fedrq will help a bit with that if you know the magic way to invoke it.

This is an example:
> fedrq whatrequires-src  'rust-libcryptsetup-rs*' -b

fido-device-onboard-0.5.4-1.fc43.src
rust-libcryptsetup-rs-0.12.0-1.fc42.src
rust-libcryptsetup-rs+default-devel-0.12.0-1.fc42.noarch
rust-libcryptsetup-rs+mutex-devel-0.12.0-1.fc42.noarch
rust-libcryptsetup-rs-devel-0.12.0-1.fc42.noarch
rust-libcryptsetup-rs-sys+default-devel-0.4.0-3.fc42.noarch
rust-libcryptsetup-rs0.11-0.11.2-1.fc43.src
rust-libcryptsetup-rs0.11+default-devel-0.11.2-1.fc43.noarch
rust-libcryptsetup-rs0.11+mutex-devel-0.11.2-1.fc43.noarch
rust-libcryptsetup-rs0.11-devel-0.11.2-1.fc43.noarch
stratisd-3.8.0-1.fc43.src

fedrq's underlying model continues to perplex me, but it works better
than anything else I know for finding out this info.

There are significant man pages, with examples, and that certainly helps.

- mulhern

On Mon, Apr 14, 2025 at 4:34 AM Gris Ge  wrote:
> On Sun, Apr 13, 2025 at 03:27:16PM +0200, Fabio Valentini wrote:
> > This update has since also been built and pushed to Fedora 41, but the
> > additional compat package for netlink-packet-route wasn't included in
> > it. I have now submitted the missing build to Fedora 41 too, and made
> > a buildroot override for it too to fix FTBFS / FTI issues caused by
> > the incomplete F41 update.
> >
> > In the future, please check dependent packages when pushing "breaking"
> > updates for Rust crates like this one, and coordinate with maintainers
> > of dependent packages. The fact that this was pushed to Fedora 41
> > as-is even though this was already pointed out to have been a problem
> > on Rawhide and Fedora 42 isn't great, either.
> >
> > Fabio
>
> Hi Fabio,
>
> Thanks for fix!
>
> I was expecting nisport and nmstate the only user of
> `rust-netlink-packet-route`.
> Will work with dependent package maintainer(s) for breaking changes in the
> future.
>
> --
> Gris Ge

--
On all the line a sudden vengeance waits,
And frequent hearses shall besiege your gates.
-- Alexander Pope, To the Memory of an Unfortunate Lady.

[Ben Beasley]

I find Michel Lind’s script fedrq-cratedeps-verbose.sh quite useful, 
too. It takes a crate name (or a compat name, like foo0.4), and it shows 
the actual version bounds from the reverse dependencies. It’s “just” a 
thin wrapper around fedrq, but I find it helpful and reliable.

https://git.sr.ht/~michel-slm/fedora-packaging-scripts/tree/main/item/fedrq-...

There’s also a similar fedrq-pydeps-verbose.sh, which is an even thinner 
wrapper around fedrq. Still, it provides a useful formula for getting 
versioned reverse dependency information for a PyPI canonical name.

On 4/14/25 9:42 AM, the Mulhern via Rust wrote:
> I ran into much the same problem for much the same reason recently,
> i.e., I didn't believe that there were any other dependents on a
> package.
>
> fedrq will help a bit with that if you know the magic way to invoke it.
>
> This is an example:
> > fedrq whatrequires-src  'rust-libcryptsetup-rs*' -b
>
> fido-device-onboard-0.5.4-1.fc43.src
> rust-libcryptsetup-rs-0.12.0-1.fc42.src
> rust-libcryptsetup-rs+default-devel-0.12.0-1.fc42.noarch
> rust-libcryptsetup-rs+mutex-devel-0.12.0-1.fc42.noarch
> rust-libcryptsetup-rs-devel-0.12.0-1.fc42.noarch
> rust-libcryptsetup-rs-sys+default-devel-0.4.0-3.fc42.noarch
> rust-libcryptsetup-rs0.11-0.11.2-1.fc43.src
> rust-libcryptsetup-rs0.11+default-devel-0.11.2-1.fc43.noarch
> rust-libcryptsetup-rs0.11+mutex-devel-0.11.2-1.fc43.noarch
> rust-libcryptsetup-rs0.11-devel-0.11.2-1.fc43.noarch
> stratisd-3.8.0-1.fc43.src
>
> fedrq's underlying model continues to perplex me, but it works better
> than anything else I know for finding out this info.
>
> There are significant man pages, with examples, and that certainly helps.
> mulhern
>
> On Mon, Apr 14, 2025 at 4:34 AM Gris Ge  wrote:
> > On Sun, Apr 13, 2025 at 03:27:16PM +0200, Fabio Valentini wrote:
> > > This update has since also been built and pushed to Fedora 41, but the
> > > additional compat package for netlink-packet-route wasn't included in
> > > it. I have now submitted the missing build to Fedora 41 too, and made
> > > a buildroot override for it too to fix FTBFS / FTI issues caused by
> > > the incomplete F41 update.
> > >
> > > In the future, please check dependent packages when pushing "breaking"
> > > updates for Rust crates like this one, and coordinate with maintainers
> > > of dependent packages. The fact that this was pushed to Fedora 41
> > > as-is even though this was already pointed out to have been a problem
> > > on Rawhide and Fedora 42 isn't great, either.
> > >
> > > Fabio
> >
> > Hi Fabio,
> >
> > Thanks for fix!
> >
> > I was expecting nisport and nmstate the only user of
> > `rust-netlink-packet-route`.
> > Will work with dependent package maintainer(s) for breaking changes in the
> > future.
> >
> > --
> > Gris Ge
>
> --
> On all the line a sudden vengeance waits,
> And frequent hearses shall besiege your gates.
> -- Alexander Pope, To the Memory of an Unfortunate Lady.