Hi,
Firecracker 1.12 was released today, and there is only one dependency update:
- bincode-2.0.1 (from 1.3)
This however requires some new crates:
- bincode_derive - unty - virtue
It also wants updates to criterion and glam (retired), but those are only for tests which could be skipped.
Do you want me to take any of these? I could do the package reviews for the new stuff if you want to add them. I created these side tags with a kvm-ioctls update, and I can add Firecracker then push everything together if you add builds to them. (Fedora 40 is omitted since it will be EOL after a week of Bodhi testing.)
f41-build-side-111548 f42-build-side-111546 f43-build-side-111544
Thanks.
David
On Wed, May 7, 2025 at 3:51 PM David Michael fedora.dm0@gmail.com wrote:
Hi,
Firecracker 1.12 was released today, and there is only one dependency update:
- bincode-2.0.1 (from 1.3)
This however requires some new crates:
- bincode_derive
- unty
- virtue
It also wants updates to criterion and glam (retired), but those are only for tests which could be skipped.
Oh, this is annoying. bincode v2 pulls in a *lot* of dependencies just for a single use in one test. I'll see if that can be reduced to a sane dependency tree ...
Do you want me to take any of these? I could do the package reviews for the new stuff if you want to add them. I created these side tags with a kvm-ioctls update, and I can add Firecracker then push everything together if you add builds to them. (Fedora 40 is omitted since it will be EOL after a week of Bodhi testing.)
The three new packages look very straightforward, except for "virtue", where most doctests seem to contain code that doesn't even compile (??) ... I can submit them for review and you review them, or you submit them and I review them, whatever works best for you.
Fabio
On Wed, May 7, 2025 at 4:06 PM Fabio Valentini decathorpe@gmail.com wrote:
On Wed, May 7, 2025 at 3:51 PM David Michael fedora.dm0@gmail.com wrote:
Hi,
Firecracker 1.12 was released today, and there is only one dependency update:
- bincode-2.0.1 (from 1.3)
This however requires some new crates:
- bincode_derive
- unty
- virtue
It also wants updates to criterion and glam (retired), but those are only for tests which could be skipped.
Oh, this is annoying. bincode v2 pulls in a *lot* of dependencies just for a single use in one test. I'll see if that can be reduced to a sane dependency tree ...
Do you want me to take any of these? I could do the package reviews for the new stuff if you want to add them. I created these side tags with a kvm-ioctls update, and I can add Firecracker then push everything together if you add builds to them. (Fedora 40 is omitted since it will be EOL after a week of Bodhi testing.)
The three new packages look very straightforward, except for "virtue", where most doctests seem to contain code that doesn't even compile (??) ... I can submit them for review and you review them, or you submit them and I review them, whatever works best for you.
Never mind, I figured out the failing-to-compile tests in "virtue". So I have working packages for all three new dependencies already, so would it work for you if I submitted them for review?
Fabio
On Wed, May 7, 2025 at 10:12 AM Fabio Valentini decathorpe@gmail.com wrote:
On Wed, May 7, 2025 at 4:06 PM Fabio Valentini decathorpe@gmail.com wrote:
On Wed, May 7, 2025 at 3:51 PM David Michael fedora.dm0@gmail.com wrote:
Hi,
Firecracker 1.12 was released today, and there is only one dependency update:
- bincode-2.0.1 (from 1.3)
This however requires some new crates:
- bincode_derive
- unty
- virtue
It also wants updates to criterion and glam (retired), but those are only for tests which could be skipped.
Oh, this is annoying. bincode v2 pulls in a *lot* of dependencies just for a single use in one test. I'll see if that can be reduced to a sane dependency tree ...
Do you want me to take any of these? I could do the package reviews for the new stuff if you want to add them. I created these side tags with a kvm-ioctls update, and I can add Firecracker then push everything together if you add builds to them. (Fedora 40 is omitted since it will be EOL after a week of Bodhi testing.)
The three new packages look very straightforward, except for "virtue", where most doctests seem to contain code that doesn't even compile (??) ... I can submit them for review and you review them, or you submit them and I review them, whatever works best for you.
Never mind, I figured out the failing-to-compile tests in "virtue". So I have working packages for all three new dependencies already, so would it work for you if I submitted them for review?
Yes, that sounds good to me. I'll probably be AFK for a few hours shortly, so I'll be able to review them later in the afternoon if they're ready already.
Thanks.
David
On Wed, May 7, 2025 at 4:19 PM David Michael fedora.dm0@gmail.com wrote:
Yes, that sounds good to me. I'll probably be AFK for a few hours shortly, so I'll be able to review them later in the afternoon if they're ready already.
Thank you for the reviews! I've prepared the bincode 2 update, and now I'm just waiting for this ticket to get processed: https://pagure.io/releng/fedora-scm-requests/issue/75883
As soon as that is resolved, I'll import the packages and build them in your side-tags:
f41-build-side-111548 f42-build-side-111546 f43-build-side-111544
(Well, and in epel10 and epel9, but that doesn't affect you.)
Fabio
On Thu, May 8, 2025 at 12:47 PM Fabio Valentini decathorpe@gmail.com wrote:
On Wed, May 7, 2025 at 4:19 PM David Michael fedora.dm0@gmail.com wrote:
Yes, that sounds good to me. I'll probably be AFK for a few hours shortly, so I'll be able to review them later in the afternoon if they're ready already.
Thank you for the reviews! I've prepared the bincode 2 update, and now I'm just waiting for this ticket to get processed: https://pagure.io/releng/fedora-scm-requests/issue/75883
As soon as that is resolved, I'll import the packages and build them in your side-tags:
f41-build-side-111548 f42-build-side-111546 f43-build-side-111544
Builds for bincode v2 and associated dependencies are now available in these three side-tags. It would be great if you could associate the bincode v2 update bug (2350432) and the bugs for the three review requests (2364712, 2364713, 2364714) with the rawhide update so that they're closed automatically when the update is pushed.
Fabio
On Mon, May 12, 2025 at 6:39 AM Fabio Valentini decathorpe@gmail.com wrote:
On Thu, May 8, 2025 at 12:47 PM Fabio Valentini decathorpe@gmail.com wrote:
On Wed, May 7, 2025 at 4:19 PM David Michael fedora.dm0@gmail.com wrote:
Yes, that sounds good to me. I'll probably be AFK for a few hours shortly, so I'll be able to review them later in the afternoon if they're ready already.
Thank you for the reviews! I've prepared the bincode 2 update, and now I'm just waiting for this ticket to get processed: https://pagure.io/releng/fedora-scm-requests/issue/75883
As soon as that is resolved, I'll import the packages and build them in your side-tags:
f41-build-side-111548 f42-build-side-111546 f43-build-side-111544
Builds for bincode v2 and associated dependencies are now available in these three side-tags. It would be great if you could associate the bincode v2 update bug (2350432) and the bugs for the three review requests (2364712, 2364713, 2364714) with the rawhide update so that they're closed automatically when the update is pushed.
Okay, updates are up:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-345f5f9a02 https://bodhi.fedoraproject.org/updates/FEDORA-2025-66addfbca8 https://bodhi.fedoraproject.org/updates/FEDORA-2025-d98b57ac52
Thanks again for getting this done so quickly.
David