Intent to package and update rust-proc-macro-crate dependencies / review help needed

[Robert-André Mauchin]

Hi,

Remy Lauzier started to package rust-proc-macro-crate and several of its 
dependencies. I intend to package the rest of the tree of dependencies 
in a side tag. I have already started preparing some of them locally:

rust-proc-macro-crate: to push, to merge, to build 0

rust-num_enum_derive: to push, to merge, to build 1
rust-ruma-api-macros: to push, to merge, to build 1
rust-ruma-events-macros: to push, to merge, to build 1
rust-ruma-identifiers-validation: to push, to merge, to build 1
rust-ruma-serde-macros: to push, to merge, to build 1
rust-wildmatch: to push, to merge, to build 1
rust-curl-sys: to push, to merge, to build 1
rust-quickcheck_macros: to push, to merge, to build 1
rust-zbus_macros: to push, to merge, to build 1
rust-zvariant_derive: to push, to merge, to build 1

rust-ruma-identifiers-macros: to push, to merge, to build 2
rust-ruma-serde: to push, to merge, to build 2
rust-attohttpc: to push, to merge, to build 2
rust-curl: to push, to merge, to build 2
rust-sluice: to push, to merge, to build 2
rust-half: to push, to merge, to build 2
rust-zvariant: to push, to merge, to build 2

rust-ruma-identifiers: to push, to merge, to build 3
rust-isahc: to push, to merge, to build 3

rust-ruma-common: to push, to merge, to build 4

rust-ruma-events: to push, to merge, to build 5
rust-ruma-signatures: to push, to merge, to build 5

rust-ruma-api: to push, to merge, to build 6

rust-ruma-appservice-api: to push, to merge, to build 7
rust-ruma-client-api: to push, to merge, to build 7
rust-ruma-federation-api: to push, to merge, to build 7
rust-ruma-identity-service-api: to push, to merge, to build 7
rust-ruma-push-gateway-api: to push, to merge, to build 7

rust-ruma: to push, to merge, to build 8

Some packages had new dependencies and I'd like to ask your help to 
review them:

Part 1

rust-cpufeatures: to review, to import, to build 1
https://bugzilla.redhat.com/show_bug.cgi?id=rust-cpufeatures

rust-sha2: to push, to merge, to build 2

rust-curve25519-dalek: to review, to import, to build 3 
https://bugzilla.redhat.com/show_bug.cgi?id=rust-curve25519-dalek

rust-signature: to review, to import, to build 3 
https://bugzilla.redhat.com/show_bug.cgi?id=rust-signature

rust-ed25519: to review, to import, to build 4 
https://bugzilla.redhat.com/show_bug.cgi?id=rust-ed25519

Part 2

rust-const-oid: to review, to import, to build 1 
https://bugzilla.redhat.com/show_bug.cgi?id=rust-const-oid

rust-der: to review, to import, to build 2
https://bugzilla.redhat.com/show_bug.cgi?id=rust-der

rust-spki: to review, to import, to build 3
https://bugzilla.redhat.com/show_bug.cgi?id=rust-spki

rust-pkcs8: to review, to import, to build 4
https://bugzilla.redhat.com/show_bug.cgi?id=rust-pkcs8

In order to review them you'll probably need to build against my COPR:
https://copr.fedorainfracloud.org/coprs/eclipseo/rusttests

I still have to prepare all the packages affected by the 
rust-system-deps bump to 3.

Best regards,

Robert-André

[Fabio Valentini]

On Fri, Jul 16, 2021 at 3:50 PM Robert-André Mauchin  wrote:
> Hi,
>
> Remy Lauzier started to package rust-proc-macro-crate and several of its
> dependencies. I intend to package the rest of the tree of dependencies
> in a side tag. I have already started preparing some of them locally:

Hey,

Sorry, I planned to tackle the proc-macro-crate update sooner, but got
sidetracked by 50+ new pending updates for elementary OS 6 components
...
I wonder if it wouldn't be *much* simpler to create a few compat
packages, i.e. at least for proc-macro-crate? A lot of packages still
use the old version.
> rust-proc-macro-crate: to push, to merge, to build 0
>
> rust-num_enum_derive: to push, to merge, to build 1
> rust-ruma-api-macros: to push, to merge, to build 1
> rust-ruma-events-macros: to push, to merge, to build 1
> rust-ruma-identifiers-validation: to push, to merge, to build 1
> rust-ruma-serde-macros: to push, to merge, to build 1
> rust-wildmatch: to push, to merge, to build 1
> rust-curl-sys: to push, to merge, to build 1
> rust-quickcheck_macros: to push, to merge, to build 1
> rust-zbus_macros: to push, to merge, to build 1
> rust-zvariant_derive: to push, to merge, to build 1
>
> rust-ruma-identifiers-macros: to push, to merge, to build 2
> rust-ruma-serde: to push, to merge, to build 2
> rust-attohttpc: to push, to merge, to build 2
> rust-curl: to push, to merge, to build 2
> rust-sluice: to push, to merge, to build 2
> rust-half: to push, to merge, to build 2
> rust-zvariant: to push, to merge, to build 2
>
> rust-ruma-identifiers: to push, to merge, to build 3
> rust-isahc: to push, to merge, to build 3
>
> rust-ruma-common: to push, to merge, to build 4
>
> rust-ruma-events: to push, to merge, to build 5
> rust-ruma-signatures: to push, to merge, to build 5
>
> rust-ruma-api: to push, to merge, to build 6
>
> rust-ruma-appservice-api: to push, to merge, to build 7
> rust-ruma-client-api: to push, to merge, to build 7
> rust-ruma-federation-api: to push, to merge, to build 7
> rust-ruma-identity-service-api: to push, to merge, to build 7
> rust-ruma-push-gateway-api: to push, to merge, to build 7
>
> rust-ruma: to push, to merge, to build 8

I wonder if anybody or anything is actually using the ruma stack? A
repoquery tells me crate(ruma) is unused, at least ...
I never needed to touch any of the ruma packages, and it's just an
ginormous pile of small packages ...
> Some packages had new dependencies and I'd like to ask your help to
> review them:
>
> Part 1
>
> rust-cpufeatures: to review, to import, to build 1
> https://bugzilla.redhat.com/show_bug.cgi?id=rust-cpufeatures
>
> rust-sha2: to push, to merge, to build 2

At least this one already exists, why is it listed in the "new packages" list?
https://src.fedoraproject.org/rpms/rust-sha2
> rust-curve25519-dalek: to review, to import, to build 3
> https://bugzilla.redhat.com/show_bug.cgi?id=rust-curve25519-dalek

I have only ever seen curve25519-dalek scoped as a windows-specific
dependency, are you sure you really need it?
> rust-signature: to review, to import, to build 3
> https://bugzilla.redhat.com/show_bug.cgi?id=rust-signature
>
> rust-ed25519: to review, to import, to build 4
> https://bugzilla.redhat.com/show_bug.cgi?id=rust-ed25519

Same here, only ever seen this as a windows-specific dependency.
> Part 2
>
> rust-const-oid: to review, to import, to build 1
> https://bugzilla.redhat.com/show_bug.cgi?id=rust-const-oid
>
> rust-der: to review, to import, to build 2
> https://bugzilla.redhat.com/show_bug.cgi?id=rust-der
>
> rust-spki: to review, to import, to build 3
> https://bugzilla.redhat.com/show_bug.cgi?id=rust-spki
>
> rust-pkcs8: to review, to import, to build 4
> https://bugzilla.redhat.com/show_bug.cgi?id=rust-pkcs8
>
> In order to review them you'll probably need to build against my COPR:
> https://copr.fedorainfracloud.org/coprs/eclipseo/rusttests
>
> I still have to prepare all the packages affected by the
> rust-system-deps bump to 3.
>
> Best regards,
>
> Robert-André

Thanks for looking into it.

Fabio

[Robert-André Mauchin]

On 7/16/21 4:02 PM, Fabio Valentini wrote:
> On Fri, Jul 16, 2021 at 3:50 PM Robert-André Mauchin  wrote:
> > Hi,
> >
> > Remy Lauzier started to package rust-proc-macro-crate and several of its
> > dependencies. I intend to package the rest of the tree of dependencies
> > in a side tag. I have already started preparing some of them locally:
>
> Hey,
>
> Sorry, I planned to tackle the proc-macro-crate update sooner, but got
> sidetracked by 50+ new pending updates for elementary OS 6 components
> ...
> I wonder if it wouldn't be *much* simpler to create a few compat
> packages, i.e. at least for proc-macro-crate? A lot of packages still
> use the old version.

So far I had 2 direct dependencies broken by proc-macro-crate changes, 
but this was easily patched (one of the upstream merged my patch).
> > rust-proc-macro-crate: to push, to merge, to build 0
> >
> > rust-num_enum_derive: to push, to merge, to build 1
> > rust-ruma-api-macros: to push, to merge, to build 1
> > rust-ruma-events-macros: to push, to merge, to build 1
> > rust-ruma-identifiers-validation: to push, to merge, to build 1
> > rust-ruma-serde-macros: to push, to merge, to build 1
> > rust-wildmatch: to push, to merge, to build 1
> > rust-curl-sys: to push, to merge, to build 1
> > rust-quickcheck_macros: to push, to merge, to build 1
> > rust-zbus_macros: to push, to merge, to build 1
> > rust-zvariant_derive: to push, to merge, to build 1
> >
> > rust-ruma-identifiers-macros: to push, to merge, to build 2
> > rust-ruma-serde: to push, to merge, to build 2
> > rust-attohttpc: to push, to merge, to build 2
> > rust-curl: to push, to merge, to build 2
> > rust-sluice: to push, to merge, to build 2
> > rust-half: to push, to merge, to build 2
> > rust-zvariant: to push, to merge, to build 2
> >
> > rust-ruma-identifiers: to push, to merge, to build 3
> > rust-isahc: to push, to merge, to build 3
> >
> > rust-ruma-common: to push, to merge, to build 4
> >
> > rust-ruma-events: to push, to merge, to build 5
> > rust-ruma-signatures: to push, to merge, to build 5
> >
> > rust-ruma-api: to push, to merge, to build 6
> >
> > rust-ruma-appservice-api: to push, to merge, to build 7
> > rust-ruma-client-api: to push, to merge, to build 7
> > rust-ruma-federation-api: to push, to merge, to build 7
> > rust-ruma-identity-service-api: to push, to merge, to build 7
> > rust-ruma-push-gateway-api: to push, to merge, to build 7
> >
> > rust-ruma: to push, to merge, to build 8
>
> I wonder if anybody or anything is actually using the ruma stack? A
> repoquery tells me crate(ruma) is unused, at least ...
> I never needed to touch any of the ruma packages, and it's just an
> ginormous pile of small packages ...

I don't know what was the goal when Igor packaged it. The work is 
already done now, so it doesn't really matter.
> > Some packages had new dependencies and I'd like to ask your help to
> > review them:
> >
> > Part 1
> >
> > rust-cpufeatures: to review, to import, to build 1
> > https://bugzilla.redhat.com/show_bug.cgi?id=rust-cpufeatures
> >
> > rust-sha2: to push, to merge, to build 2
>
> At least this one already exists, why is it listed in the "new packages" list?
> https://src.fedoraproject.org/rpms/rust-sha2

Yes it is packaged, the update is needed to package the two following 
package.
> > rust-curve25519-dalek: to review, to import, to build 3
> > https://bugzilla.redhat.com/show_bug.cgi?id=rust-curve25519-dalek
>
> I have only ever seen curve25519-dalek scoped as a windows-specific
> dependency, are you sure you really need it?
> > rust-signature: to review, to import, to build 3
> > https://bugzilla.redhat.com/show_bug.cgi?id=rust-signature
> >
> > rust-ed25519: to review, to import, to build 4
> > https://bugzilla.redhat.com/show_bug.cgi?id=rust-ed25519
>
> Same here, only ever seen this as a windows-specific dependency.

It is needed by ruma-signatures, it doesn't seem to seem to be a Windows 
only dependencies.
> > Part 2
> >
> > rust-const-oid: to review, to import, to build 1
> > https://bugzilla.redhat.com/show_bug.cgi?id=rust-const-oid
> >
> > rust-der: to review, to import, to build 2
> > https://bugzilla.redhat.com/show_bug.cgi?id=rust-der
> >
> > rust-spki: to review, to import, to build 3
> > https://bugzilla.redhat.com/show_bug.cgi?id=rust-spki
> >
> > rust-pkcs8: to review, to import, to build 4
> > https://bugzilla.redhat.com/show_bug.cgi?id=rust-pkcs8
> >
> > In order to review them you'll probably need to build against my COPR:
> > https://copr.fedorainfracloud.org/coprs/eclipseo/rusttests
> >
> > I still have to prepare all the packages affected by the
> > rust-system-deps bump to 3.
> >
> > Best regards,
> >
> > Robert-André
>
> Thanks for looking into it.
>
> Fabio

Take care,

Robert-André

[Fabio Valentini]

On Fri, Jul 16, 2021 at 4:33 PM Robert-André Mauchin  wrote:
> On 7/16/21 4:02 PM, Fabio Valentini wrote:
> > On Fri, Jul 16, 2021 at 3:50 PM Robert-André Mauchin  wrote:
> > > Hi,
> > >
> > > Remy Lauzier started to package rust-proc-macro-crate and several of its
> > > dependencies. I intend to package the rest of the tree of dependencies
> > > in a side tag. I have already started preparing some of them locally:
> >
> > Hey,
> >
> > Sorry, I planned to tackle the proc-macro-crate update sooner, but got
> > sidetracked by 50+ new pending updates for elementary OS 6 components
> > ...
> > I wonder if it wouldn't be *much* simpler to create a few compat
> > packages, i.e. at least for proc-macro-crate? A lot of packages still
> > use the old version.
>
> So far I had 2 direct dependencies broken by proc-macro-crate changes,
> but this was easily patched (one of the upstream merged my patch).

I have started working on this today:

https://bodhi.fedoraproject.org/updates/FEDORA-2021-d839027695
https://bodhi.fedoraproject.org/updates/FEDORA-2021-dc047427ba

This covers proc-macro-crate 1.0.0 plus a 0.1 compat package, and the
pending num_enum* and zvariant* updates that needed 1.0.0.

These are self-contained updates that did not make any other changes
necessary, which should - I hope - make it easier to work
incrementally on the rest of the updates, instead of making it
necessary to update a whole boatload at once.

I'll try to map out a dependency graph and build order for the gtk-rs
stack tomorrow.
But I'm not particularly hopeful at this point, since it looks like
we'll either need to create compat packages for more than half of
those packages (for newsflash and squeekboard, which both are stuck on
old gtk-rs 0.10 versions for now), or port newsflash and squeekboard
to gtk-rs 0.14 downstream (newsflash upstream has some patches in git
master, but I have no idea about squeekboard, they use some kind of
franken-buildsystem involving bash, python, meson, and Cargo.toml
templates ... but from what I can tell, it looks like they do not
support gtk-rs 0.14 yet).

As soon as rust-cpufeatures is built, I'll work on the pending
RustCrypto updates as well.

Fabio