Re: [PATCH v2 0/6] Complete 4k API

[Vojtech Juranek]

Looks good to me (besides typos/minor changes already spotted by Pavel and 
Amit)

On neděle 12. května 2019 17:54:22 CEST Nir Soffer wrote:
>  Add the missing align and sector arguments to read_resource_owners()
> and
>  add infrastructue for testing 4k storage and initial tests.
>  
>  The tests for using wrong sector size revealed that
>  read_resouce_owners() ignores wrong align and sector size. Make it more
>  strict to be consistent with other APIs.
>  
>  Changes since v1:
>  - Update python/example.py (Vojta)
>  - Improve test infrastructure for testing 4k storage (Amit, Pavel)
>  - Improve comments and commit messages (Pavel)
>  - Make the validation code in read_resource_owners more clear (Pavel)
>  - Add test for read_resource_owners with invalid align value
>  - Don't override align_size if sector_size is not set
>  - Reject invalid align in sanlock_read_resource_owners()
>  
>  v1 was here:
>  https://lists.fedorahosted.org/archives/list/[e-mail]
>  d.org/thread/6C44IXV2VTBNDRNWEVH2RCNETPTYMYNW/ 
 
>  Nir Soffer (6):
>    python: Add align and sector arguments to read_resource_owners()
>    tests: Start tests for 4k storage
>    tests: Test wrong sector size with 4k storage
>    sanlock: Fail read_resource_owners() with wrong sector size
>    tests: Add failing test for invalid align size
>    sanlock: Fail read_resource_owners with incorrect align size
>  
>   README.dev           |  44 +++++++++++++
>   python/example.py    |   2 +-
>   python/sanlock.c     |  24 +++++--
>   src/resource.c       |  37 ++++++++---
>   tests/conftest.py    |  36 +++++++++++
>   tests/python_test.py | 148 ++++++++++++++++++++++++++++++++++++++++++-
>   tests/util.py        |  34 ++++++----
>   tox.ini              |   2 +-
>   8 files changed, 299 insertions(+), 28 deletions(-)
>  
>  -- 
>  2.17.2
>  _______________________________________________
>  sanlock-devel mailing list -- sanlock-devel(a)lists.fedorahosted.org
>  To unsubscribe send an email to sanlock-devel-leave(a)lists.fedorahosted.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedorahosted.org/archives/list/[e-mail]
>  ed.org