Re: [PATCH v2 0/4] Fix python style issues

[Vojtech Juranek]

> The whole patch looks good!

+1
> On Sun, Jun 16, 2019 at 7:12 PM Nir Soffer  wrote:
> > Fix python style issues and add flake8 style check to the build to keep
> > the code in good shape.
> >
> > Changes since v1:
> >
> > Add flake8 to travis build
> >
> > Replace star imports with explicit imports to allow flake8 detection
> >
> > of undefined names (Pavel)
> >
> > Convert example.py to python3 - breaks flake8 on python 3 builds.
> >
> > v1 was here:
> >
> > https://lists.fedorahosted.org/archives/list/[e-mail]
> > ted.org/thread/ZH4XT326TS25PCZH2ESGVME5XPSUZPUR/> 
> > Nir Soffer (4):
> >   python: Add flak8 env
> >   python: Avoid star imports
> >   python: Fix style issues
> >   python: Convert example.py to python 3
> >
> > .travis.yml          |  4 ++++
> >  README.dev           |  4 ++++
> >  python/example.py    | 56 +++++++++++++++++++++++++++-----------------
> >  tests/conftest.py    |  8 +++----
> >  tests/daemon_test.py | 15 ++++++++----
> >  tests/direct_test.py |  2 +-
> >  tests/python_test.py | 48 +++++++++++++++++++++++++------------
> >  tests/util.py        |  2 +-
> >  tox.ini              |  9 ++++++-
> >  9 files changed, 101 insertions(+), 47 deletions(-)
> >
> > --
> > 2.17.2

[PATCH v2 0/4] Fix python style issues

[Nir Soffer]

On Mon, Jun 17, 2019 at 2:42 PM Vojtech Juranek  wrote:
> > The whole patch looks good!
>
> +1

Thanks for reviewing! pushed.
> > On Sun, Jun 16, 2019 at 7:12 PM Nir Soffer  wrote:
> > > Fix python style issues and add flake8 style check to the build to keep
> > > the code in good shape.
> > >
> > > Changes since v1:
> > >
> > > Add flake8 to travis build
> > >
> > > Replace star imports with explicit imports to allow flake8 detection
> > >
> > > of undefined names (Pavel)
> > >
> > > Convert example.py to python3 - breaks flake8 on python 3 builds.
> > >
> > > v1 was here:
>
> https://lists.fedorahosted.org/archives/list/[e-mail]
> > > ted.org/thread/ZH4XT326TS25PCZH2ESGVME5XPSUZPUR/>
> > > Nir Soffer (4):
> > >   python: Add flak8 env
> > >   python: Avoid star imports
> > >   python: Fix style issues
> > >   python: Convert example.py to python 3
> > >
> > > .travis.yml          |  4 ++++
> > >  README.dev           |  4 ++++
> > >  python/example.py    | 56 +++++++++++++++++++++++++++-----------------
> > >  tests/conftest.py    |  8 +++----
> > >  tests/daemon_test.py | 15 ++++++++----
> > >  tests/direct_test.py |  2 +-
> > >  tests/python_test.py | 48 +++++++++++++++++++++++++------------
> > >  tests/util.py        |  2 +-
> > >  tox.ini              |  9 ++++++-
> > >  9 files changed, 101 insertions(+), 47 deletions(-)
> > >
> > > --
> > > 2.17.2