Re: [PATCH 0/2] Remove init_lockspace and init_resource API

[Vojtech Juranek]

On neděle 23. srpna 2020 10:35:37 CEST Amit Bawer wrote:
> init_lockspace() and init_resoruce() API was deprected by
> respective write_lockspace() and write_resource() API way back.
> It was only kept for backward compatibility with legacy python2
> code still consuming the old API. Now that python2 has officialy
> retired, the deprecated python API can be cleared from sanlock.
>
> Amit Bawer (2):
>   python: Remove init_lockspace() deprecated API
>   python: Remove init_resource() deprecated API
>
> python/sanlock.c     | 105 -------------------------------------------
>  tests/python_test.py |  31 -------------
>  2 files changed, 136 deletions(-)

+1 to both patches

[PATCH 0/2] Remove init_lockspace and init_resource API

[Nir Soffer]

On Mon, Aug 24, 2020 at 10:09 AM Vojtech Juranek  wrote:
> On neděle 23. srpna 2020 10:35:37 CEST Amit Bawer wrote:
> > init_lockspace() and init_resoruce() API was deprected by
> > respective write_lockspace() and write_resource() API way back.
> > It was only kept for backward compatibility with legacy python2
> > code still consuming the old API. Now that python2 has officialy
> > retired, the deprecated python API can be cleared from sanlock.
> >
> > Amit Bawer (2):
> >   python: Remove init_lockspace() deprecated API
> >   python: Remove init_resource() deprecated API

Do you have public git where I can pull these changes?
> > python/sanlock.c     | 105 -------------------------------------------
> >  tests/python_test.py |  31 -------------
> >  2 files changed, 136 deletions(-)
>
> +1 to both patches

[PATCH 0/2] Remove init_lockspace and init_resource API

[Amit Bawer]

Well, I submitted them first to your copy like we did until so far.
but i was asked to use the mailing list instead.
So you have them in the PR of nirs/sanlock:
https://github.com/nirs/sanlock/pull/21

On Mon, Aug 24, 2020 at 7:17 PM Nir Soffer  wrote:
> On Mon, Aug 24, 2020 at 10:09 AM Vojtech Juranek 
> wrote:
> > On neděle 23. srpna 2020 10:35:37 CEST Amit Bawer wrote:
> > > init_lockspace() and init_resoruce() API was deprected by
> > > respective write_lockspace() and write_resource() API way back.
> > > It was only kept for backward compatibility with legacy python2
> > > code still consuming the old API. Now that python2 has officialy
> > > retired, the deprecated python API can be cleared from sanlock.
> > >
> > > Amit Bawer (2):
> > >   python: Remove init_lockspace() deprecated API
> > >   python: Remove init_resource() deprecated API
>
> Do you have public git where I can pull these changes?
> > > python/sanlock.c     | 105 -------------------------------------------
> > >  tests/python_test.py |  31 -------------
> > >  2 files changed, 136 deletions(-)
> >
> > +1 to both patches

[PATCH 0/2] Remove init_lockspace and init_resource API

[Nir Soffer]

On Mon, Aug 24, 2020 at 8:09 PM Amit Bawer  wrote:
> Well, I submitted them first to your copy like we did until so far.
> but i was asked to use the mailing list instead.
> So you have them in the PR of nirs/sanlock:
> https://github.com/nirs/sanlock/pull/21

That is https://github.com/aabawer/sanlock/tree/remove_init then.
> On Mon, Aug 24, 2020 at 7:17 PM Nir Soffer  wrote:
> > On Mon, Aug 24, 2020 at 10:09 AM Vojtech Juranek  wrote:
> > > On neděle 23. srpna 2020 10:35:37 CEST Amit Bawer wrote:
> > > > init_lockspace() and init_resoruce() API was deprected by
> > > > respective write_lockspace() and write_resource() API way back.
> > > > It was only kept for backward compatibility with legacy python2
> > > > code still consuming the old API. Now that python2 has officialy
> > > > retired, the deprecated python API can be cleared from sanlock.
> > > >
> > > > Amit Bawer (2):
> > > >   python: Remove init_lockspace() deprecated API
> > > >   python: Remove init_resource() deprecated API
> >
> > Do you have public git where I can pull these changes?
> > > > python/sanlock.c     | 105 -------------------------------------------
> > > >  tests/python_test.py |  31 -------------
> > > >  2 files changed, 136 deletions(-)
> > >
> > > +1 to both patches

[PATCH 0/2] Remove init_lockspace and init_resource API

[Nir Soffer]

On Mon, Aug 24, 2020 at 8:11 PM Nir Soffer  wrote:
> On Mon, Aug 24, 2020 at 8:09 PM Amit Bawer  wrote:
> > Well, I submitted them first to your copy like we did until so far.
> > but i was asked to use the mailing list instead.
> > So you have them in the PR of nirs/sanlock:
> > https://github.com/nirs/sanlock/pull/21
>
> That is https://github.com/aabawer/sanlock/tree/remove_init then.

commit 47d0b4281ad5de78092abd7b750d64a5334452fa

Right?
> > On Mon, Aug 24, 2020 at 7:17 PM Nir Soffer  wrote:
> > > On Mon, Aug 24, 2020 at 10:09 AM Vojtech Juranek  wrote:
> > > > On neděle 23. srpna 2020 10:35:37 CEST Amit Bawer wrote:
> > > > > init_lockspace() and init_resoruce() API was deprected by
> > > > > respective write_lockspace() and write_resource() API way back.
> > > > > It was only kept for backward compatibility with legacy python2
> > > > > code still consuming the old API. Now that python2 has officialy
> > > > > retired, the deprecated python API can be cleared from sanlock.
> > > > >
> > > > > Amit Bawer (2):
> > > > >   python: Remove init_lockspace() deprecated API
> > > > >   python: Remove init_resource() deprecated API
> > >
> > > Do you have public git where I can pull these changes?
> > > > > python/sanlock.c     | 105 -------------------------------------------
> > > > >  tests/python_test.py |  31 -------------
> > > > >  2 files changed, 136 deletions(-)
> > > >
> > > > +1 to both patches

[PATCH 0/2] Remove init_lockspace and init_resource API

[Amit Bawer]

On Mon, Aug 24, 2020 at 8:12 PM Nir Soffer  wrote:
> On Mon, Aug 24, 2020 at 8:11 PM Nir Soffer  wrote:
> > On Mon, Aug 24, 2020 at 8:09 PM Amit Bawer  wrote:
> > > Well, I submitted them first to your copy like we did until so far.
> > > but i was asked to use the mailing list instead.
> > > So you have them in the PR of nirs/sanlock:
> > > https://github.com/nirs/sanlock/pull/21
> >
> > That is https://github.com/aabawer/sanlock/tree/remove_init then.
>
> commit 47d0b4281ad5de78092abd7b750d64a5334452fa
>
> Right?

Both two top commits there.
> > > On Mon, Aug 24, 2020 at 7:17 PM Nir Soffer  wrote:
> > > > On Mon, Aug 24, 2020 at 10:09 AM Vojtech Juranek
>
> wrote:
> > > > > On neděle 23. srpna 2020 10:35:37 CEST Amit Bawer wrote:
> > > > > > init_lockspace() and init_resoruce() API was deprected by
> > > > > > respective write_lockspace() and write_resource() API way back.
> > > > > > It was only kept for backward compatibility with legacy python2
> > > > > > code still consuming the old API. Now that python2 has officialy
> > > > > > retired, the deprecated python API can be cleared from sanlock.
> > > > > >
> > > > > > Amit Bawer (2):
> > > > > >   python: Remove init_lockspace() deprecated API
> > > > > >   python: Remove init_resource() deprecated API
> > > >
> > > > Do you have public git where I can pull these changes?
> > > > > > python/sanlock.c     | 105
> > > > > > tests/python_test.py |  31 -------------
> > > > > >  2 files changed, 136 deletions(-)
> > > > >
> > > > > +1 to both patches

[PATCH 0/2] Remove init_lockspace and init_resource API

[Nir Soffer]

On Mon, Aug 24, 2020 at 8:14 PM Amit Bawer  wrote:
> On Mon, Aug 24, 2020 at 8:12 PM Nir Soffer  wrote:
> > On Mon, Aug 24, 2020 at 8:11 PM Nir Soffer  wrote:
> > > On Mon, Aug 24, 2020 at 8:09 PM Amit Bawer  wrote:
> > > > Well, I submitted them first to your copy like we did until so far.
> > > > but i was asked to use the mailing list instead.
> > > > So you have them in the PR of nirs/sanlock:
> > > > https://github.com/nirs/sanlock/pull/21
> > >
> > > That is https://github.com/aabawer/sanlock/tree/remove_init then.
> >
> > commit 47d0b4281ad5de78092abd7b750d64a5334452fa
> >
> > Right?
>
> Both two top commits there.

Ok, David already merged this :-)
> > > > On Mon, Aug 24, 2020 at 7:17 PM Nir Soffer  wrote:
> > > > > On Mon, Aug 24, 2020 at 10:09 AM Vojtech Juranek  wrote:
> > > > > > On neděle 23. srpna 2020 10:35:37 CEST Amit Bawer wrote:
> > > > > > > init_lockspace() and init_resoruce() API was deprected by
> > > > > > > respective write_lockspace() and write_resource() API way back.
> > > > > > > It was only kept for backward compatibility with legacy python2
> > > > > > > code still consuming the old API. Now that python2 has officialy
> > > > > > > retired, the deprecated python API can be cleared from sanlock.
> > > > > > >
> > > > > > > Amit Bawer (2):
> > > > > > >   python: Remove init_lockspace() deprecated API
> > > > > > >   python: Remove init_resource() deprecated API
> > > > >
> > > > > Do you have public git where I can pull these changes?
> > > > > > >
> > > > > > >  python/sanlock.c     | 105 -------------------------------------------
> > > > > > >  tests/python_test.py |  31 -------------
> > > > > > >  2 files changed, 136 deletions(-)
> > > > > >
> > > > > > +1 to both patches