Ditto on all this. I'm guilty of doing both, but standardizing to inline submission (non-attachment) makes a lot of sense.
I'm also well aware that we've got some patches to the list awaiting ACKs -- providing those is high on my todo list for today.
Thanks!
On 04/20/2012 10:51 AM, Spencer R. Shimko wrote:
All,
Some patches have been posted to the list as attachments instead of in-line. This makes it very difficult to provide feedback on parts of the patch. I'd like to see everyone submitting patches use "git format-patch" and "git send-email.. Additionally a [PATCH 0/?] should be generated and a signed-off-by line added.
Basic workflow to accomplish this:
- Modify code.
- Pull from master and rebase your patches on top of any changes pulled
down. 3. $ git format-patch --cover-letter -s HEAD~4 (where 4 equals the number of commits you submitting to the list) 4. $ git send-email --to "scap-security-guide@lists.fedorahosted.org scap-security-guide@lists.fedorahosted.org" *.patch
I've had some discussions with Jeff and we are moving to the ACK/NACK model. If you have commit access please wait for an ACK from another maintainer prior to pushing to master. If the person submitting the patch does not have commit access the maintainer providing the ACK should push it into master.
Thanks, --Spencer
scap-security-guide mailing list scap-security-guide@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/scap-security-guide