[PATCH 1/1] fix building against musl and uClibc libc libraries.

From: Adam Duskett <Aduskett(a)gmail.com&gt;

Currently, the src/Makefile provides the FTS_LDLIBS when building against musl
or uClibc. However, this is missing from utils/Makefile, which causes linking
to fail.

Add the FTS_LDLIBS variable to the LDLIBS variable in utils/Makefile to fix
compiling against uClibc and musl.

Signed-off-by: Adam Duskett <Aduskett(a)gmail.com&gt;
---
 libselinux/utils/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile
index 36150638..a5632b7c 100644
--- a/libselinux/utils/Makefile
+++ b/libselinux/utils/Makefile
@@ -45,7 +45,7 @@ endif
 
 override CFLAGS += -I../include -D_GNU_SOURCE $(DISABLE_FLAGS) $(PCRE_CFLAGS)
 override LDFLAGS += -L../src
-override LDLIBS += -lselinux
+override LDLIBS += -lselinux $(FTS_LDLIBS)
 PCRE_LDLIBS ?= -lpcre
 
 ifeq ($(ANDROID_HOST),y)
-- 
2.25.1

[Ondrej Mosnacek]

Hi Adam,

you sent the patch to the wrong list :) The correct one for SElinux
upstream patches is: selinux(a)vger.kernel.org

Thanks,

On Tue, Apr 7, 2020 at 2:15 AM <aduskett(a)gmail.com&gt; wrote:
>  From: Adam Duskett <Aduskett(a)gmail.com&gt;
>
>  Currently, the src/Makefile provides the FTS_LDLIBS when building against musl
>  or uClibc. However, this is missing from utils/Makefile, which causes linking
>  to fail.
>
>  Add the FTS_LDLIBS variable to the LDLIBS variable in utils/Makefile to fix
>  compiling against uClibc and musl.
>
>  Signed-off-by: Adam Duskett <Aduskett(a)gmail.com&gt;
>  ---
>   libselinux/utils/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>  diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile
>  index 36150638..a5632b7c 100644
>  --- a/libselinux/utils/Makefile
>  +++ b/libselinux/utils/Makefile
>  @@ -45,7 +45,7 @@ endif
>
>   override CFLAGS += -I../include -D_GNU_SOURCE $(DISABLE_FLAGS) $(PCRE_CFLAGS)
>   override LDFLAGS += -L../src
>  -override LDLIBS += -lselinux
>  +override LDLIBS += -lselinux $(FTS_LDLIBS)
>   PCRE_LDLIBS ?= -lpcre
>
>   ifeq ($(ANDROID_HOST),y)
>  --
>  2.25.1
>  _______________________________________________
>  selinux mailing list -- selinux(a)lists.fedoraproject.org
>  To unsubscribe send an email to selinux-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail]... 
-- 
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.

[Adam Duskett]

Doh! Thank you! I appreciate the help! There are a few lists for SELinux!

Adam

On Tue, Apr 7, 2020 at 12:59 AM Ondrej Mosnacek <omosnace(a)redhat.com&gt; wrote:
>
> Hi Adam,
>
> you sent the patch to the wrong list :) The correct one for SElinux
> upstream patches is: selinux(a)vger.kernel.org
>
> Thanks,
>
> On Tue, Apr 7, 2020 at 2:15 AM <aduskett(a)gmail.com&gt; wrote:
> > From: Adam Duskett <Aduskett(a)gmail.com&gt;
> >
> > Currently, the src/Makefile provides the FTS_LDLIBS when building against musl
> > or uClibc. However, this is missing from utils/Makefile, which causes linking
> > to fail.
> >
> > Add the FTS_LDLIBS variable to the LDLIBS variable in utils/Makefile to fix
> > compiling against uClibc and musl.
> >
> > Signed-off-by: Adam Duskett <Aduskett(a)gmail.com&gt;
> > ---
> >  libselinux/utils/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile
> > index 36150638..a5632b7c 100644
> > --- a/libselinux/utils/Makefile
> > +++ b/libselinux/utils/Makefile
> > @@ -45,7 +45,7 @@ endif
> >
> >  override CFLAGS += -I../include -D_GNU_SOURCE $(DISABLE_FLAGS) $(PCRE_CFLAGS)
> >  override LDFLAGS += -L../src
> > -override LDLIBS += -lselinux
> > +override LDLIBS += -lselinux $(FTS_LDLIBS)
> >  PCRE_LDLIBS ?= -lpcre
> >
> >  ifeq ($(ANDROID_HOST),y)
> > --
> > 2.25.1
> > _______________________________________________
> > selinux mailing list -- selinux(a)lists.fedoraproject.org
> > To unsubscribe send an email to selinux-leave(a)lists.fedoraproject.org
> > Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
https://lists.fedoraproject.org/archives/list/[e-mail]...
>
> --
> Ondrej Mosnacek <omosnace at redhat dot com>
> Software Engineer, Security Technologies
> Red Hat, Inc.
>