Emmanuel gave me permission to forward his review to the list.
******************************************************************* Hello, John.
I've finally taken the time to review the playbooks and have a number of comments to make:
* I'm not sure why there are two playbooks to be run on the nfs server. Given that it makes no sense to run nfs_service_export if nfs_service hasn't been run beforehand, I would just combine the two playbooks. If the goal is to run the export tasks on their own, I would use an 'export' tag on these two tasks. * Ditto for nfs_client and nfs_client_mount. I would just go with one playbook. * In nfs_client_mount, I would create /etc/systemd/system/*.mount files and start the mount unit instead of editing /etc/fstab and running "mount -a" * I'm not sure what the /var/nfs4 task in nfs_client is supposed to do. * In nfs_service_export, /etc/exports would seem a more suitable default than /etc/exports.d/nfs.exports but I would really like users to be able to specify what file they put their export entries in so there's no need to change this. * The 0755 rights on that file seem excessive. I would imagine 0644 to be enough * I imagine having /etc and /var being hardcoded in the mount task was not your original idea.
Once the playbooks are commited in a git repo, I can submit pull requests, if you prefer.
Emmanuel
************************************************************
Thanks to Emmanuel for the review.
On Fri, 2024-08-23 at 14:29 -0500, John W. Himpel wrote:
All,
I think I have finally figured out how to interact with git and pagure. In the pagure instance of fedora-server, I have added four (4) ansible roles.
- nfs_service - Install and configure NFSv4 service to start serving
directories. It takes care of firewalld settings, idmapd settings and creates a directory from which other directories will be served. 2) nfs_service_export - Generates /etc/exports entries and mounts the shared directories. 3) nfs_client - Install and configure directory used to mount shared directories and configure idmapd.conf. 4) nfs_client_mount - Create entries in /etc/fstab for mounting rmotely shared directories
For now, please ignore the README.md files. The ones currently committed are just boilerplate stuff. I hope to work on real README.md files in the next couple of days.
Since we have not published guidelines for how our ansible roles should be structured, this is my attempt to start that discussion.. Do NOT take these roles as FINAL. At this point in time, they are just examples that can be used for discussion.
Emmanuel Seyman has already commented on these roles in an off-list email to me. If he gives me permission to forward his comments to the list, I will gladly do so.
Please keep all of the discussion on the list, so that we have a history and rational for what we finally decide is proper form and content.
Thanks to Kevin Fenzi for assistance in helping me with suggestions on how to use git interacting with pagure.