spacewalk/package/spacewalk.spec | 11 +++++++++++
spacewalk/setup/bin/spacewalk-setup | 32 ++++++++++++--------------------
2 files changed, 23 insertions(+), 20 deletions(-)
New commits:
commit e9819cdcbadd63806beb31c4c51b4e9a7007a0d2
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Wed Sep 2 14:11:55 2009 +0200
added database backend to defaults; installer will not ask about it
diff --git a/spacewalk/package/spacewalk.spec b/spacewalk/package/spacewalk.spec
index c55ffd7..be6b1d7 100644
--- a/spacewalk/package/spacewalk.spec
+++ b/spacewalk/package/spacewalk.spec
@@ -138,6 +138,13 @@ Solaris machines.
rm -rf $RPM_BUILD_ROOT
install -d $RPM_BUILD_ROOT/%{_sysconfdir}
echo "Spacewalk release %{version} (%{release_name})" > $RPM_BUILD_ROOT/%{_sysconfdir}/spacewalk-release
+install -d $RPM_BUILD_ROOT/%{_datadir}/spacewalk/setup/defaults.d
+for i in oracle postgresql ; do
+ cat <<EOF >$RPM_BUILD_ROOT/%{_datadir}/spacewalk/setup/defaults.d/$i-backend.conf
+# database backend to be used by spacewalk
+db-backend = $i
+EOF
+done
%clean
rm -rf %{buildroot}
@@ -147,8 +154,12 @@ rm -rf %{buildroot}
%{_sysconfdir}/spacewalk-release
%files oracle
+%defattr(-,root,root)
+%{_datadir}/spacewalk/setup/defaults.d/oracle-backend.conf
%files postgresql
+%defattr(-,root,root)
+%{_datadir}/spacewalk/setup/defaults.d/postgresql-backend.conf
%changelog
* Tue Sep 01 2009 Michael Mraka <michael.mraka(a)redhat.com> 0.7.1-1
commit 2d0b070b55ccb846436b1582d0da24a2ebbafb48
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Wed Sep 2 14:02:04 2009 +0200
don't even ask about db-backend when it's set in answer file
diff --git a/spacewalk/setup/bin/spacewalk-setup b/spacewalk/setup/bin/spacewalk-setup
index d034585..6e1299c 100755
--- a/spacewalk/setup/bin/spacewalk-setup
+++ b/spacewalk/setup/bin/spacewalk-setup
@@ -168,33 +168,25 @@ exit 0;
sub choose_database_schema {
my $answers = shift;
- my @valid_schemas = ();
- push(@valid_schemas, "oracle");
- # Uncomment this to enable installation of postgresql schema:
- # NOTE: useful for development ONLY at this time.
- push(@valid_schemas, "postgresql");
- my %is_valid_schema = ();
-
- if (scalar(@valid_schemas) eq 1) {
- $answers->{'db-backend'} = $valid_schemas[0];
- }
- else {
- print "Available database backends:\n";
- # Hash just used for checking if a schema is valid:
- while (my $i = shift @valid_schemas) {
- print " $i\n";
- $is_valid_schema{$i} = 1;
- }
+ my %is_valid_schema = (
+ 'oracle' => 1,
+ # Uncomment this to enable installation of postgresql schema:
+ # NOTE: useful for development ONLY at this time.
+ 'postgresql' => 1,
+ );
- Spacewalk::Setup::ask(
+ my $question = "Choose your database backend ("
+ . join(", ", sort(keys(%is_valid_schema)))
+ . ")";
+
+ Spacewalk::Setup::ask(
-noninteractive => $opts{"non-interactive"},
- -question => 'Database',
+ -question => $question,
-test => sub {
my $text = shift;
$is_valid_schema{$text}
},
-answer => \$answers->{'db-backend'});
- }
}