web/modules/dobby/Dobby/BackupLog.pm | 6 ++++-- web/modules/dobby/Dobby/Files.pm | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-)
New commits: commit 854378c2a4820f685788d0e1820b95afc8240914 Author: Jan Pazdziora jpazdziora@redhat.com Date: Fri Feb 18 10:04:26 2011 +0100
Localize the FH; also use three-parameter open.
diff --git a/web/modules/dobby/Dobby/BackupLog.pm b/web/modules/dobby/Dobby/BackupLog.pm index 4b8d039..945f65e 100644 --- a/web/modules/dobby/Dobby/BackupLog.pm +++ b/web/modules/dobby/Dobby/BackupLog.pm @@ -37,7 +37,8 @@ sub parse {
eval { $doc = $parser->parse_file($restore_log); }; if ($@) { - open FH, "<$restore_log" or die "open $restore_log: $!"; + local * FH; + open FH, '<', $restore_log or die "open $restore_log: $!"; my $contents = join("", <FH>); close FH; $log = thaw($contents); @@ -149,7 +150,8 @@ sub serialize { my $self = shift; my $dest = shift;
- open FH, ">$dest" or die "open $dest: $!"; + local * FH; + open FH, '>', $dest or die "open $dest: $!"; print FH $self->toXml(); close FH; }
commit 44c698cce70570fc3b5ce5de09aa1243d279228c Author: Jan Pazdziora jpazdziora@redhat.com Date: Fri Feb 18 10:03:15 2011 +0100
Localize IN and OUT; also use three-parameter open.
diff --git a/web/modules/dobby/Dobby/Files.pm b/web/modules/dobby/Dobby/Files.pm index 577a0d2..8986927 100644 --- a/web/modules/dobby/Dobby/Files.pm +++ b/web/modules/dobby/Dobby/Files.pm @@ -27,7 +27,8 @@ sub gzip_copy { my $src = shift; my $dst = shift;
- open IN, "<$src" or die "open $src: $!\n"; + local * IN; + open IN, '<', $src or die "open $src: $!\n"; my $gz = gzopen("$dst", "wb") or die "gzopen: $!\n"; my $ctx = new Digest::MD5;
@@ -53,8 +54,9 @@ sub gunzip_copy { my $dst = shift;
my $write; + local * OUT; if ($dst) { - open OUT, ">$dst" or die "open $dst: $!\n"; + open OUT, '>', $dst or die "open $dst: $!\n"; $write = 1 } else {
spacewalk-commits@lists.fedorahosted.org