[spin-kickstarts] Prevent warning about @base being not found

[Bruno Wolff III]

commit 9556cf3bc0d6a553a75fde861fe39c7f6682f508
Author: Bruno Wolff III <bruno(a)wolff.to&gt;
Date:   Fri Jul 5 22:31:41 2013 -0500

    Prevent warning about @base being not found
    
    @base was renamed to @standard, but @base is still include by
    default by pungi. Using --nobase prevents a warning message
    from being issued.

 fedora-install-fedora.ks |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/fedora-install-fedora.ks b/fedora-install-fedora.ks
index f630b1e..35996eb 100644
--- a/fedora-install-fedora.ks
+++ b/fedora-install-fedora.ks
@@ -25,7 +25,8 @@ repo --name=rawhide-source 
--mirrorlist=http://mirrors.fedoraproject.org/mirror
 
 # Package manifest for the compose.  Uses repo group metadata to translate groups.
 # (default groups for the configured repos are added by --default)
-%packages --default
+# @base got renamed to @standard, but @base is still included by default by pungi.
+%packages --default --nobase
 
 # pungi is an inclusive depsolver so that multiple packages are brought 
 # in to satisify dependencies and we don't always want that. So we  use

[Bill Nottingham]

Bruno Wolff III (bruno(a)fedoraproject.org) said: 
>  commit 9556cf3bc0d6a553a75fde861fe39c7f6682f508
>  Author: Bruno Wolff III <bruno(a)wolff.to&gt;
>  Date:   Fri Jul 5 22:31:41 2013 -0500
>  
>      Prevent warning about @base being not found
>      
>      @base was renamed to @standard, but @base is still include by
>      default by pungi. Using --nobase prevents a warning message
>      from being issued. 
We should likely just patch pungi instead/as well...

Bill

[Bruno Wolff III]

On Tue, Jul 09, 2013 at 17:44:00 -0400,
   Bill Nottingham <notting(a)redhat.com&gt; wrote:
> Bruno Wolff III (bruno(a)fedoraproject.org) said:
> > commit 9556cf3bc0d6a553a75fde861fe39c7f6682f508
> > Author: Bruno Wolff III <bruno(a)wolff.to&gt;
> > Date:   Fri Jul 5 22:31:41 2013 -0500
> >
> >     Prevent warning about @base being not found
> >
> >     @base was renamed to @standard, but @base is still include by
> >     default by pungi. Using --nobase prevents a warning message
> >     from being issued.
>
> We should likely just patch pungi instead/as well... 
Probably, but I don't maintain that and wasn't sure if there is just one 
version that needs to work with stuff that does assume @base is needed 
and for which there still is an @base. So this might need to be phased 
out gradually.

[Dennis Gilmore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 9 Jul 2013 17:44:00 -0400
Bill Nottingham <notting(a)redhat.com&gt; wrote:

>  Bruno Wolff III (bruno(a)fedoraproject.org) said: 
>  > commit 9556cf3bc0d6a553a75fde861fe39c7f6682f508
>  > Author: Bruno Wolff III <bruno(a)wolff.to&gt;
>  > Date:   Fri Jul 5 22:31:41 2013 -0500
>  > 
>  >     Prevent warning about @base being not found
>  >     
>  >     @base was renamed to @standard, but @base is still include by
>  >     default by pungi. Using --nobase prevents a warning message
>  >     from being issued.
>  
>  We should likely just patch pungi instead/as well...
>  
we should patch pungi for this, papering over something like this in
spin-kickstarts is wrong.

Dennis
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.19 (GNU/Linux)
>
> iEYEARECAAYFAlHrXaMACgkQkSxm47BaWfcslwCeJUvlNYs2qxOjFbUbSQ1l6TiU
> 2T8An09g5g6ftHdZ7hdp0p/Obgf3oB/j
> =8m90
> -----END PGP SIGNATURE-----
>

[Bruno Wolff III]

On Sat, Jul 20, 2013 at 23:03:47 -0500,
   Dennis Gilmore <dennis(a)ausil.us&gt; wrote:
> we should patch pungi for this, papering over something like this in
> spin-kickstarts is wrong. 
It looks like the main place to change this is in pykickstarts. The --nobase 
option was deprecated with F18. I am not sure if the right way is to 
change things so that addbase is just false going forward from some 
Fedora release. Or if that value shouldn't be returned and pungi and other 
things should also be changed to stop checking for it.