sssd-devel November 2012

sssd-devel@lists.fedorahosted.org

15 participants
101 discussions

[PATCH 0/1] Simplify writing update functions
by Simo Sorce 19 Nov '12

19 Nov '12

While approaching the problem of updating the DB after a patch I am working on I noticed that we do have a lot of biolerplate code in there that could very simply be tucked into 2 helper functions, simplifying writing upgrade functions and making it less likely a typo or copy&paste error will create issues with version numbers. I love the 425 deletions :-) I tried to have a light hand in changing existing code to avoid introducing bugs but I have added an example skeleton so that future upgrade functions can stop using a tmp_ctx memory context and just use the new upgrade_ctx as their local memory context. Simo Sorce (1): Simplify writing db update functions src/db/sysdb_upgrade.c | 621 +++++++++++++++--------------------------------- 1 files changed, 196 insertions(+), 425 deletions(-)

3 4

[PATCH] Fix saving empty LDAP groups
by Jakub Hrozek 19 Nov '12

19 Nov '12

We broke saving nested LDAP groups with no members in 1.9 during the conversion to ghost users. The attached patches fix that. The first three patches would be nice to get into 1.9, the last patch is OK in master only. I just found the code hard to read sometimes so I split it into a separate functions and used more descriptive variable names. I also think that the branch that the branch that re-read SDAP_AT_GROUP_MEMBER after reading SYSDB_GHOST is not needed.

3 7

[PATCH] SERVER: Check the return value of waitpid
by Jakub Hrozek 19 Nov '12

19 Nov '12

We should at least print an error message and error out if waitpid() fails. https://fedorahosted.org/sssd/ticket/1651

2 4

[PATCH] Display more information on DB version crash
by Ondrej Kos 19 Nov '12

19 Nov '12

https://fedorahosted.org/sssd/ticket/1589 patch is attached O. -- Ondrej Kos Associate Software Engineer Identity Management Red Hat Czech phone: +420-532-294-558 cell: +420-736-417-909 ext: 82-62558 loc: 1013 Brno 1 office irc: okos @ #brno

4 16

[PATCH] SUDO: Fix wrong variable check
by Jakub Hrozek 19 Nov '12

19 Nov '12

https://fedorahosted.org/sssd/ticket/1650

2 2

[PATCH] LDAP: Remove double break
by Jakub Hrozek 19 Nov '12

19 Nov '12

I noticed this small bug when I was working on another ticket.

2 2

[PATCH] SYSDB: Remove unused macros
by Jakub Hrozek 19 Nov '12

19 Nov '12

Simo noted during our debugging session that some sysdb macros are unused. This patch removes them.

2 2

[PATCH] LDAP: Expire even non authenticated connections
by Jakub Hrozek 19 Nov '12

19 Nov '12

The connections request was terminated before setting the expiry timeout in case no authentication was set. https://fedorahosted.org/sssd/ticket/1649

2 2

[PATCH] Provide AM_COND_IF-combatible implementation for old automake systems
by Jakub Hrozek 17 Nov '12

17 Nov '12

The attached patch fixes the build of git HEAD on RHEL5 for me. AM_COND_IF is a very handy construct that is not present on old automake systems such as the one in RHEL5. The original author of the code is Ralf Corsepius <rc040203 -at- freenet.de>

2 2

fix -O3 variable may be uninitialized warnings
by Pavel Březina 17 Nov '12

17 Nov '12

I think all of these are false positives so I just initialized the variables to silent the compiler. echo $CFLAGS -m64 -mtune=generic -O3 -fstack-protector-all -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter src/providers/ldap/sdap_async_groups.c: In function 'sdap_nested_group_process_ldap_user': src/providers/ldap/sdap_async_groups.c:3408:8: warning: 'count' may be used uninitialized in this function [-Wmaybe-uninitialized] src/providers/ldap/sdap_async_groups.c:3432:5: warning: 'replies' may be used uninitialized in this function [-Wmaybe-uninitialized] src/providers/ldap/sdap_async_groups.c: In function 'sdap_nested_group_process_user': src/providers/ldap/sdap_async_groups.c:3195:8: warning: 'count' may be used uninitialized in this function [-Wmaybe-uninitialized] src/providers/ldap/sdap_async_groups.c:3220:5: warning: 'replies' may be used uninitialized in this function [-Wmaybe-uninitialized] src/providers/ldap/sdap_sudo.c: In function 'sdap_sudo_periodical_full_refresh_done': src/providers/ldap/sdap_sudo.c:1024:9: warning: 'dp_error' may be used uninitialized in this function [-Wmaybe-uninitialized] src/providers/ldap/sdap_sudo.c:1024:9: warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized]

3 2

← Newer
1
...
4
5
6
7
8
9
10
11
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel November 2012