sssd-devel November 2012

sssd-devel@lists.fedorahosted.org

15 participants
101 discussions

[PATCH] Null pointer dereferenced.
by Michal Židek 29 Nov '12

29 Nov '12

https://fedorahosted.org/sssd/ticket/1674 Another bug found by Coverity. This patch changes indentation in part of the code (so it looks bigger than it actually is). I updated debug messages in the changed part with the new SSSDBG_* macros. Patch is attached. Thanks Michal

5 7

[PATCH] when monitor_quit is call and the process not exists
by Ariel Barria 28 Nov '12

28 Nov '12

Hi. well, I'm not sure that this patch have the behavior that is it hope. You have the word. But when monitor_quit is call and the process not exists, this remains in loop and not allow signal. I try it with Monitor Task and nothing. I had to reboot

3 7

[PATCH] Allow more libldap debugging
by Jakub Hrozek 28 Nov '12

28 Nov '12

This patch should not be pushed to master, but I would like to get it reviewed anyway. It should be used to provide a custom build for users experiencing cases where ldap_search_ext would block (c.f. https://bugzilla.redhat.com/show_bug.cgi?id=728343) For example: export SSSD_DEBUG_LDAP_SEARCH="0xffff" would set LDAP_DEBUG_ANY The attached patch applies cleanly on the RHEL6.1 branch. I also have a version that applies on master/1.5 if needed.

4 7

[PATCH 0/3] cleanups for talloc_zfree
by Simo Sorce 28 Nov '12

28 Nov '12

While coding my latest patch I found an annoying const warning when freeing strings we allocate with talloc but then assign to a variable of type "const char *". This made me investigate our talloc_zfree macro and I found a weird patch, made back in the times that really doesn't make much sense. I reverted that and then applied a fix to avoid const warnings, as they are bogus in this case. I also removed a duplicated macro that was out of sync already. Simo Sorce (3): Revert "Avoid accessing half-deallocated memory when using talloc_zfree macro." Avoid duplicating macros Avoid const warnings when deallocating memory src/ldb_modules/memberof.c | 4 ---- src/util/util.h | 6 +----- 2 files changed, 1 insertions(+), 9 deletions(-)

6 21

[PATCH] idmap: Silence DEBUG messages when dealing with built-in, SIDs.
by Michal Židek 28 Nov '12

28 Nov '12

https://fedorahosted.org/sssd/ticket/1593 With this patch we get: [sssd[be[AD]]] [sdap_save_group] (0x1000): Mapping group [Administrators] objectSID to unix ID [sssd[be[AD]]] [sdap_idmap_sid_to_unix] (0x0400): Object SID [S-1-5-32-544] is a built-in one. [sssd[be[AD]]] [sdap_save_group] (0x0400): Skipping built-in object. Instead of the old messages, that looked like this: [sssd[be[AD]]] [sdap_save_group] (0x1000): Mapping group [Administrators] objectSID to unix ID [sssd[be[AD]]] [sdap_idmap_sid_to_unix] (0x0080): Could not parse domain SID from [S-1-5-32-544] [sssd[be[AD]]] [sdap_save_group] (0x0080): Could not convert SID string: [Invalid argument] [sssd[be[AD]]] [sdap_save_group] (0x0080): Failed to save group [Administrators]: [Invalid argument] [sssd[be[AD]]] [sdap_save_groups] (0x0040): Failed to store group 0. Ignoring. The patch is attached. NOTE: To reproduce, set enumerate = true for the AD domain, delete the cache files and start SSSD. Thanks Michal

4 13

[PATCH] Uninitialized pointer read
by Michal Židek 28 Nov '12

28 Nov '12

https://fedorahosted.org/sssd/ticket/1673 There was a typo in the code (s/res/dom_res) which could result in segfault (found by Coverity). Thanks Michal

3 2

[PATCHES] sss_userdel and sss_groupdel should invalidate mmap cache
by Michal Židek 28 Nov '12

28 Nov '12

Patch 1: sss_cache refactor. See patch description for more details. Patch 2: Remove mmap cache properly in sss_userdel and sss_groupdel Patches are attached. Thanks Michal

4 12

[PATCH] sudo: do not hardcode protocol version
by Pavel Březina 27 Nov '12

27 Nov '12

3 4

[PATCH 0/5] Fix various tevent_req style and naming issues
by Simo Sorce 27 Nov '12

27 Nov '12

While I was working on an unrelated patchset I couldn't help fixing some of the code to properly use tevent_req style and naming conventions. This will bring this code in line with our tevent_req coding style and hopefully make it more readable to eyes used to the tevent_req style. It also fixes use of some inconsistent function names. The krb5_auth.c changes are a bit tricky because I needed to change the flow in several places and built helper functions to reduce a bit some of the long functions. I have been careful to make sure I did not change the actual program flow and the patches work fine for me, so I am now dropping the RFC and asking for review and inclusion in master. Simo Sorce (5): Fix tevent_req style for krb5_auth Fix ipa_subdomain_id names and tevent_req style Fix tevent_req style for get_netgroup in ipa_id Streamline ipa_account_info handler Use an entry type mask macro to filter entry types src/providers/data_provider.h | 1 + src/providers/ipa/ipa_id.c | 252 ++++++++-------- src/providers/ipa/ipa_id.h | 10 +- src/providers/ipa/ipa_subdomains_id.c | 75 ++--- src/providers/krb5/krb5_access.c | 6 +- src/providers/krb5/krb5_auth.c | 556 +++++++++++++++------------------ src/providers/krb5/krb5_auth.h | 2 +- src/providers/krb5/krb5_wait_queue.c | 12 +- src/providers/ldap/ldap_id.c | 2 +- src/providers/proxy/proxy_id.c | 2 +- 10 files changed, 432 insertions(+), 486 deletions(-)

3 34

[PATCH] TESTS: Test ghosts users in the RFC2307 schema
by Jakub Hrozek 26 Nov '12

26 Nov '12

I'm implementing unit tests for the ghosts users feature to make sure we catch all the problems for the next upstream release. Attached is a patch with a couple of unit tests that simulate what the LDAP provider would do when using the RFC2307 schema. Suggestions for new tests are welcome. Please note that the mod operation inside the memberof plugin will be implemented as part of #1652, so any tests that modify the ghost users attribute (as opposed to add or delete) won't work at the moment.

2 4

← Newer
1
2
3
4
5
6
7
...
11
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel November 2012