sssd-devel October 2013

sssd-devel@lists.fedorahosted.org

19 participants
84 discussions

[PATCH] PROXY: Handle empty GECOS
by Jakub Hrozek 20 Nov '13

20 Nov '13

I found this bug while triaging a customer case with Chris Hudson who ran into the same issue Simo fixed recently in the proxy provider.

2 3

Fix proxy backend initgroups_dyn code
by Simo Sorce 20 Nov '13

20 Nov '13

Tested fix for #2051 and seem to work. However it just occurred to me we may always want to check if pwd.pw_gid is listed in the gids returned and add it if not ? Simo. -- Simo Sorce * Red Hat, Inc * New York

3 5

[PATCHES] Alignment issues reported by Clang
by Michal Židek 15 Nov '13

15 Nov '13

Patches 1-4 and 9: These patches use the SAFEALIGN macros where it is appropriate. I split them into several patches for easier review, so that client code changes are not mixed with the rest of the code and changes that are a little different than the rest have their own patch. Patches 5-6: Here I think it is not needed to use uint8_t* or char*. We cast the pointer anyway and there are no real alignment issues (the memory is aligned properly). I was thinking about suppressing the warnings with #pragma here, but in this particular situation it is IMO better to have just void*. Patches 7-8: These were all false positive warnings. It is possible to suppress them with additional casting but I found it less readable so I used #pragma. Patch 10: We had improperly aligned part of a buffer used in client code. Also some code blocks here must rely on fact that the buffer they get is aligned properly (they can do nothing about it if it isn't). In these cases it is better to silence the warnings, so that it does not make permanent noise during compilation. Thanks Michal

5 13

[PATCH] Inherit ID limits of parent domains if set
by Jakub Hrozek 14 Nov '13

14 Nov '13

Hi, the attached patch was tested by a customer running RHEL6. I'm not sure if we should do any more checking when running on a modern system where ranges can be better defined on the IPA side for example?

2 3

[PATCH] Add ldap_autofs_map_master_name option
by C. S. 12 Nov '13

12 Nov '13

Add ldap_autofs_map_master_name option so that the auto master map name change be changed from the default auto.master.

3 17

[PATCH] UTIL: Free log message when using journald
by Jakub Hrozek 07 Nov '13

07 Nov '13

I was exercising sssd with valgrind when looking for #1020945 and found this leak.

3 6

[PATCH] confdb: Make offline timeout configurable
by Michal Židek 07 Nov '13

07 Nov '13

I decided not to only document the behaviour, but also add option to configure it (so I could remove one FIXME from the code). https://fedorahosted.org/sssd/ticket/1718 Michal

5 11

[PATCH] responder: Access packet header using SAFEALIGN macros
by Michal Židek 07 Nov '13

07 Nov '13

Hello, the attached patch should uses the SAFEALIGN macros to access data in the packet header (in sss_packet structure) so that it does not depend on proper memory alignment (currently the alignment is OK, but if we add something to the packet header later, it is probably safer not to depend on proper alignment). It also silences a lot of alignment warnings. Thanks Michal

4 10

[PATCH] Include external headers with #include <foo.h>
by Jakub Hrozek 04 Nov '13

04 Nov '13

Attached is a style patch. Feel free to ack or nack, it's just a readability improvement.

5 16

[PATCH] NSS: Check allocation result
by Jakub Hrozek 01 Nov '13

01 Nov '13

Another small bug I found when looking for #1020945

5 9

← Newer
1
2
3
4
5
6
7
8
9
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel October 2013