sssd-devel November 2013

sssd-devel@lists.fedorahosted.org

18 participants
68 discussions

[PATCHES] Heimdal Support
by Benjamin Franzke 23 Dec '13

23 Dec '13

Hi list, I've tried to use sssd with heimdal, there were some fixes to be done. Are you intrested in reviewing and integrating them? They are available at: https://git.bnfr.net/sssd/log/?h=heimdal-1 Note: They are on top of other build fixes i've send to the list (but thats visible in the log). This compiles without warnings and passes all make tests. Actually i've added alternatives for deprecated (in terms of heimdal) kerberos functions to avoid warnings there. I've tested this in a samba 4 environment (with the sssd-ad module). Regards, Ben

5 8

German po4a translation
by Chris Leick 19 Dec '13

19 Dec '13

Hi, please find attached the german po4a translation of sssd. While translating, I've found some bugs in the english text. They are marked in the po file with »FIXME«. Kind regards, Chris

5 18

[PATCHES] idmap: add API to free allocated SIDs
by Pavel Březina 19 Dec '13

19 Dec '13

https://fedorahosted.org/sssd/ticket/2133

5 12

[PATCHES] Fixes for sss_cache
by Sumit Bose 19 Dec '13

19 Dec '13

Hi, Steeve found some issues when testing sss_cache with sub-domain users. This was originally fixed in https://fedorahosted.org/sssd/ticket/1741 but I guess recent changes have broken it again. I have tested the patches with users and groups. It would be nice is someone with a suitable environment can test them for the other object types as well. bye, Sumit

2 14

DEBUG macro refactoring
by Nikolai Kondrashov 18 Dec '13

18 Dec '13

Hi everyone, I've been looking at the sssd sources for some test failure investigation and noticed that the DEBUG macro expands to quite a lot of code. I decided to see if it can be reduced and what the impact will be. The result is the patches that follow. I've noticed that the total size of installed binaries produced by the standard Fedora build with "reconfig && chmake" drops by 20% after applying these patches. A build on Debian, configured similarly to the one used in the Debian package dropped by 44%. I've verified that all the patches build and pass the tests run by "chmake", but otherwise haven't tested them. Sincerely, Nick

7 37

[PATCHES] ad: use tokengroups even when id mapping is disabled
by Pavel Březina 18 Dec '13

18 Dec '13

https://fedorahosted.org/sssd/ticket/1568

5 19

[PATCH 6/7] Properly align buffer when storing pointers.
by Michal Židek 10 Dec '13

10 Dec '13

On 11/14/2013 01:14 PM, Lukas Slebodnik wrote:>>From 45336d3596b8d93ebf866c727c566169c404b60c Mon Sep 17 00:00:00 2001 >> >From: Michal Zidek<mzidek(a)redhat.com> >> >Date: Tue, 10 Sep 2013 23:09:04 +0200 >> >Subject: [PATCH 6/7] Properly align buffer when storing pointers. >> > >> >Properly align buffer address to sizeof(char *) when storing >> >pointers to string and disable alignment warnings with #pragma. >> > >> >resolves: >> >https://fedorahosted.org/sssd/ticket/1359 >> >--- >> >src/sss_client/nss_group.c | 5 +++-- >> >src/sss_client/nss_mc_group.c | 3 +++ >> >src/sss_client/nss_services.c | 4 ++-- >> >3 files changed, 8 insertions(+), 4 deletions(-) >> > >> >diff --git a/src/sss_client/nss_group.c b/src/sss_client/nss_group.c >> >index a7fb093..68e14d3 100644 >> >--- a/src/sss_client/nss_group.c >> >+++ b/src/sss_client/nss_group.c >> >@@ -233,14 +233,15 @@ static int sss_nss_getgr_readrep(struct sss_nss_gr_rep *pr, >> > NULL); >> > if (ret != EOK) return ret; >> > >> >- /* Make sure pr->buffer[i+pad] is 32 bit aligned */ >> >+ /* Make sure pr->buffer[i+pad] is aligned to sizeof(char *) */ >> > pad = 0; >> >- while((i + pad) % 4) { >> >+ while((i + pad) % sizeof(char *)) { > I am not sure about this. There was comment; > "Make sure pr->buffer[i+pad] is 32 bit aligned" > > And you changed alignment to 64-bits on x86_64 and to 32-bits on i386 > platform. > This is a client code, so some more experienced should tell what > is the right solution. > Aligning the address to 4 bytes and then using it as the beginning of array of pointers is simply wrong and should be fixed. So I think it was a mistake in both the code and the comment (maybe one led to the other). But is is possible that I am reading the code wrong. Michal

4 17

[PATCH] SUBDOMAINS: Reuse cached results if DP is offline
by Jakub Hrozek 09 Dec '13

09 Dec '13

Please see the simple attached patch. To reproduce, start sssd in offline mode and attempt to authenticate as subdomain user.

2 10

[Patch] Added null checks to authtok module
by Pallavi Jha 09 Dec '13

09 Dec '13

Hello, Please find the attachment below. Kindly review. Thanks, Pallavi

5 16

[PATCH] do not use default_domain_suffix with autofs
by Jakub Hrozek 03 Dec '13

03 Dec '13

Hi, we have a default_domain_suffix parameter in the SSSD with the following description: default_domain_suffix (string) This string will be used as a default domain name for all names without a domain name component. The main use case is environments where the primary domain is intended for managing host policies and all users are located in a trusted domain. The option allows those users to log in just with their user name without giving a domain name as well. Please note that if this option is set all users from the primary domain have to use their fully qualified name, e.g. user(a)domain.name, to log in. Default: not set This turned out to be a problem for one RHEL customer recently who uses the default_domain_suffix option because all his users and groups are stored in AD. But they also use automounter, which means all requests from automounter get fully qualified, auto.master becomes auto.master(a)trusted.ad.domain. And I don't think it's even possible to automounter to make the map name fully qualified (yes, you can override master map name, but then you'd have to also make sure all the nested map and key names are qualified which is insane..) I think that given we only support users and groups from trusted sources now, we should only consider the default domain suffix for users and groups. The customer was kind enough to propose a patch. I think it's correct, except maybe we should amend the option documentation. I can't think of any other part of SSSD that needs patching - sudo's input is username and ssh provider only takes the default domain suffix into consideration for users as well.

2 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel November 2013